Refactor violation codes and update related checks and tests accordingly.

Author: vrslev

README.md

@@ -9,17 +9,17 @@ This plugin implements the following code style checks:
 - **COP001**: Use module import when importing more than two names
 - **COP002**: Import standard library modules as whole modules
 - **COP003**: Avoid explicit scalar type annotations
-- **COP004A**: Attribute name must be at least 8 characters
-- **COP004V**: Variable name must be at least 8 characters
-- **COP004G**: Argument name must be at least 8 characters
-- **COP004F**: Function name must be at least 8 characters
-- **COP004C**: Class name must be at least 8 characters
-- **COP005**: Function identifier must be a verb
-- **COP006**: Avoid `get_` prefix in async function names
-- **COP007**: Avoid temporary variables used only once
-- **COP008**: Classes should be marked `typing.final`
-- **COP009**: Wrap module dictionaries with `types.MappingProxyType`
-- **COP010**: Use dataclasses with `kw_only=True`, `slots=True`, `frozen=True`
+- **COP004**: Attribute name must be at least 8 characters
+- **COP005**: Variable name must be at least 8 characters
+- **COP006**: Argument name must be at least 8 characters
+- **COP007**: Function name must be at least 8 characters
+- **COP008**: Class name must be at least 8 characters
+- **COP009**: Function identifier must be a verb
+- **COP010**: Avoid `get_` prefix in async function names
+- **COP011**: Avoid temporary variables used only once
+- **COP012**: Classes should be marked `typing.final`
+- **COP013**: Wrap module dictionaries with `types.MappingProxyType`
+- **COP014**: Use dataclasses with `kw_only=True`, `slots=True`, `frozen=True`
 
 ## Installation
 

src/community_of_python_flake8_plugin/checks/function_verb.py

@@ -23,7 +23,7 @@ def check_is_verb_name(identifier: str) -> bool:
 def check_is_property(function_node: ast.AST) -> bool:
     if not isinstance(function_node, (ast.FunctionDef, ast.AsyncFunctionDef)):
         return False
-    return any(check_is_property_decorator(decorator) for decorator in function_node.decorator_list)  # noqa: COP007
+    return any(check_is_property_decorator(decorator) for decorator in function_node.decorator_list)  # noqa: COP011
 
 
 def check_is_property_decorator(decorator: ast.expr) -> bool:
@@ -39,7 +39,7 @@ def check_is_property_decorator(decorator: ast.expr) -> bool:
 def check_is_pytest_fixture(function_node: ast.AST) -> bool:
     if not isinstance(function_node, (ast.FunctionDef, ast.AsyncFunctionDef)):
         return False
-    return any(check_is_fixture_decorator(decorator) for decorator in function_node.decorator_list)  # noqa: COP007
+    return any(check_is_fixture_decorator(decorator) for decorator in function_node.decorator_list)  # noqa: COP011
 
 
 def check_is_fixture_decorator(decorator: ast.expr) -> bool:
@@ -61,12 +61,12 @@ def __init__(self, syntax_tree: ast.AST) -> None:
         self.syntax_tree: typing.Final[ast.AST] = syntax_tree
 
     def visit_FunctionDef(self, ast_node: ast.FunctionDef) -> None:
-        parent_class: typing.Final = retrieve_parent_class(self.syntax_tree, ast_node)  # noqa: COP007
+        parent_class: typing.Final = retrieve_parent_class(self.syntax_tree, ast_node)  # noqa: COP011
         self.validate_function_name(ast_node, parent_class)
         self.generic_visit(ast_node)
 
     def visit_AsyncFunctionDef(self, ast_node: ast.AsyncFunctionDef) -> None:
-        parent_class: typing.Final = retrieve_parent_class(self.syntax_tree, ast_node)  # noqa: COP007
+        parent_class: typing.Final = retrieve_parent_class(self.syntax_tree, ast_node)  # noqa: COP011
         self.validate_function_name(ast_node, parent_class)
         self.generic_visit(ast_node)
 

src/community_of_python_flake8_plugin/checks/mapping_proxy.py

@@ -47,7 +47,7 @@ def _check_mapping_assignment(self, ast_node: ast.Assign | ast.AnnAssign) -> Non
         # Only check module-level assignments (no parent function/class)
         if assigned_value is not None and isinstance(assigned_value, ast.Dict) and assignment_targets:
             # Check if this is a module-level assignment
-            for target in assignment_targets:  # noqa: COP007
+            for target in assignment_targets:  # noqa: COP011
                 if isinstance(target, ast.Name):
                     self.violations.append(
                         Violation(

src/community_of_python_flake8_plugin/checks/module_import_many_names.py

@@ -53,7 +53,7 @@ def validate_import_size(self, ast_node: ast.ImportFrom) -> None:
         if module_name is not None and module_name.endswith(".settings"):
             return
 
-        module_import_exists: typing.Final = any(  # noqa: COP007
+        module_import_exists: typing.Final = any(  # noqa: COP011
             isinstance(identifier, ast.alias)
             and module_name is not None
             and check_module_path_exists(f"{module_name}.{identifier.name}")

src/community_of_python_flake8_plugin/checks/name_length.py

@@ -33,7 +33,7 @@ def check_is_whitelisted_annotation(annotation: ast.expr | None) -> bool:
 def check_is_pytest_fixture(ast_node: ast.AST) -> bool:
     if not isinstance(ast_node, (ast.FunctionDef, ast.AsyncFunctionDef)):
         return False
-    return any(check_is_fixture_decorator(decorator) for decorator in ast_node.decorator_list)  # noqa: COP007
+    return any(check_is_fixture_decorator(decorator) for decorator in ast_node.decorator_list)  # noqa: COP011
 
 
 def check_is_fixture_decorator(decorator: ast.expr) -> bool:
@@ -55,31 +55,31 @@ def check_inherits_from_whitelisted_class(class_node: ast.ClassDef) -> bool:
 
 @typing.final
 class COP004NameLengthCheck(ast.NodeVisitor):
-    def __init__(self, tree: ast.AST) -> None:  # noqa: COP004G
+    def __init__(self, tree: ast.AST) -> None:  # noqa: COP006
         self.violations: list[Violation] = []
         self.syntax_tree: typing.Final[ast.AST] = tree
 
     def visit_AnnAssign(self, ast_node: ast.AnnAssign) -> None:
         if isinstance(ast_node.target, ast.Name):
-            parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP007
+            parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP011
             self.validate_name_length(ast_node.target.id, ast_node, parent_class)
         self.generic_visit(ast_node)
 
     def visit_Assign(self, ast_node: ast.Assign) -> None:
         for target in ast_node.targets:
             if isinstance(target, ast.Name):
-                parent_class = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP007
+                parent_class = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP011
                 self.validate_name_length(target.id, ast_node, parent_class)
         self.generic_visit(ast_node)
 
     def visit_FunctionDef(self, ast_node: ast.FunctionDef) -> None:
-        parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP007
+        parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP011
         self.validate_function_name(ast_node, parent_class)
         self.validate_function_args(ast_node)
         self.generic_visit(ast_node)
 
     def visit_AsyncFunctionDef(self, ast_node: ast.AsyncFunctionDef) -> None:
-        parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP007
+        parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP011
         self.validate_function_name(ast_node, parent_class)
         self.validate_function_args(ast_node)
         self.generic_visit(ast_node)

src/community_of_python_flake8_plugin/checks/scalar_annotation.py

@@ -39,22 +39,22 @@ def check_is_scalar_annotation(annotation_node: ast.AST) -> bool:
 def find_parent_function(syntax_tree: ast.AST, target_node: ast.AST) -> ast.FunctionDef | ast.AsyncFunctionDef | None:
     for potential_parent in ast.walk(syntax_tree):
         if isinstance(potential_parent, (ast.FunctionDef, ast.AsyncFunctionDef)):
-            for child_node in ast.walk(potential_parent):  # noqa: COP007
+            for child_node in ast.walk(potential_parent):  # noqa: COP011
                 if child_node is target_node:
                     return potential_parent
     return None
 
 
 @typing.final
 class ScalarAnnotationCheck(ast.NodeVisitor):
-    def __init__(self, tree: ast.AST) -> None:  # noqa: COP004G
+    def __init__(self, tree: ast.AST) -> None:  # noqa: COP006
         self.violations: list[Violation] = []
         self.syntax_tree: typing.Final[ast.AST] = tree
 
     def visit_AnnAssign(self, ast_node: ast.AnnAssign) -> None:
         if isinstance(ast_node.target, ast.Name):
-            parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP007
-            parent_function: typing.Final = find_parent_function(self.syntax_tree, ast_node)  # noqa: COP007
+            parent_class: typing.Final = find_parent_class_definition(self.syntax_tree, ast_node)  # noqa: COP011
+            parent_function: typing.Final = find_parent_function(self.syntax_tree, ast_node)  # noqa: COP011
             in_class_body: typing.Final = parent_class is not None and parent_function is None
 
             if not in_class_body:

src/community_of_python_flake8_plugin/plugin.py

@@ -16,24 +16,23 @@
 class PluginCheckProtocol(typing.Protocol):
     violations: list[Violation]
 
-    def __init__(self, tree: ast.AST) -> None: ...  # noqa: COP004G
-    def visit(self, node: ast.AST) -> None: ...  # noqa: COP004F,COP004G,COP008
+    def __init__(self, tree: ast.AST) -> None: ...  # noqa: COP006
+    def visit(self, node: ast.AST) -> None: ...  # noqa: COP007,COP006,COP012
 
 
 @typing.final
 class CommunityOfPythonFlake8Plugin:
-    name: typing.Final[str] = "community-of-python-flake8-plugin"
-    version: typing.Final[str] = "0.1.27"
+    name: typing.Final[str] = "community-of-python-flake8-plugin"  # noqa: COP004
+    version: typing.Final[str] = "0.1.27"  # noqa: COP004
 
-    def __init__(self, tree: ast.AST) -> None:  # noqa: COP004G
+    def __init__(self, tree: ast.AST) -> None:  # noqa: COP006
         self.ast_syntax_tree: typing.Final[ast.AST] = tree
 
-    def run(self) -> Iterable[tuple[int, int, str, type[object]]]:  # noqa: COP004F
+    def run(self) -> Iterable[tuple[int, int, str, type[object]]]:  # noqa: COP007
         checks_collection: typing.Final[list[PluginCheckProtocol]] = []
 
         for _, module_name, _ in pkgutil.iter_modules(checks_module.__path__):
-            module_full_name = f"{checks_module.__name__}.{module_name}"  # noqa: COP007
-            imported_module = importlib.import_module(module_full_name)
+            imported_module = importlib.import_module(f"{checks_module.__name__}.{module_name}")
 
             for attribute_name in dir(imported_module):
                 attribute = getattr(imported_module, attribute_name)
@@ -44,5 +43,9 @@ def run(self) -> Iterable[tuple[int, int, str, type[object]]]:  # noqa: COP004F
 
         for check_instance in checks_collection:
             for violation in check_instance.violations:
-                message_text = f"{violation.violation_code.code} {violation.violation_code.description}"
-                yield violation.line_number, violation.column_number, message_text, type(self)
+                yield (
+                    violation.line_number,
+                    violation.column_number,
+                    f"{violation.violation_code.code} {violation.violation_code.description}",
+                    type(self),
+                )

src/community_of_python_flake8_plugin/utils.py

@@ -5,7 +5,7 @@
 def find_parent_class_definition(syntax_tree: ast.AST, target_node: ast.AST) -> ast.ClassDef | None:
     for potential_parent in ast.walk(syntax_tree):
         if isinstance(potential_parent, ast.ClassDef):
-            for child_node in ast.walk(potential_parent):  # noqa: COP007
+            for child_node in ast.walk(potential_parent):  # noqa: COP011
                 if child_node is target_node:
                     return potential_parent
     return None

src/community_of_python_flake8_plugin/violation_codes.py

@@ -6,7 +6,7 @@
 @typing.final
 @dataclasses.dataclass(frozen=True, kw_only=True, slots=True)
 class ViolationCodeItem:
-    code: str  # noqa: COP004C
+    code: str  # noqa: COP004
     description: str
 
 
@@ -24,28 +24,26 @@ class ViolationCodes:
     )
 
     # Naming violations (more specific codes)
-    ATTRIBUTE_NAME_LENGTH = ViolationCodeItem(
-        code="COP004A", description="Attribute name must be at least 8 characters"
-    )
-    VARIABLE_NAME_LENGTH = ViolationCodeItem(code="COP004V", description="Variable name must be at least 8 characters")
-    ARGUMENT_NAME_LENGTH = ViolationCodeItem(code="COP004G", description="Argument name must be at least 8 characters")
-    FUNCTION_NAME_LENGTH = ViolationCodeItem(code="COP004F", description="Function name must be at least 8 characters")
-    CLASS_NAME_LENGTH = ViolationCodeItem(code="COP004C", description="Class name must be at least 8 characters")
+    ATTRIBUTE_NAME_LENGTH = ViolationCodeItem(code="COP004", description="Attribute name must be at least 8 characters")
+    VARIABLE_NAME_LENGTH = ViolationCodeItem(code="COP005", description="Variable name must be at least 8 characters")
+    ARGUMENT_NAME_LENGTH = ViolationCodeItem(code="COP006", description="Argument name must be at least 8 characters")
+    FUNCTION_NAME_LENGTH = ViolationCodeItem(code="COP007", description="Function name must be at least 8 characters")
+    CLASS_NAME_LENGTH = ViolationCodeItem(code="COP008", description="Class name must be at least 8 characters")
 
     # Function related violations
-    FUNCTION_VERB = ViolationCodeItem(code="COP005", description="Function name must start with a verb")
-    ASYNC_GET_PREFIX = ViolationCodeItem(code="COP006", description="Avoid get_ prefix in async function names")
+    FUNCTION_VERB = ViolationCodeItem(code="COP009", description="Function name must start with a verb")
+    ASYNC_GET_PREFIX = ViolationCodeItem(code="COP010", description="Avoid get_ prefix in async function names")
 
     # Variable usage violations
-    TEMP_VAR = ViolationCodeItem(code="COP007", description="Inline variables that are used only once")
+    TEMP_VAR = ViolationCodeItem(code="COP011", description="Inline variables that are used only once")
 
     # Class related violations
-    FINAL_CLASS = ViolationCodeItem(code="COP008", description="Classes must be marked final with @typing.final")
+    FINAL_CLASS = ViolationCodeItem(code="COP012", description="Classes must be marked final with @typing.final")
 
     # Module level violations
-    MAPPING_PROXY = ViolationCodeItem(code="COP009", description="Wrap module dictionaries with types.MappingProxyType")
+    MAPPING_PROXY = ViolationCodeItem(code="COP013", description="Wrap module dictionaries with types.MappingProxyType")
 
     # Dataclass violations
     DATACLASS_CONFIG = ViolationCodeItem(
-        code="COP010", description="Use dataclasses with kw_only=True, slots=True, frozen=True"
+        code="COP014", description="Use dataclasses with kw_only=True, slots=True, frozen=True"
     )