Skip to content

Commit 1cd3f63

Browse files
author
EGOROV Vadim
committed
fix tests
1 parent b249b69 commit 1cd3f63

3 files changed

Lines changed: 15 additions & 13 deletions

File tree

microbootstrap/bootstrappers/litestar.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def create_open_telemetry_middleware(self, app: ASGIApp) -> OpenTelemetryMiddlew
171171
)
172172

173173
async def handle(self, scope: Scope, receive: Receive, send: Send, next_app: ASGIApp) -> None:
174-
await self.create_open_telemetry_middleware(next_app)(scope, receive, send)
174+
await self.create_open_telemetry_middleware(next_app)(scope, receive, send) # type: ignore[arg-type]
175175

176176

177177
@LitestarBootstrapper.use_instrument()
@@ -182,7 +182,7 @@ def bootstrap_before(self) -> dict[str, typing.Any]:
182182
LitestarOpenTelemetryInstrumentationMiddleware(
183183
LitestarOpentelemetryConfig(
184184
tracer_provider=self.tracer_provider,
185-
middleware_class=LitestarOpenTelemetryInstrumentationMiddleware,
185+
middleware_class=LitestarOpenTelemetryInstrumentationMiddleware, # type: ignore[arg-type]
186186
)
187187
)
188188
]

tests/bootstrappers/test_litestar_opentelemetry.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ def test_litestar_opentelemetry_instrument_uses_custom_middleware(
115115
assert "middleware" in bootstrap_result
116116
assert len(bootstrap_result["middleware"]) == 1
117117

118-
middleware_config: typing.Final = bootstrap_result["middleware"][0]
119-
assert middleware_config.middleware == LitestarOpenTelemetryInstrumentationMiddleware
118+
middleware_config: typing.Final = bootstrap_result["middleware"][0].config
119+
assert middleware_config.middleware.middleware == LitestarOpenTelemetryInstrumentationMiddleware
120120

121121

122122
@pytest.mark.parametrize(
@@ -177,8 +177,8 @@ def test_litestar_opentelemetry_middleware_initialization() -> None:
177177
mock_config.server_request_hook_handler = None
178178
mock_config.tracer_provider = None
179179

180-
middleware: typing.Final = LitestarOpenTelemetryInstrumentationMiddleware(app=mock_app, config=mock_config)
180+
middleware: typing.Final = LitestarOpenTelemetryInstrumentationMiddleware(config=mock_config)
181181

182-
assert middleware.app == mock_app
183-
assert hasattr(middleware, "open_telemetry_middleware")
184-
assert middleware.open_telemetry_middleware is not None
182+
assert middleware.config == mock_config
183+
otel_middleware = middleware.create_open_telemetry_middleware(mock_app)
184+
assert otel_middleware is not None

tests/instruments/test_opentelemetry.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@
77
import litestar
88
import pytest
99
from fastapi.testclient import TestClient as FastAPITestClient
10-
from litestar.middleware.base import DefineMiddleware
1110
from litestar.testing import TestClient as LitestarTestClient
1211
from opentelemetry.instrumentation.dependencies import DependencyConflictError
1312

1413
from microbootstrap import OpentelemetryConfig
1514
from microbootstrap.bootstrappers.fastapi import FastApiOpentelemetryInstrument
16-
from microbootstrap.bootstrappers.litestar import LitestarOpentelemetryInstrument
15+
from microbootstrap.bootstrappers.litestar import (
16+
LitestarOpentelemetryInstrument,
17+
LitestarOpenTelemetryInstrumentationMiddleware,
18+
)
1719
from microbootstrap.instruments import opentelemetry_instrument
1820
from microbootstrap.instruments.opentelemetry_instrument import OpentelemetryInstrument
1921

@@ -61,7 +63,7 @@ def test_litestar_opentelemetry_bootstrap(
6163
assert "middleware" in opentelemetry_bootstrap_result
6264
assert isinstance(opentelemetry_bootstrap_result["middleware"], list)
6365
assert len(opentelemetry_bootstrap_result["middleware"]) == 1
64-
assert isinstance(opentelemetry_bootstrap_result["middleware"][0], DefineMiddleware)
66+
assert isinstance(opentelemetry_bootstrap_result["middleware"][0], LitestarOpenTelemetryInstrumentationMiddleware)
6567

6668

6769
def test_litestar_opentelemetry_teardown(
@@ -83,9 +85,9 @@ def test_litestar_opentelemetry_bootstrap_working(
8385
opentelemetry_bootstrap_result: typing.Final = test_opentelemetry_instrument.bootstrap_before()
8486

8587
opentelemetry_middleware = opentelemetry_bootstrap_result["middleware"][0]
86-
assert isinstance(opentelemetry_middleware, DefineMiddleware)
88+
assert isinstance(opentelemetry_middleware, LitestarOpenTelemetryInstrumentationMiddleware)
8789
async_mock.__name__ = "test-name"
88-
opentelemetry_middleware.middleware.__call__ = async_mock # type: ignore[operator]
90+
opentelemetry_middleware.handle = async_mock # type: ignore[method-assign]
8991

9092
@litestar.get("/test-handler")
9193
async def test_handler() -> None:

0 commit comments

Comments
 (0)