tmp

k-raina · k-raina · commit 196ea997d6d7 · 2026-01-06T20:33:44.000+05:30
diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml
@@ -194,6 +194,148 @@ blocks:
             - bash -c '../../ci/tests/run_perf_test.sh'
             - rm -rf ./node_modules
 
+  - name: "PR Artifacts: Linux amd64"
+    run:
+      when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
+    dependencies: [ ]
+    task:
+      agent:
+        machine:
+          type: s1-prod-ubuntu24-04-amd64-1
+      env_vars:
+        - name: ARCHITECTURE
+          value: "x64"
+        - name: PLATFORM
+          value: "linux"
+        - name: LIBC
+          value: "glibc"
+      prologue:
+        commands:
+          - '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
+      jobs:
+        - name: "Build PR Artifact"
+          matrix:
+            - env_var: NODE_VERSION_ABI
+              values:
+                - 20,115
+                - 22,127
+          commands:
+            - export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
+            - export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
+            - export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
+            - .semaphore/docker_run_with_volumes.sh node:${NODE_VERSION}-bullseye /v/.semaphore/build-docker-debian.sh
+            - export PKG_VERSION=$(node -p "require('./package.json').version")
+            - export ARTIFACT_PATTERN="*-node-v${NODE_ABI}-${PLATFORM}-${LIBC}-${ARCHITECTURE}.tar.gz"
+            - export BUILT_ARTIFACT=$(find build/stage/${PKG_VERSION} -name "${ARTIFACT_PATTERN}" -type f | head -1)
+            - if [ -z "$BUILT_ARTIFACT" ]; then echo "Error: Artifact not found"; exit 1; fi
+            - mkdir -p pr-artifacts/${PR_ID}
+            - cp "$BUILT_ARTIFACT" "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - artifact push workflow "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)" --destination "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - echo "Published artifact: pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+
+  - name: "PR Artifacts: Linux amd64 (musl)"
+    run:
+      when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
+    dependencies: [ ]
+    task:
+      agent:
+        machine:
+          type: s1-prod-ubuntu24-04-amd64-1
+      env_vars:
+        - name: ARCHITECTURE
+          value: "x64"
+        - name: PLATFORM
+          value: "linux"
+        - name: LIBC
+          value: "musl"
+      prologue:
+        commands:
+          - '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
+      jobs:
+        - name: "Build PR Artifact"
+          matrix:
+            - env_var: NODE_VERSION_ABI
+              values:
+                - 20,115
+                - 22,127
+          commands:
+            - export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
+            - export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
+            - export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
+            - .semaphore/docker_run_with_volumes.sh node:${NODE_VERSION}-alpine /v/.semaphore/build-docker-alpine.sh
+            - export PKG_VERSION=$(node -p "require('./package.json').version")
+            - export ARTIFACT_PATTERN="*-node-v${NODE_ABI}-linux-${LIBC}-${ARCHITECTURE}.tar.gz"
+            - export BUILT_ARTIFACT=$(find build/stage/${PKG_VERSION} -name "${ARTIFACT_PATTERN}" -type f | head -1)
+            - if [ -z "$BUILT_ARTIFACT" ]; then echo "Error: Artifact not found"; exit 1; fi
+            - mkdir -p pr-artifacts/${PR_ID}
+            - cp "$BUILT_ARTIFACT" "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - artifact push workflow "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)" --destination "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - echo "Published artifact: pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+
+  - name: "PR Artifacts: macOS arm64"
+    run:
+      when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
+    dependencies: []
+    task:
+      agent:
+        machine:
+          type: s1-macos-15-arm64-8
+      env_vars:
+        - name: ARCHITECTURE
+          value: "arm64"
+        - name: PLATFORM
+          value: "darwin"
+        - name: LIBC
+          value: "unknown"
+      jobs:
+        - name: "Build PR Artifact"
+          matrix:
+            - env_var: NODE_VERSION_ABI
+              values:
+                - 20,115
+                - 22,127
+          commands:
+            - export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
+            - export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
+            - sem-version node $NODE_VERSION
+            - export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
+            - npm ci
+            - npx node-pre-gyp package
+            - export PKG_VERSION=$(node -p "require('./package.json').version")
+            - export ARTIFACT_PATTERN="*-node-v${NODE_ABI}-${PLATFORM}-${LIBC}-${ARCHITECTURE}.tar.gz"
+            - export BUILT_ARTIFACT=$(find build/stage/${PKG_VERSION} -name "${ARTIFACT_PATTERN}" -type f | head -1)
+            - if [ -z "$BUILT_ARTIFACT" ]; then echo "Error: Artifact not found"; exit 1; fi
+            - mkdir -p pr-artifacts/${PR_ID}
+            - cp "$BUILT_ARTIFACT" "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - artifact push workflow "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)" --destination "pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+            - echo "Published artifact: pr-artifacts/${PR_ID}/$(basename $BUILT_ARTIFACT)"
+
+  - name: "PR Artifacts: Summary"
+    dependencies:
+      - "PR Artifacts: Linux amd64"
+      - "PR Artifacts: Linux amd64 (musl)"
+      - "PR Artifacts: macOS arm64"
+    run:
+      when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
+    task:
+      agent:
+        machine:
+          type: s1-prod-ubuntu24-04-amd64-1
+      jobs:
+        - name: "List PR Artifacts"
+          commands:
+            - export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
+            - artifact pull workflow pr-artifacts/${PR_ID}
+            - echo "=== PR Artifacts Available for Download ==="
+            - echo "PR ID: ${PR_ID}"
+            - echo "Branch: ${SEMAPHORE_GIT_BRANCH}"
+            - echo "Commit: ${SEMAPHORE_GIT_SHA}"
+            - echo ""
+            - echo "Available artifacts:"
+            - find pr-artifacts/${PR_ID} -name "*.tar.gz" -type f | while read f; do echo "  - $(basename $f)"; done || echo "  No artifacts found (may still be building)"
+            - echo ""
+            - echo "Download artifacts from Semaphore CI workflow artifacts section"
+
   - name: "Linux amd64: Release"
     dependencies: [ ]
     run:
diff --git a/lib/util.js b/lib/util.js
@@ -52,4 +52,4 @@ util.dictToStringList = function (mapOrObject) {
   return list;
 };
 
-util.bindingVersion = '1.8.0';
+util.bindingVersion = '1.8.0-test';
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@confluentinc/kafka-javascript",
-  "version": "1.8.0",
+  "version": "1.8.0-test",
   "description": "Node.js bindings for librdkafka",
   "librdkafka": "2.13.0",
   "librdkafka_win": "2.13.0",
diff --git a/src/common.cc b/src/common.cc
@@ -262,10 +262,26 @@ v8::Local<v8::Object> ToV8Object(const rd_kafka_Node_t* node) {
   */
   v8::Local<v8::Object> obj = Nan::New<v8::Object>();
 
+  // Check if node is NULL - can happen during broker restarts/metadata updates
+  if (!node) {
+    Nan::Set(obj, Nan::New("id").ToLocalChecked(), Nan::New<v8::Number>(-1));
+    Nan::Set(obj, Nan::New("host").ToLocalChecked(), Nan::Null());
+    Nan::Set(obj, Nan::New("port").ToLocalChecked(), Nan::New<v8::Number>(-1));
+    return obj;
+  }
+
   Nan::Set(obj, Nan::New("id").ToLocalChecked(),
            Nan::New<v8::Number>(rd_kafka_Node_id(node)));
-  Nan::Set(obj, Nan::New("host").ToLocalChecked(),
-           Nan::New<v8::String>(rd_kafka_Node_host(node)).ToLocalChecked());
+  
+  // Check host for NULL before using - prevents segfault when host is NULL
+  const char* host = rd_kafka_Node_host(node);
+  if (host) {
+    Nan::Set(obj, Nan::New("host").ToLocalChecked(),
+             Nan::New<v8::String>(host).ToLocalChecked());
+  } else {
+    Nan::Set(obj, Nan::New("host").ToLocalChecked(), Nan::Null());
+  }
+  
   Nan::Set(obj, Nan::New("port").ToLocalChecked(),
            Nan::New<v8::Number>(rd_kafka_Node_port(node)));
 
@@ -1496,15 +1512,25 @@ v8::Local<v8::Array> FromDescribeTopicsResult(
 
       const rd_kafka_Node_t* leader =
           rd_kafka_TopicPartitionInfo_leader(partition);
-      Nan::Set(partition_object, Nan::New("leader").ToLocalChecked(),
-               Conversion::Util::ToV8Object(leader));
+      // Check leader for NULL - can happen when partition has no leader
+      if (leader) {
+        Nan::Set(partition_object, Nan::New("leader").ToLocalChecked(),
+                 Conversion::Util::ToV8Object(leader));
+      } else {
+        Nan::Set(partition_object, Nan::New("leader").ToLocalChecked(), Nan::Null());
+      }
 
       size_t isr_cnt;
       const rd_kafka_Node_t** isr =
           rd_kafka_TopicPartitionInfo_isr(partition, &isr_cnt);
       v8::Local<v8::Array> isrArray = Nan::New<v8::Array>();
       for (size_t k = 0; k < isr_cnt; k++) {
-        Nan::Set(isrArray, k, Conversion::Util::ToV8Object(isr[k]));
+        // Check for NULL nodes in ISR array - can happen during broker restarts
+        if (isr[k]) {
+          Nan::Set(isrArray, k, Conversion::Util::ToV8Object(isr[k]));
+        } else {
+          Nan::Set(isrArray, k, Nan::Null());
+        }
       }
       Nan::Set(partition_object, Nan::New("isr").ToLocalChecked(), isrArray);
 
@@ -1513,7 +1539,12 @@ v8::Local<v8::Array> FromDescribeTopicsResult(
           rd_kafka_TopicPartitionInfo_replicas(partition, &replicas_cnt);
       v8::Local<v8::Array> replicasArray = Nan::New<v8::Array>();
       for (size_t k = 0; k < replicas_cnt; k++) {
-        Nan::Set(replicasArray, k, Conversion::Util::ToV8Object(replicas[k]));
+        // Check for NULL nodes in replicas array - can happen during broker restarts
+        if (replicas[k]) {
+          Nan::Set(replicasArray, k, Conversion::Util::ToV8Object(replicas[k]));
+        } else {
+          Nan::Set(replicasArray, k, Nan::Null());
+        }
       }
       Nan::Set(partition_object, Nan::New("replicas").ToLocalChecked(),
                replicasArray);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@confluentinc/kafka-javascript",`
`3`		`- "version": "1.8.0",`
	`3`	`+ "version": "1.8.0-test",`
`4`	`4`	`"description": "Node.js bindings for librdkafka",`
`5`	`5`	`"librdkafka": "2.13.0",`
`6`	`6`	`"librdkafka_win": "2.13.0",`