Skip to content

Commit 65ac679

Browse files
committed
fix(graphile-settings): use truthy check for isReferencee in _meta plugin
PostGraphile sets isReferencee only when true (reverse FK); forward relations have isReferencee undefined, not false. The !== false check was skipping all belongsTo relations.
1 parent de8ad0a commit 65ac679

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

graphile/graphile-settings/src/plugins/meta-schema/constraint-meta-builders.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export function buildForeignKeyConstraints(
9494
const constraints: ForeignKeyConstraintMeta[] = [];
9595

9696
for (const [relationName, relation] of Object.entries(relations)) {
97-
if (relation.isReferencee !== false) continue;
97+
if (relation.isReferencee) continue;
9898

9999
const remoteCodec = relation.remoteResource?.codec;
100100
const remoteAttributes = remoteCodec?.attributes || {};

graphile/graphile-settings/src/plugins/meta-schema/relation-meta-builders.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ export function buildBelongsToRelations(
3636
const belongsTo: BelongsToRelation[] = [];
3737

3838
for (const [relationName, relation] of Object.entries(relations)) {
39-
if (relation.isReferencee !== false) continue;
39+
// PostGraphile only sets isReferencee when true (reverse FK);
40+
// forward relations have isReferencee undefined, not false.
41+
if (relation.isReferencee) continue;
4042

4143
const localAttributes = relation.localAttributes || [];
4244
const isUnique = uniques.some((unique) =>

graphile/graphile-settings/src/plugins/meta-schema/table-meta-builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function buildTableMeta(
5050
}
5151
}
5252
for (const relation of Object.values(relations)) {
53-
if (relation.isReferencee !== false) continue;
53+
if (relation.isReferencee) continue;
5454
for (const attrName of relation.localAttributes || []) fkAttrNames.add(attrName);
5555
}
5656

0 commit comments

Comments
 (0)