refactor(pgsql-test): store opts in PgTestClient to avoid type casting

- Store opts as class property in PgTestClient
- Make PgTestClientOpts extend Partial<PgTestConnectionOptions>
- Refactor auth() to use this.opts instead of this.config as any
- Refactor clearContext() to use this.opts instead of casting config
- Update manager.ts to accept and pass through opts parameter
- Remove all 'as any' type casts from authentication code

Co-Authored-By: Dan Lynch <pyramation@gmail.com>

Author: pyramation

packages/pgsql-test/src/connect.ts

@@ -105,11 +105,13 @@ export const getConnections = async (
   const dbConfig = {
     ...config,
     user: connOpts.connection.user,
-    password: connOpts.connection.password,
-    auth: connOpts.auth
+    password: connOpts.connection.password
   } as PgConfig;
 
-  const db = manager.getClient(dbConfig);
+  const db = manager.getClient(dbConfig, {
+    auth: connOpts.auth,
+    roles: connOpts.roles
+  });
   db.setContext({ role: getDefaultRole(connOpts) });
 
   return { pg, db, teardown, manager, admin };

packages/pgsql-test/src/manager.ts

@@ -84,11 +84,14 @@ export class PgTestConnector {
     return this.pgPools.get(key)!;
   }
 
-  getClient(config: PgConfig): PgTestClient {
+  getClient(config: PgConfig, opts: any = {}): PgTestClient {
     if (this.shuttingDown) {
       throw new Error('PgTestConnector is shutting down; no new clients allowed');
     }
-    const client = new PgTestClient(config, { trackConnect: (p) => this.registerConnect(p) });
+    const client = new PgTestClient(config, { 
+      trackConnect: (p) => this.registerConnect(p),
+      ...opts
+    });
     this.clients.add(client);
 
     const key = this.dbKey(config);

packages/pgsql-test/src/test-client.ts

@@ -1,23 +1,24 @@
 import { Client, QueryResult } from 'pg';
 import { PgConfig } from 'pg-env';
-import { AuthOptions } from '@launchql/types';
+import { AuthOptions, PgTestConnectionOptions } from '@launchql/types';
 import { getRoleName } from './roles';
 
 type PgTestClientOpts = {
   deferConnect?: boolean;
   trackConnect?: (p: Promise<any>) => void;
-  auth?: AuthOptions;
-};
+} & Partial<PgTestConnectionOptions>;
 
 export class PgTestClient {
   public config: PgConfig;
   public client: Client;
+  private opts: PgTestClientOpts;
   private ctxStmts: string = '';
   private contextSettings: Record<string, string | null> = {};
   private _ended: boolean = false;
   private connectPromise: Promise<void> | null = null;
 
   constructor(config: PgConfig, opts: PgTestClientOpts = {}) {
+    this.opts = opts;
     this.config = config;
     this.client = new Client({
       host: this.config.host,
@@ -91,15 +92,15 @@ export class PgTestClient {
 
   /**
    * Set authentication context for the current session.
-   * Configures role and user ID using cascading defaults from options → config.auth → RoleMapping.
+   * Configures role and user ID using cascading defaults from options → opts.auth → RoleMapping.
    */
   async auth(options: AuthOptions = {}): Promise<void> {
     const role =
-      options.role ?? (this.config as any).auth?.role ?? getRoleName('authenticated', (this.config as any).roles);
+      options.role ?? this.opts.auth?.role ?? getRoleName('authenticated', this.opts);
     const userIdKey =
-      options.userIdKey ?? (this.config as any).auth?.userIdKey ?? 'jwt.claims.user_id';
+      options.userIdKey ?? this.opts.auth?.userIdKey ?? 'jwt.claims.user_id';
     const userId =
-      options.userId ?? (this.config as any).auth?.userId ?? null;
+      options.userId ?? this.opts.auth?.userId ?? null;
 
     this.setContext({
       role,
@@ -122,7 +123,7 @@ export class PgTestClient {
    * Clear all session context variables and reset to default anonymous role.
    */
   clearContext(): void {
-    const defaultRole = getRoleName('anonymous', (this.config as any).roles);
+    const defaultRole = getRoleName('anonymous', this.opts);
 
     const nulledSettings: Record<string, string | null> = {};
     Object.keys(this.contextSettings).forEach(key => {