-
Notifications
You must be signed in to change notification settings - Fork 8
Expand file tree
/
Copy pathoauthHandler-test.js
More file actions
472 lines (391 loc) · 16.3 KB
/
oauthHandler-test.js
File metadata and controls
472 lines (391 loc) · 16.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
import { expect } from 'chai'
import sinon from 'sinon'
import axios from 'axios'
import OAuthHandler from '../../lib/core/oauthHandler'
import { describe, it, beforeEach, afterEach } from 'mocha'
describe('OAuthHandler', () => {
let axiosInstance
let oauthHandler
let sandbox
beforeEach(() => {
sandbox = sinon.createSandbox()
axiosInstance = axios.create({
uiBaseUrl: 'https://example.com', // Make sure this is correctly set
developerHubBaseUrl: 'https://developer.example.com',
baseURL: 'https://api.example.com'
})
oauthHandler = new OAuthHandler(axiosInstance, 'appId', 'clientId', 'http://localhost:8184', 'clientSecret')
})
afterEach(() => {
sandbox.restore()
})
it('should initialize OAuthHandler with correct properties', () => {
expect(oauthHandler.appId).to.equal('appId')
expect(oauthHandler.clientId).to.equal('clientId')
expect(oauthHandler.redirectUri).to.equal('http://localhost:8184')
expect(oauthHandler.responseType).to.equal('code')
expect(oauthHandler.scope).to.equal('')
expect(oauthHandler.clientSecret).to.equal('clientSecret')
expect(oauthHandler.OAuthBaseURL).to.equal('https://example.com')
expect(oauthHandler.axiosInstance).to.equal(axiosInstance)
})
it('should generate code verifier', () => {
const codeVerifier = oauthHandler.generateCodeVerifier()
expect(codeVerifier).to.have.lengthOf(128)
})
it('should generate code challenge', async () => {
const codeVerifier = 'testCodeVerifier'
const codeChallenge = await oauthHandler.generateCodeChallenge(codeVerifier)
// eslint-disable-next-line no-unused-expressions
expect(codeChallenge).to.exist
})
it('should authorize and return authorization URL', async () => {
const authUrl = await oauthHandler.authorize()
expect(authUrl).to.include('https://example.com/')
expect(authUrl).to.include('response_type=code')
expect(authUrl).to.include('client_id=clientId')
})
it('should exchange code for token', async () => {
const tokenData = { access_token: 'accessToken', refresh_token: 'refreshToken', expires_in: 3600 }
sandbox.stub(axiosInstance, 'post').resolves({ data: tokenData })
const result = await oauthHandler.exchangeCodeForToken('authorization_code')
expect(result).to.deep.equal(tokenData)
})
it('should refresh access token', async () => {
// NAT = 'newAccessToken'
const tokenData = { access_token: 'NAT', refresh_token: 'newRefreshToken', expires_in: 3600 }
sandbox.stub(axiosInstance, 'post').resolves({ data: tokenData })
const result = await oauthHandler.refreshAccessToken('refreshToken')
expect(result).to.deep.equal(tokenData)
})
it('should logout successfully', async () => {
sandbox.stub(oauthHandler, 'getOauthAppAuthorization').resolves('authorizationId')
sandbox.stub(oauthHandler, 'revokeOauthAppAuthorization').resolves({})
const result = await oauthHandler.logout()
expect(result).to.equal('Logged out successfully')
})
it('should handle redirect and exchange code for token', async () => {
const exchangeStub = sandbox.stub(oauthHandler, 'exchangeCodeForToken').resolves({})
await oauthHandler.handleRedirect('http://localhost:8184?code=authorization_code')
// eslint-disable-next-line no-unused-expressions
expect(exchangeStub.calledWith('authorization_code')).to.be.true
})
it('should get access token', () => {
oauthHandler.axiosInstance.oauth = { accessToken: 'accessToken' }
const accessToken = oauthHandler.getAccessToken()
expect(accessToken).to.equal('accessToken')
})
it('should get refresh token', () => {
oauthHandler.axiosInstance.oauth = { refreshToken: 'refreshToken' }
const refreshToken = oauthHandler.getRefreshToken()
expect(refreshToken).to.equal('refreshToken')
})
it('should get organization UID', () => {
oauthHandler.axiosInstance.oauth = { organizationUID: 'organizationUID' }
const organizationUID = oauthHandler.getOrganizationUID()
expect(organizationUID).to.equal('organizationUID')
})
it('should get user UID', () => {
oauthHandler.axiosInstance.oauth = { userUID: 'userUID' }
const userUID = oauthHandler.getUserUID()
expect(userUID).to.equal('userUID')
})
it('should get token expiry time', () => {
oauthHandler.axiosInstance.oauth = { tokenExpiryTime: 1234567890 }
const tokenExpiryTime = oauthHandler.getTokenExpiryTime()
expect(tokenExpiryTime).to.equal(1234567890)
})
it('should set access token', () => {
oauthHandler.setAccessToken('newAccessToken')
expect(oauthHandler.axiosInstance.oauth.accessToken).to.equal('newAccessToken')
})
it('should set refresh token', () => {
oauthHandler.setRefreshToken('newRefreshToken')
expect(oauthHandler.axiosInstance.oauth.refreshToken).to.equal('newRefreshToken')
})
it('should set organization UID', () => {
oauthHandler.setOrganizationUID('newOrganizationUID')
expect(oauthHandler.axiosInstance.oauth.organizationUID).to.equal('newOrganizationUID')
})
it('should set user UID', () => {
oauthHandler.setUserUID('newUserUID')
expect(oauthHandler.axiosInstance.oauth.userUID).to.equal('newUserUID')
})
it('should set token expiry time', () => {
oauthHandler.setTokenExpiryTime(1234567890)
expect(oauthHandler.axiosInstance.oauth.tokenExpiryTime).to.equal(1234567890)
})
it('should generate codeVerifier and set codeChallenge to null if clientSecret is not provided', () => {
const oauthHandlerWithoutClientSecret = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null // No clientSecret
)
// Ensure codeVerifier is generated
// eslint-disable-next-line no-unused-expressions
expect(oauthHandlerWithoutClientSecret.codeVerifier).to.exist
// Ensure codeChallenge is null initially
expect(oauthHandlerWithoutClientSecret.codeChallenge).to.equal(null)
})
it('should not generate codeVerifier or codeChallenge if clientSecret is provided', () => {
const oauthHandlerWithClientSecret = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
'clientSecret' // clientSecret is provided
)
// codeVerifier and codeChallenge should not be set if clientSecret is provided
expect(oauthHandlerWithClientSecret.codeVerifier).to.equal(undefined)
expect(oauthHandlerWithClientSecret.codeChallenge).to.equal(undefined)
})
it('should generate codeChallenge after calling generateCodeChallenge when clientSecret is not provided', async () => {
const oauthHandlerWithoutClientSecret = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null // No clientSecret
)
const codeVerifier = oauthHandlerWithoutClientSecret.codeVerifier
// eslint-disable-next-line no-unused-expressions
expect(codeVerifier).to.exist // Ensure codeVerifier is generated
const codeChallenge = await oauthHandlerWithoutClientSecret.generateCodeChallenge(codeVerifier)
// Ensure the codeChallenge is a URL-safe Base64 string
expect(codeChallenge).to.match(/^[A-Za-z0-9-_]+$/) // URL-safe Base64
})
it('should use the Web Crypto API in a browser environment', async () => {
// Mock the browser environment
global.window = {
crypto: {
subtle: {
digest: sinon.stub().resolves(new Uint8Array([1, 2, 3, 4])) // Mock hash result
}
}
}
const oauthHandlerWithoutClientSecret = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null // No clientSecret
)
const codeVerifier = oauthHandlerWithoutClientSecret.codeVerifier
// eslint-disable-next-line no-unused-expressions
expect(codeVerifier).to.exist // Ensure codeVerifier is generated
const codeChallenge = await oauthHandlerWithoutClientSecret.generateCodeChallenge(codeVerifier)
// Ensure the codeChallenge is a URL-safe Base64 string
expect(codeChallenge).to.match(/^[A-Za-z0-9-_]+$/) // URL-safe Base64
// Clean up after the test to avoid affecting other tests
delete global.window
})
it('should generate authorization URL with code_challenge when clientSecret is not provided', async () => {
// Mock OAuthHandler without clientSecret
oauthHandler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null // No clientSecret (PKCE)
)
// Stub the generateCodeChallenge to return a dummy value
const codeChallenge = 'dummyCodeChallenge'
sandbox.stub(oauthHandler, 'generateCodeChallenge').resolves(codeChallenge)
const authUrl = await oauthHandler.authorize()
// Check that code_challenge and code_challenge_method are included in the URL
expect(authUrl).to.include('https://example.com/')
expect(authUrl).to.include('response_type=code')
expect(authUrl).to.include('client_id=clientId')
expect(authUrl).to.include('code_challenge=dummyCodeChallenge')
expect(authUrl).to.include('code_challenge_method=S256')
})
// Test cases for getOauthAppAuthorization
describe('getOauthAppAuthorization', () => {
it('should return authorization_uid when authorizations exist for the current user', async () => {
const mockResponse = {
data: {
data: [
{
user: { uid: 'currentUserUid' },
authorization_uid: 'authorizationUid1'
}
]
}
}
sandbox.stub(axiosInstance, 'get').resolves(mockResponse)
oauthHandler.axiosInstance.oauth.userUID = 'currentUserUid'
const authorizationUid = await oauthHandler.getOauthAppAuthorization()
expect(authorizationUid).to.equal('authorizationUid1')
})
it('should throw an error when no authorizations found for the current user', async () => {
const mockResponse = {
data: {
data: [
{
user: { uid: 'otherUserUid' },
authorization_uid: 'authorizationUid2'
}
]
}
}
sandbox.stub(axiosInstance, 'get').resolves(mockResponse)
oauthHandler.axiosInstance.oauth.userUID = 'currentUserUid'
try {
await oauthHandler.getOauthAppAuthorization()
throw new Error('Expected error not thrown')
} catch (error) {
expect(error.message).to.equal('No authorizations found for the current user. Verify user permissions and try again.')
}
})
it('should throw an error when no authorizations found for the app', async () => {
const mockResponse = { data: { data: [] } }
sandbox.stub(axiosInstance, 'get').resolves(mockResponse)
try {
await oauthHandler.getOauthAppAuthorization()
throw new Error('Expected error not thrown')
} catch (error) {
expect(error.message).to.equal('No authorizations found for the app. Verify app configuration and try again.')
}
})
})
describe('revokeOauthAppAuthorization', () => {
it('should make a DELETE request to revoke authorization when valid authorizationId is provided', async () => {
const authorizationId = 'authorizationUid1'
const mockResponse = { data: { success: true } }
sandbox.stub(axiosInstance, 'delete').resolves(mockResponse)
const result = await oauthHandler.revokeOauthAppAuthorization(authorizationId)
// eslint-disable-next-line no-unused-expressions
expect(result.success).to.be.true
// eslint-disable-next-line no-unused-expressions
expect(axiosInstance.delete.calledOnce).to.be.true
})
it('should not make a DELETE request when authorizationId is invalid or empty', async () => {
const invalidAuthorizationId = ''
const deleteStub = sandbox.stub(axiosInstance, 'delete')
await oauthHandler.revokeOauthAppAuthorization(invalidAuthorizationId)
// eslint-disable-next-line no-unused-expressions
expect(deleteStub.called).to.be.false
})
})
describe('PKCE sessionStorage (browser)', () => {
let sessionStorageStub
beforeEach(() => {
sessionStorageStub = {
getItem: sandbox.stub(),
setItem: sandbox.stub(),
removeItem: sandbox.stub()
}
global.window = { sessionStorage: sessionStorageStub }
})
afterEach(() => {
delete global.window
})
it('should store code_verifier in sessionStorage when generated (browser)', () => {
sessionStorageStub.getItem.returns(null)
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
expect(handler.codeVerifier).to.be.a('string')
expect(handler.codeVerifier).to.have.lengthOf(128)
expect(sessionStorageStub.setItem.calledOnce).to.equal(true)
const [key, valueStr] = sessionStorageStub.setItem.firstCall.args
expect(key).to.include('contentstack_oauth_pkce')
expect(key).to.include('appId')
expect(key).to.include('clientId')
const value = JSON.parse(valueStr)
expect(value).to.have.property('codeVerifier', handler.codeVerifier)
expect(value).to.have.property('expiresAt')
expect(value.expiresAt).to.be.greaterThan(Date.now())
})
it('should retrieve code_verifier from sessionStorage in constructor when valid', () => {
const storedVerifier = 'stored_code_verifier_xyz'
const storedValue = JSON.stringify({
codeVerifier: storedVerifier,
expiresAt: Date.now() + 600000
})
sessionStorageStub.getItem.returns(storedValue)
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
expect(handler.codeVerifier).to.equal(storedVerifier)
expect(sessionStorageStub.setItem.called).to.equal(false)
})
it('should not use expired sessionStorage entry and should generate new code_verifier', () => {
const expiredValue = JSON.stringify({
codeVerifier: 'expired_verifier',
expiresAt: Date.now() - 1000
})
sessionStorageStub.getItem.returns(expiredValue)
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
expect(handler.codeVerifier).to.not.equal('expired_verifier')
expect(handler.codeVerifier).to.have.lengthOf(128)
expect(sessionStorageStub.setItem.calledOnce).to.equal(true)
})
it('should clear sessionStorage after successful token exchange', async () => {
sessionStorageStub.getItem.returns(null)
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
const tokenData = { access_token: 'accessToken', refresh_token: 'refreshToken', expires_in: 3600 }
sandbox.stub(axiosInstance, 'post').resolves({ data: tokenData })
await handler.exchangeCodeForToken('authorization_code')
expect(sessionStorageStub.removeItem.calledOnce).to.equal(true)
expect(sessionStorageStub.removeItem.firstCall.args[0]).to.include('contentstack_oauth_pkce')
})
it('should clear sessionStorage on token exchange error to prevent replay attacks', async () => {
sessionStorageStub.getItem.returns(null)
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
sandbox.stub(axiosInstance, 'post').rejects(new Error('invalid_code_verifier'))
try {
await handler.exchangeCodeForToken('authorization_code')
} catch {
// errorFormatter rethrows; we only care that removeItem was called
}
expect(sessionStorageStub.removeItem.calledOnce).to.equal(true)
})
})
describe('PKCE memory-only (Node / no sessionStorage)', () => {
it('should use memory-only code_verifier when window is not defined', () => {
const originalWindow = global.window
delete global.window
const handler = new OAuthHandler(
axiosInstance,
'appId',
'clientId',
'http://localhost:8184',
null
)
expect(handler.codeVerifier).to.be.a('string')
expect(handler.codeVerifier).to.have.lengthOf(128)
if (originalWindow !== undefined) {
global.window = originalWindow
}
})
})
})