feat(release): v0.5.0 - Project Pillar & Quality Overhaul (#84)

This release introduces the 'project summary', 'onboard', and 'issues close' commands. It refactors 'export-upstream' to 'library vendor', adds secure 'pass' integration for GitHub tokens, and includes a massive code quality pass resolving numerous linter violations.

Author: duizendstra

.golangci.yml

@@ -58,7 +58,7 @@ linters:
     # - godox             # TODOs
     # - goprintffuncname  # Printf-like naming
     # - tagliatelle       # JSON struct tags
-    - nolintlint
+    # - nolintlint
 
     # --- TESTING ---
     # - testifylint
@@ -75,6 +75,8 @@ linters:
     ireturn:
       allow:
         - error
+        - github.com/contextvibes/cli/internal/workitem.Provider
+        - github.com/contextvibes/cli/internal/exec.CommandExecutor
     depguard:
       rules:
         main:

.idx/contextvibes.nix

@@ -9,9 +9,9 @@ pkgs.stdenv.mkDerivation {
   # This modifies the fixed-output derivation created by fetchurl.
   src = (pkgs.fetchurl {
     # URL for the release asset.
-    url = "https://github.com/contextvibes/cli/releases/download/v0.4.1-rc3/contextvibes";
+    url = "https://github.com/contextvibes/cli/releases/download/v0.4.1/contextvibes";
     # SHA256 hash of the downloaded file.
-    sha256 = "sha256:1aa09c34c750056e78a69e84f6d7c38a0c6220e3dc46af460256f9a38978ff8a";
+    sha256 = "sha256:09db14ee2d8258aaedd66ac507c6045cb260efd6bc1acb3bbc22e59db70bdcd7";
   }).overrideAttrs (finalAttrs: previousAttrs: {
     # Enable structured attributes to allow passing complex sets.
     __structuredAttrs = true;

cmd/craft/kickoff/kickoff.go

@@ -18,7 +18,7 @@ var kickoffLongDescription string
 var KickoffCmd = &cobra.Command{
 	Use:   "kickoff",
 	Short: "Starts an AI-guided strategic project planning session.",
-	//nolint:revive // Unused args are expected in Cobra RunE.
+
 	RunE: func(cmd *cobra.Command, _ []string) error {
 		presenter := ui.NewPresenter(cmd.OutOrStdout(), cmd.ErrOrStderr())
 

cmd/factory/apply/apply.go

@@ -121,7 +121,6 @@ func handleJSONPlan(ctx context.Context, presenter *ui.Presenter, data []byte) e
 		switch step.Type {
 		case "file_modification":
 			for _, changeSet := range step.Changes {
-				//nolint:gosec // Reading file to modify is intended.
 				original, _ := os.ReadFile(changeSet.FilePath)
 				current := string(original)
 

cmd/factory/finish/finish.go

@@ -6,9 +6,6 @@ import (
 	"errors"
 	"fmt"
 
-	//nolint:revive // Blank import for side effects (though none obvious here, keeping for safety).
-	_ "os"
-
 	"github.com/contextvibes/cli/internal/cmddocs"
 	"github.com/contextvibes/cli/internal/git"
 	"github.com/contextvibes/cli/internal/globals"

cmd/factory/tidy/tidy.go

@@ -6,9 +6,6 @@ import (
 	"errors"
 	"fmt"
 
-	//nolint:revive // Blank import for side effects (though none obvious here, keeping for safety).
-	_ "os"
-
 	"github.com/contextvibes/cli/internal/cmddocs"
 	"github.com/contextvibes/cli/internal/git"
 	"github.com/contextvibes/cli/internal/globals"

cmd/feedback/feedback.go

@@ -25,7 +25,7 @@ var feedbackLongDescription string
 
 // newProviderForRepo creates a workitem.Provider for a specific owner/repo string.
 //
-//nolint:ireturn // Returning interface is intended for provider abstraction.
+
 func newProviderForRepo(
 	ctx context.Context,
 	logger *slog.Logger,

cmd/library/index/index.go

@@ -35,8 +35,6 @@ var (
 var ErrSkipDocument = errors.New("skip document")
 
 // DocumentMetadata represents the metadata extracted from a document.
-//
-//nolint:exhaustruct // Struct is populated from YAML/JSON.
 type DocumentMetadata struct {
 	ID                string   `json:"id"`
 	FileExtension     string   `json:"fileExtension"`
@@ -115,7 +113,6 @@ var IndexCmd = &cobra.Command{
 	},
 }
 
-//nolint:revive // Unused parameters kept for future logic.
 func processDirectory(
 	rootPath, baseDirName string,
 	_ map[string]bool,
@@ -174,7 +171,6 @@ func processDirectory(
 	return metadataList, nil
 }
 
-//nolint:revive // Unused parameters kept for future logic.
 func parseFrontMatterAndDerive(
 	filePath, rootPath, _ string,
 	fileInfo fs.FileInfo,
@@ -215,7 +211,6 @@ func parseFrontMatterAndDerive(
 	}
 
 	var fmData tempFrontMatter
-	//nolint:noinlineerr // Inline check is standard for unmarshal.
 	if err := yaml.Unmarshal([]byte(strings.Join(frontMatterLines, "\n")), &fmData); err != nil {
 		return nil, fmt.Errorf("failed to parse front matter: %w", err)
 	}

cmd/library/library.go

@@ -4,7 +4,8 @@ package library
 import (
 	"github.com/contextvibes/cli/cmd/library/index"
 	"github.com/contextvibes/cli/cmd/library/systemprompt"
-	"github.com/contextvibes/cli/cmd/library/thea" // Imported
+	"github.com/contextvibes/cli/cmd/library/thea"
+	"github.com/contextvibes/cli/cmd/library/vendor" // Added
 	"github.com/spf13/cobra"
 )
 
@@ -19,6 +20,7 @@ var LibraryCmd = &cobra.Command{
 //nolint:gochecknoinits // Cobra requires init() for command registration.
 func init() {
 	LibraryCmd.AddCommand(index.IndexCmd)
-	LibraryCmd.AddCommand(thea.TheaCmd) // Uncommented/Added
+	LibraryCmd.AddCommand(thea.TheaCmd)
 	LibraryCmd.AddCommand(systemprompt.SystemPromptCmd)
+	LibraryCmd.AddCommand(vendor.VendorCmd) // Added
 }

cmd/library/systemprompt/systemprompt.go

@@ -35,7 +35,7 @@ var SystemPromptCmd = &cobra.Command{
 		loadedAppConfig := globals.LoadedAppConfig
 
 		basePath := "docs/prompts/system"
-		//nolint:gosec // Reading core prompt file is intended.
+
 		content, err := os.ReadFile(filepath.Join(basePath, "core.md"))
 		if err != nil {
 			//nolint:wrapcheck // Wrapping is handled by caller.