Add precommit & ruff linter/formatter & fix initial set of errors (#45)

* Add pre-commit config with Ruff linter/formatter

* Apply Ruff autofixes

* Remove unused variable

* Switch to explicit import

* Switch lambda for def

* Set Ruff to show fixes

* fetchez.spatial imports

To fix from fetchez.spatial import * we have to explicitly import everything from fetchez.spatial...

* Update spatial.py

---------

Co-authored-by: Matthew Love <33066727+matth-love@users.noreply.github.com>

Author: mfisher87

.pre-commit-config.yaml

@@ -0,0 +1,27 @@
+ci:
+  autoupdate_schedule: quarterly
+  autofix_prs: false
+
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v6.0.0
+    hooks:
+      - id: forbid-new-submodules
+      - id: end-of-file-fixer
+      - id: check-case-conflict
+      - id: requirements-txt-fixer
+      - id: check-added-large-files
+        args: ['--maxkb=500']
+      - id: check-json
+      - id: check-toml
+      - id: check-yaml
+      - id: debug-statements
+      - id: check-builtin-literals
+      - id: trailing-whitespace
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.15.2
+    hooks:
+      - id: ruff-check
+        args: ['--fix', '--show-fixes']
+      - id: ruff-format

AUTHORS.md

@@ -7,4 +7,4 @@
 * Elliot Lim (@e1im)
 * Christopher Amante (@camante)
 * Michael McFerrin (@mmacferrin)
-* Matt Fisher (@mfisher87)
+* Matt Fisher (@mfisher87)

CITATION.cff

@@ -16,4 +16,4 @@ website: https://transformez.readthedocs.io
 title: "Transformez"
 version: 0.3.6
 date-released: 2026-04-08
-url: "https://github.com/continuous-dems/transformez"
+url: "https://github.com/continuous-dems/transformez"

LICENSE

@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.

README.md

@@ -22,7 +22,7 @@ Originally developed as the core transformation engine for the [CUDEM](https://g
 
 ### ❓ Why Transformez?
 
-Vertical Datum transformations can cause a lot of confusion and headache when trying to process heterogeneous data from around the world into a single unified vertial reference. 
+Vertical Datum transformations can cause a lot of confusion and headache when trying to process heterogeneous data from around the world into a single unified vertial reference.
 
 **Transformez simplifies this process!**
 

src/transformez/cli.py

@@ -329,17 +329,30 @@ def install_vdatum():
 @vdatum_group.command("run")
 @click.argument("input_file", type=click.Path(exists=True))
 @click.argument("output_file", type=click.Path())
-@click.option("-I", "--in-datum", required=True, help="VDatum input datum string (e.g., 'navd88')")
-@click.option("-O", "--out-datum", required=True, help="VDatum output datum string (e.g., 'nad83_2011')")
+@click.option(
+    "-I", "--in-datum", required=True, help="VDatum input datum string (e.g., 'navd88')"
+)
+@click.option(
+    "-O",
+    "--out-datum",
+    required=True,
+    help="VDatum output datum string (e.g., 'nad83_2011')",
+)
 @click.option("--in-unit", default="m", help="Input units (m, ft, us-ft)")
 @click.option("--out-unit", default="m", help="Output units (m, ft, us-ft)")
 @click.option("--region", default="4", help="VDatum region grid")
-def run_vdatum_cli(input_file, output_file, in_datum, out_datum, in_unit, out_unit, region):
+def run_vdatum_cli(
+    input_file, output_file, in_datum, out_datum, in_unit, out_unit, region
+):
     """Process an XYZ text file through the local VDatum Java engine."""
 
     from transformez.vdatum import Vdatum
 
-    vd = Vdatum(ivert=f"{in_datum}:{in_unit}:height", overt=f"{out_datum}:{out_unit}:height", region=region).run_vdatum(input_file)
+    Vdatum(
+        ivert=f"{in_datum}:{in_unit}:height",
+        overt=f"{out_datum}:{out_unit}:height",
+        region=region,
+    ).run_vdatum(input_file)
 
 
 @vdatum_group.command("list")
@@ -351,5 +364,6 @@ def vdatum_list():
     vd = Vdatum().vdatum_help()
     click.echo(vd)
 
+
 if __name__ == "__main__":
     transformez_cli()

src/transformez/spatial.py

@@ -17,13 +17,55 @@
 
 import numpy as np
 from fetchez.utils import str_or
-from fetchez.spatial import *
+from fetchez.spatial import (
+    Region,
+    parse_region,
+    region_from_geojson,
+    region_from_place,
+    fix_argparse_region,
+    region_valid_p,
+    region_center,
+    region_to_shapely,
+    region_to_wkt,
+    _extract_coords,
+    region_to_bbox,
+    region_to_geojson_geom,
+    region_from_list,
+    region_from_string,
+    chunk_region,
+    buffer_region,
+)
 from . import srs
 
 import pyproj
 
 logger = logging.getLogger(__name__)
 
+__all__ = [
+    # Transformez
+    "TransRegion",
+    "parse_region",
+    "x360",
+    "transform_increment",
+    # Fetchez
+    "Region",
+    "parse_region",
+    "region_from_geojson",
+    "region_from_place",
+    "fix_argparse_region",
+    "region_valid_p",
+    "region_center",
+    "region_to_shapely",
+    "region_to_wkt",
+    "_extract_coords",
+    "region_to_bbox",
+    "region_to_geojson_geom",
+    "region_from_list",
+    "region_from_string",
+    "chunk_region",
+    "buffer_region",
+]
+
 
 class TransRegion(Region):
     # gtl is (geo-transform, xcount, ycount)

src/transformez/transform.py

@@ -195,7 +195,6 @@ def fetch_grid_(self, module_name, **kwargs):
         return valid
 
     def _get_grid(self, provider, name):
-        import re
 
         if not name:
             return np.zeros((self.ny, self.nx))
@@ -207,15 +206,16 @@ def _get_grid(self, provider, name):
             name = name.split("=")[1]
 
         files = self.fetch_grid(provider, datatype=name, query=name)
-        if provider == 'vdatum':
+        if provider == "vdatum":
             import rasterio
+
             def get_bbox_area(filepath):
                 try:
                     with rasterio.open(filepath) as src:
                         b = src.bounds
                         return (b.right - b.left) * (b.top - b.bottom)
                 except Exception:
-                    return float('inf')
+                    return float("inf")
 
             # Largest (Offshore) loads first, Smallest (Rivers) load last and overwrite
             files.sort(key=get_bbox_area, reverse=True)

src/transformez/utils.py

@@ -18,10 +18,13 @@
 import rasterio
 
 logger = logging.getLogger(__name__)
-cmd_exists = lambda x: any(
-    os.access(os.path.join(path, x), os.X_OK)
-    for path in os.environ["PATH"].split(os.pathsep)
-)
+
+
+def cmd_exists(x: str) -> bool:
+    return any(
+        os.access(os.path.join(path, x), os.X_OK)
+        for path in os.environ["PATH"].split(os.pathsep)
+    )
 
 
 def run_cmd(args):

src/transformez/vdatum.py

@@ -81,7 +81,7 @@ def vdatum_get_version(self):
         if self.jar is None:
             self.vdatum_locate_jar()
         if self.jar is not None:
-            out, _ = utils.run_cmd(f"java -jar {self.jar} -")#, verbose=self.verbose)
+            out, _ = utils.run_cmd(f"java -jar {self.jar} -")  # , verbose=self.verbose)
             for i in out.decode("utf-8").split("\n"):
                 if "- v" in i.strip():
                     return i.strip().split("v")[-1]
@@ -108,7 +108,7 @@ def vdatum_xyz(self, xyz):
             )
 
             out, _ = utils.run_cmd(
-                f"java -Djava.awt.headless=false -jar {self.jar} {vdc}"#, verbose=False
+                f"java -Djava.awt.headless=false -jar {self.jar} {vdc}"  # , verbose=False
             )
             z = xyz[2]
             for i in out.split("\n"):
@@ -143,7 +143,9 @@ def run_vdatum(self, src_fn):
                 f"-nodata -file:txt:{self.delim},{self.xyzl},skip{self.skip}:{src_fn}:{self.result_dir} "
                 f"{epoch_str}region:{self.region}"
             )
-            return utils.run_cmd(f"java -jar {self.jar} {vdc}")#, verbose=self.verbose)
+            return utils.run_cmd(
+                f"java -jar {self.jar} {vdc}"
+            )  # , verbose=self.verbose)
         else:
             return [], -1