Failing to Publish to PyPi

[matth-love]

After recent security changes in #44 , Publish to PyPi now fails with:

https://github.com/continuous-dems/transformez/actions/runs/24350674525

"Publish to PyPI

Unable to download artifact(s): Artifact not found for name: dist

Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact."

It seems to me that the 'publish' action is completing before the 'build' action completes, resulting in the Artifact not found.

@mfisher87 does this seem to be the issue here?

[matth-love]

Seems like we need to add needs: build in the publish job so that it waits for build to finish...Looks like previously we had a single job that combined build->publish so that they ran sequentially, but now they're in 2 distinct jobs that run concurrently...

https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-jobs

I'll give this a try.

[matth-love]

That did it. Closing. #50

[mfisher87]

Nice catch Matt, sorry about that ❤️

[matth-love]

No Problem! I learned a lot about the github workflows debugging that :D

[matth-love]

And what's interesting is this error didn't show up in fetchez because we wait for a review/approval to publish after the build there...

[mfisher87]

And what's interesting is this error didn't show up in fetchez because we wait for a review/approval to publish after the build there...

Not sure I follow? I was sure my PR set up this repo almost exactly like fetchez 🤔

[matth-love]

On fetchez, we have the Deployment protection rule set that requires a review before publishing to pypi. We don't have that set here on transformez; so when the build and publish ran concurrently, the publish finished (and failed) before the build could finish. While on fetchez the build finishes in time (even though we don't set the needs: build) because the publish job has to wait for someone to review before running. At least that's how i'm understanding it.

[mfisher87]

oh cool! I didn't know you'd turned that on. Nice thinking :)