Skip to content

Commit 69d46a9

Browse files
committed
vine: print warning if task larger than available disk - cache of all workers (#4385)
1 parent 5375c59 commit 69d46a9

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

taskvine/src/manager/vine_schedule.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,6 +507,9 @@ static vine_resource_bitmask_t is_task_larger_than_worker(struct vine_manager *q
507507

508508
if ((double)w->resources->disk.total < l->disk) {
509509
set = set | DISK_BIT;
510+
} else if ((double)w->resources->disk.total - w->resources.disk.inuse && hash_table_size(w->current_tasks) < 1) {
511+
/* also trigger disk if worker's cache does not allow to run any task anymore */
512+
set = set | DISK_BIT;
510513
}
511514

512515
if ((double)w->resources->gpus.total < l->gpus) {
@@ -603,7 +606,7 @@ void vine_schedule_check_for_large_tasks(struct vine_manager *q)
603606
}
604607

605608
if (unfit_disk) {
606-
notice(D_VINE, " %d waiting task(s) need more than %s of disk", unfit_disk, rmsummary_resource_to_str("disk", largest_unfit_task->disk, 1));
609+
notice(D_VINE, " %d waiting task(s) need more than %s of disk (workers' disk cache may be full)", unfit_disk, rmsummary_resource_to_str("disk", largest_unfit_task->disk, 1));
607610
}
608611

609612
if (unfit_gpu) {

0 commit comments

Comments
 (0)