MB-65427 Ignore expired passwords in is_cluster_initialized

is_cluster_initialized will no longer return an error when the
user password has expired.

Change-Id: I5431384400983090514e082137e985ae0074648c
Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/224471
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Matt Hall <matt.hall@couchbase.com>

Author: lubomarinski

cluster_manager.py

@@ -29,6 +29,7 @@
 BACKUP_SERVICE = 'backup'
 
 ERR_AUTH = 'unable to access the REST API - please check your username (-u) and password (-p)'
+ERR_PASSWORD_EXPIRED = 'unable to access the REST API - Password expired'
 ERR_INTERNAL = 'Internal server error, please retry your request'
 
 DEFAULT_REQUEST_TIMEOUT = 60
@@ -39,6 +40,10 @@
     VERSION = '0.0.0-0000'
 
 
+def unexpected_403_err(message):
+    return f"Unexpected response for error 403: {message}"
+
+
 def one_zero_boolean_to_string(value: str) -> str:
     """Helper function to convert arguments with 1/0 string values to true or false"""
     return 'true' if value == '1' else 'false'
@@ -252,7 +257,7 @@ def n1ql_query(self, stmt, args=None):
 
     def is_cluster_initialized(self):
         data, errors = self.pools()
-        if (errors and len(errors) == 1 and errors[0] == ERR_AUTH) or \
+        if (errors and len(errors) == 1 and errors[0] in [ERR_AUTH, ERR_PASSWORD_EXPIRED]) or \
                 (data and data['pools'] and len(data['pools']) > 0):
             return True, None
         return False, errors
@@ -2991,7 +2996,9 @@ def _handle_response(self, response):
                     return None, [errors['message'] + ": " + ", ".join(errors["permissions"])]
                 elif 'runtime_info' in errors and 'info' in errors['runtime_info']:
                     return None, [errors['runtime_info']['info']]
-            return None, [f"Unexpected response for error 403: {response.text}"]
+                elif 'passwordExpired' in errors and errors['passwordExpired']:
+                    return None, [ERR_PASSWORD_EXPIRED]
+            return None, [unexpected_403_err(response.text)]
         # Error codes from Eventing service
         elif response.status_code in [406, 422, 423]:
             errors = response.json()

test/mock_server.py

@@ -256,6 +256,9 @@ def _close(self, url, server, t):
 
 
 def get_pools(rest_params=None, server_args=None, path="", endpoint_match=None):
+    if "override-pools" in server_args:
+        return server_args["override-pools"]
+
     is_admin = True
     enterprise = True
     version = '0.0.0-0000-enterprise'

test/test_cluster_manager.py

@@ -14,9 +14,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import json
 import unittest
+import unittest.mock
 
-from cluster_manager import ClusterManager
+from mock_server import MockRESTServer
+
+from cluster_manager import ERR_AUTH, ERR_PASSWORD_EXPIRED, ClusterManager, unexpected_403_err
 
 
 class ClusterManagerTest(unittest.TestCase):
@@ -209,3 +213,39 @@ def test_get_otp_names_of_matched_nodes(self):
                                                                                        test['nodes_to_match'])
                 self.assertEqual(errors, test['errors'])
                 self.assertEqual(matched_nodes, test['matched_nodes'])
+
+    def test_is_cluster_initialized(self):
+        tests = {
+            "ErrAuthIgnored": {
+                "pools_res": (None, [ERR_AUTH]),
+                "server_status": 401,
+                "server_res": {},
+                "expected_res": (True, None)
+            },
+            "ErrPasswordExpiredIgnored": {
+                "pools_res": (None, [ERR_PASSWORD_EXPIRED]),
+                "server_status": 403,
+                "server_res": {"message": "Password expired", "passwordExpired": True},
+                "expected_res": (True, None)
+            },
+            "PropagateOtherErrors": {
+                "pools_res": (None, ["Unknown error"]),
+                "server_status": 403,
+                "server_res": {"message": "Unknown error"},
+                "expected_res": (False, [unexpected_403_err(json.dumps({"message": "Unknown error"}))])
+            }
+        }
+
+        for name, test in tests.items():
+            with self.subTest(name=name):
+                server = MockRESTServer('127.0.0.1', 6789)
+                server.args['override-pools'] = (test["server_status"], test["server_res"])
+
+                server.run()
+
+                cluster_manager = ClusterManager("http://127.0.0.1:6789", "Administrator", "asdasd")
+                res = cluster_manager.is_cluster_initialized()
+
+                server.shutdown()
+
+                self.assertEqual(res, test["expected_res"])