Skip to content

Commit 24a007a

Browse files
committed
MB-65342 Fix typo in encryption at-rest
nodeSecretsManager -> nodeSecretManager Change-Id: If3d0b63ff11d371edaed2ae7982654a68b177513 Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/224264 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Safian Ali <safian.ali@couchbase.com>
1 parent 817b7ea commit 24a007a

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

cluster_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,7 @@ def set_encryption_settings(self, target, typ, key, dek_rotation_interval, dek_l
10161016
if typ == 'key':
10171017
method = 'encryptionKey'
10181018
elif typ == 'master-password':
1019-
method = 'nodeSecretsManager'
1019+
method = 'nodeSecretManager'
10201020

10211021
params = {'encryptionMethod': method}
10221022
if key is not None:

test/test_cli.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1363,6 +1363,14 @@ def test_set_encryption(self):
13631363
f'log.dekRotationInterval={30*24*60*60}', f'log.dekLifetime={60*24*60*60}']
13641364
self.rest_parameter_match(expected_params)
13651365

1366+
def test_set_encryption_master_password(self):
1367+
args = ['--set', '--type', 'master-password', '--target', 'log', '--dek-rotate-every', '30',
1368+
'--dek-lifetime', '60']
1369+
self.no_error_run(self.command + args, self.server_args)
1370+
expected_params = ['log.encryptionMethod=nodeSecretManager',
1371+
f'log.dekRotationInterval={30*24*60*60}', f'log.dekLifetime={60*24*60*60}']
1372+
self.rest_parameter_match(expected_params)
1373+
13661374
def test_add_edit_key_no_name(self):
13671375
self.server.set_args(self.server_args)
13681376
self.server.run()

0 commit comments

Comments
 (0)