MB-60837 Add new alerts to setting-alert

Change-Id: Iff036f0c2f42f39b8bc2c5d3b04369c297aa588d
Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/207017
Well-Formed: Restriction Checker
Reviewed-by: Safian Ali <safian.ali@couchbase.com>
Tested-by: Matt Hall <matt.hall@couchbase.com>

Author: matthallcb

cbmgr.py

@@ -2336,6 +2336,10 @@ def __init__(self):
                            action="store_true", help="Alert when system memory usage exceeds threshold")
         group.add_argument("--alert-bucket-history-size", dest="alert_bucket_history_size",
                            action="store_true", help="Alert when history size for a bucket reaches 90%%")
+        group.add_argument("--alert-indexer-low-resident-percentage", dest="alert_indexer_low_resident_percentage",
+                           action="store_true", help="Alert when approaching indexer low resident percentage")
+        group.add_argument("--alert-memcached-connections", dest="alert_memcached_connections",
+                           action="store_true", help="Alert when the memcached connection threshold is exceeded")
 
     @rest_initialiser(cluster_init_check=True, version_check=True)
     def execute(self, opts):
@@ -2386,6 +2390,10 @@ def execute(self, opts):
             alerts.append('memory_threshold')
         if opts.alert_bucket_history_size:
             alerts.append('history_size_warning')
+        if opts.alert_indexer_low_resident_percentage:
+            alerts.append('indexer_low_resident_percentage')
+        if opts.alert_memcached_connections:
+            alerts.append('memcached_connections')
 
         enabled = "true"
         if opts.enabled == "0":

docs/modules/cli/pages/cbcli/couchbase-cli-setting-alert.adoc

@@ -25,6 +25,7 @@ _couchbase-cli setting-alert_ [--cluster <url>] [--username <user>] [--password
     [--alert-audit-msg-dropped] [--alert-indexer-max-ram]
     [--alert-timestamp-drift-exceeded] [--alert-node-time] [--alert-disk-analyzer]
     [--alert-memory-threshold] [--alert-bucket-history-size]
+    [--alert-indexer-low-resident-percentage] [--alert-memcached-connections]
 
 == DESCRIPTION
 
@@ -146,6 +147,14 @@ include::{partialsdir}/cbcli/part-common-options.adoc[]
   Specifies that an email alert should be sent when the size of history for a
   bucket reaches 90% of the maximum history size.
 
+--alert-indexer-low-resident-percentage::
+  Specifies that an email alert should be sent when approaching the indexer low
+  resident percentage.
+
+--alert-memcached-connections::
+  Specifies that an email alert should be sent when the memcached connection
+  threshold is exceeded.
+
 include::{partialsdir}/cbcli/part-host-formats.adoc[]
 
 include::{partialsdir}/cbcli/part-certificate-authentication.adoc[]

test/test_cli.py

@@ -1113,7 +1113,8 @@ def setUp(self):
                             '--alert-meta-overhead', '--alert-meta-oom', '--alert-write-failed',
                             '--alert-audit-msg-dropped', '--alert-indexer-max-ram', '--alert-timestamp-drift-exceeded',
                             '--alert-communication-issue', '--alert-node-time', '--alert-disk-analyzer',
-                            '--alert-bucket-history-size']
+                            '--alert-bucket-history-size', '--alert-indexer-low-resident-percentage',
+                            '--alert-memcached-connections']
         self.server_args = {'enterprise': True, 'init': True, 'is_admin': True}
         super(TestSettingAlert, self).setUp()