MB-66986 [BP] Remove init check on setting-enterprise-analytics

This is so users can configure the analytics settings before calling
`cluster-init`.

Change-Id: I6a6a636c336c71b7843294b1aa22f91c72139ad1
Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/228731
Reviewed-by: Lubo Marinski <lubo.marinski@couchbase.com>
Reviewed-by: Safian Ali <safian.ali@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/230173

Author: matthallcb

cbmgr.py

@@ -3498,7 +3498,8 @@ def __init__(self):
         group.add_argument("--anonymous-auth", dest="blob_storage_anonymous_auth", metavar="<0|1>",
                            choices=["0", "1"], help="Allow BLOB storage anonymous auth")
 
-    @rest_initialiser(cluster_init_check=True, version_check=True)
+    # We disable the cluster init check so people can use '--set' before the cluster is initiaslised. See MB-66986.
+    @rest_initialiser(cluster_init_check=False, version_check=True)
     def execute(self, opts):
         if opts.set:
             if not (opts.num_storage_partitions or opts.blob_storage_scheme or opts.blob_storage_bucket

test/test_cli.py

@@ -5366,6 +5366,17 @@ def test_all_flags(self):
                                    'blobStoragePrefix=aaa', 'blobStorageRegion=aaa', 'blobStorageEndpoint=aaa',
                                    'blobStorageAnonymousAuth=true'])
 
+    def test_all_flags_uninitialised(self):
+        server_args = self.server_args
+        server_args['init'] = False
+        self.no_error_run(self.command + ['--set', '--partitions', '7', '--scheme', 's3', '--bucket', 'aaa',
+                                          '--prefix', 'aaa', '--region', 'aaa', '--endpoint', 'aaa',
+                                          '--anonymous-auth', '1',], server_args)
+        self.assertIn('POST:/settings/analytics', self.server.trace)
+        self.rest_parameter_match(['numStoragePartitions=7', 'blobStorageScheme=s3', 'blobStorageBucket=aaa',
+                                   'blobStoragePrefix=aaa', 'blobStorageRegion=aaa', 'blobStorageEndpoint=aaa',
+                                   'blobStorageAnonymousAuth=true'])
+
 
 if __name__ == '__main__':
     unittest.main()