MB-66604 Add --enable-cross-cluster-versioning to bucket-edit

Change-Id: I6a6a636c91a94eaabbe7dbd15b1c59545b06cf5a
Reviewed-on: https://review.couchbase.org/c/couchbase-cli/+/227957
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Safian Ali <safian.ali@couchbase.com>

Author: matthallcb

cbmgr.py

@@ -1429,6 +1429,9 @@ def __init__(self):
             type=(int),
             help="The number of seconds of acceptable drift at which new CAS values will be accepted")
 
+        group.add_argument("--enable-cross-cluster-versioning", dest="xcluster_versioning", action='store_true')
+        group.add_argument("--force", dest="force", action='store_true')
+
     @rest_initialiser(cluster_init_check=True, version_check=True, enterprise_check=False)
     def execute(self, opts):
         if opts.max_ttl and not self.enterprise:
@@ -1520,6 +1523,10 @@ def execute(self, opts):
         if opts.dek_lifetime:
             dek_lifetime = opts.dek_lifetime * 24 * 60 * 60
 
+        if opts.xcluster_versioning and not opts.force:
+            if not prompt_for_confirmation('Cross-cluster versioning cannot be turned off.'):
+                return
+
         _, errors = self.rest.edit_bucket(opts.bucket_name, opts.memory_quota, opts.durability_min_level,
                                           opts.eviction_policy, opts.replica_count, priority, opts.enable_flush,
                                           opts.max_ttl, opts.compression_mode, opts.remove_port, opts.db_frag_perc,
@@ -1529,7 +1536,7 @@ def execute(self, opts):
                                           opts.history_retention_bytes, opts.history_retention_seconds,
                                           opts.enable_history_retention, opts.rank, opts.encryption_key,
                                           dek_rotate_interval, dek_lifetime, is_couchbase_bucket, opts.invalid_hlc_strategy,
-                                          opts.hlc_max_future_threshold)
+                                          opts.hlc_max_future_threshold, opts.xcluster_versioning)
         _exit_if_errors(errors)
 
         _success("Bucket edited")

cluster_manager.py

@@ -1257,7 +1257,7 @@ def edit_bucket(self, name, memory_quota, durability_min_level, eviction_policy,
                     abort_outside, paralleldb_and_view_compact, purge_interval,
                     history_retention_bytes, history_retention_seconds, history_retention_default,
                     rank, encryption_key, dek_rotation_interval, dek_lifetime, couchbase_bucket: bool = True,
-                    invalid_hlc_strategy=None, hlc_max_future_threshold=None):
+                    invalid_hlc_strategy=None, hlc_max_future_threshold=None, xcluster_versioning: bool = False):
         url = f'{self.hostname}/pools/default/buckets/{name}'
 
         if name is None:
@@ -1331,6 +1331,9 @@ def edit_bucket(self, name, memory_quota, durability_min_level, eviction_policy,
         if hlc_max_future_threshold is not None:
             params["hlcMaxFutureThreshold"] = hlc_max_future_threshold
 
+        if xcluster_versioning:
+            params["enableCrossClusterVersioning"] = "true"
+
         return self._post_form_encoded(url, params)
 
     def delete_bucket(self, name):

docs/modules/cli/pages/cbcli/couchbase-cli-bucket-edit.adoc

@@ -31,6 +31,7 @@ _couchbase-cli bucket-edit_ [--cluster <url>] [--username <user>]
     [--enable-history-retention-by-default <0|1>] [--rank <num>]
     [--encryption-key <key>] [--dek-rotate-every <days>] [--dek-lifetime <days>]
     [--invalid-hlc-strategy <error|ignore|replace>] [--hlc-max-future-threshold <seconds>]
+    [--enable-cross-cluster-versioning]
 
 == DESCRIPTION
 
@@ -212,20 +213,26 @@ Run index and data compaction in parallel. Global setting only.
   rank "0". The default rank for a bucket is 0.
 
 --encryption-key <key>::
-The key that should be used to encrypt the bucket.
+  The key that should be used to encrypt the bucket.
 
 --dek-rotate-every <days>::
-The number of days after which the DEK (Data Encryption Key) should be rotated.
+  The number of days after which the DEK (Data Encryption Key) should be rotated.
 
 --dek-lifetime <days>::
-The number of days which the DEK (Data Encryption Key) should be kept for.
+  The number of days which the DEK (Data Encryption Key) should be kept for.
 
 --invalid-hlc-strategy <error|ignore|replace>::
   Sets the invalid HLC strategy, used to handle invalid CAS values.
   (Can be error, ignore or replace)
 
 --hlc-max-future-threshold <seconds>::
-The number of seconds of acceptable drift at which new CAS values will be accepted.
+  The number of seconds of acceptable drift at which new CAS values will be accepted.
+
+--enable-cross-cluster-versioning::
+  Turn on cross-cluster versioning for this bucket. This setting cannot be turned off.
+
+--force::
+  Skip any prompts asking you whether to continue.
 
 include::{partialsdir}/cbcli/part-common-history-retention.adoc[]
 

test/test_cli.py

@@ -866,6 +866,18 @@ def test_bucket_edit_hlc_threshold_invalid(self):
         self.assertIn("--hlc-max-future-threshold cannot be lower than 10",
                       self.str_output)
 
+    def test_bucket_edit_cross_cluster_versioning(self):
+        self.server_args['buckets'].append(self.bucket_membase)
+        self.no_error_run(self.command + self.command_args + self.command_couch_args + self.command_EE_args +
+                          ['--enable-cross-cluster-versioning', '--force'],
+                          self.server_args)
+        expected_params = [
+            'evictionPolicy=fullEviction', 'flushEnabled=1', 'threadsNumber=8', 'replicaNumber=0', 'maxTTL=20',
+            'compressionMode=active', 'ramQuotaMB=100', 'rank=3', 'enableCrossClusterVersioning=true',
+        ]
+
+        self.rest_parameter_match(expected_params)
+
 
 class TestBucketFlush(CommandTest):
     def setUp(self):