Skip to content

Commit 5cf092a

Browse files
author
Hideki Itakura
committed
Added comments for LiveQuery.
1 parent 9566e5c commit 5cf092a

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

src/main/java/com/couchbase/lite/LiveQuery.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@ public void stop() {
128128

129129
/**
130130
* Blocks until the intial async query finishes. After this call either .rows or .error will be non-nil.
131+
*
132+
* TODO: It seems that implementation of waitForRows() is not correct. Should fix this!!!
133+
* https://github.com/couchbase/couchbase-lite-java-core/issues/647
131134
*/
132135
@InterfaceAudience.Public
133136
public void waitForRows() throws CouchbaseLiteException {
@@ -264,6 +267,8 @@ public void completed(QueryEnumerator rowsParam, Throwable error) {
264267
setRows(rowsParam);
265268
for (ChangeListener observer : observers) {
266269
Log.d(Log.TAG_QUERY, "%s: update() calling back observer with rows", LiveQuery.this);
270+
// TODO: LiveQuery.ChangeListener should not be fired for non-match?
271+
// https://github.com/couchbase/couchbase-lite-java-core/issues/648
267272
observer.changed(new ChangeEvent(LiveQuery.this, rows));
268273
}
269274
}

0 commit comments

Comments
 (0)