Merge pull request #1172 from couchbase/feature/issue_1171

Fixed #1171 - Unnecessary Log.e() in java-core

Author: Hideki Itakura

src/main/java/com/couchbase/lite/replicator/PullerInternal.java

@@ -672,7 +672,7 @@ null, db, new RemoteRequestCompletionBlock() {
                     @Override
                     public void onCompletion(HttpResponse httpResponse, Object result, Throwable e) {
                         if (e != null) {
-                            Log.e(TAG, "Error pulling remote revision", e);
+                            Log.w(TAG, "Error pulling remote revision: %s", e, this);
                             if (Utils.isDocumentError(e)) {
                                 // Revision is missing or not accessible:
                                 revisionFailed(rev, e);
@@ -862,7 +862,7 @@ private void processChangeTrackerStopped(ChangeTracker tracker) {
                     // otherwise, try to restart the change tracker, since it should
                     // always be running in continuous replications
                     String msg = "Change tracker stopped during continuous replication";
-                    Log.e(TAG, msg);
+                    Log.w(TAG, msg);
                     parentReplication.setLastError(new Exception(msg));
                     fireTrigger(ReplicationTrigger.WAITING_FOR_CHANGES);
                     Log.d(TAG, "Scheduling change tracker restart in %d ms", CHANGE_TRACKER_RESTART_DELAY_MS);

src/main/java/com/couchbase/lite/replicator/Replication.java

@@ -426,7 +426,6 @@ public void run(Database database) {
         }
 
         synchronized (changeListeners) {
-            Log.e(Log.TAG_SYNC, "changed(ChangeEvent) count=%d event=%s", changeListeners.size(), event);
             for (ChangeListener changeListener : changeListeners) {
                 try {
                     changeListener.changed(event);

src/main/java/com/couchbase/lite/replicator/ReplicationInternal.java

@@ -1103,7 +1103,6 @@ protected void stop() {
      * Notify all change listeners of a ChangeEvent
      */
     private void notifyChangeListeners(final Replication.ChangeEvent changeEvent) {
-        Log.e(TAG, "notifyChangeListeners() %s", changeEvent);
         if (changeListenerNotifyStyle == ChangeListenerNotifyStyle.SYNC) {
             synchronized (changeListeners) {
                 for (ChangeListener changeListener : changeListeners) {
@@ -1128,7 +1127,7 @@ public void run() {
                                     }
                                 }
                             } catch (Exception e) {
-                                Log.e(Log.TAG_SYNC, "Exception notifying replication listener: %s", e);
+                                Log.e(Log.TAG_SYNC, "Exception notifying replication listener: %s", e, this);
                                 throw new RuntimeException(e);
                             }
                         }

src/main/java/com/couchbase/lite/support/Batcher.java

@@ -158,7 +158,7 @@ public void queueObjects(List<T> objects) {
      *                           deadlock.
      */
     public void flushAll(boolean waitForAllToFinish) {
-        Log.e(Log.TAG_BATCHER, "%s: flushing all objects (wait=%b)", this, waitForAllToFinish);
+        Log.v(Log.TAG_BATCHER, "%s: flushing all objects (wait=%b)", this, waitForAllToFinish);
 
         synchronized (mutex) {
             isFlushing = true;