Merge pull request #603 from couchbase/feature/issue_602_colon_is_illegal_for_windows

Fixed #602 Make / db names work in windows

Author: pasin

src/main/java/com/couchbase/lite/Manager.java

@@ -10,7 +10,6 @@
 import com.couchbase.lite.support.Version;
 import com.couchbase.lite.util.Log;
 import com.couchbase.lite.util.StreamUtils;
-
 import com.couchbase.lite.util.Utils;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
@@ -421,7 +420,14 @@ private String pathForName(String name) {
         if ((name == null) || (name.length() == 0) || Pattern.matches(LEGAL_CHARACTERS, name)) {
             return null;
         }
-        name = name.replace('/', ':');
+        // NOTE: CouchDB allows forward slash as part of database name.
+        //       However, ':' is illegal character on Windows platform.
+        //       For Windows, substitute with period '.'
+        if(isWindows()) {
+            name = name.replace('/', '.');
+        }else{
+            name = name.replace('/', ':');
+        }
         String result = directoryFile.getPath() + File.separator + name + Manager.DATABASE_SUFFIX;
         return result;
     }
@@ -672,5 +678,15 @@ public Context getContext() {
     protected boolean isAutoMigrateBlobStoreFilename() {
         return this.options.isAutoMigrateBlobStoreFilename();
     }
+
+    private static String OS = System.getProperty("os.name").toLowerCase();
+
+    /**
+     * Check if platform is Windows
+     */
+    @InterfaceAudience.Private
+    private static boolean isWindows() {
+        return (OS.indexOf("win") >= 0);
+    }
 }