Commit 9b9164f
committed
PYCBC-1711: Don't set bucketType, replicaIndex, flushEnabled when creating bucket unless set by user
Motivation
==========
We should only set bucket settings that the user has explicitly set. In this case, the SDK defaults are aligned with the server defaults, so removing them does not change default behavior.
Changes
=======
Don't set bucketType, replicaIndex, flushEnabled in create/update bucket requests unless the user has set them.
Results
=======
* All tests pass.
* FIT tests (BucketManagerTest) now only fail due to the presence of replicaNumber which is tracked by PYCBC-1712.
Change-Id: I16fb71542215290f8b55151710522ee2433b8a83
Reviewed-on: https://review.couchbase.org/c/couchbase-python-client/+/234247
Reviewed-by: Jared Casey <jared.casey@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>1 parent 5319285 commit 9b9164f
1 file changed
Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | | - | |
351 | | - | |
| 350 | + | |
352 | 351 | | |
353 | 352 | | |
354 | 353 | | |
| |||
358 | 357 | | |
359 | 358 | | |
360 | 359 | | |
361 | | - | |
362 | | - | |
| 360 | + | |
363 | 361 | | |
364 | 362 | | |
365 | 363 | | |
366 | 364 | | |
367 | | - | |
368 | | - | |
| 365 | + | |
369 | 366 | | |
370 | 367 | | |
371 | 368 | | |
| |||
419 | 416 | | |
420 | 417 | | |
421 | 418 | | |
422 | | - | |
| 419 | + | |
423 | 420 | | |
424 | 421 | | |
425 | 422 | | |
| |||
475 | 472 | | |
476 | 473 | | |
477 | 474 | | |
478 | | - | |
| 475 | + | |
479 | 476 | | |
480 | 477 | | |
481 | 478 | | |
| |||
0 commit comments