MB-70908 Remove the limit on the number of...

... keyspaces that can be included in the
natural_context request parameter.

Change-Id: I6b3c5f36e5451736be96412cae1c2df6a7df9a4a
Reviewed-on: https://review.couchbase.org/c/query/+/241575
Tested-by: Gaurav J <gaurav.jayaraj@couchbase.com>
Well-Formed: Restriction Checker
Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>

Author: GauravJayaraj

errors/codes.go

@@ -630,7 +630,7 @@ const (
 	E_NL_TOO_MANY_WAITERS                        ErrorCode = 19220
 	E_NL_TIMEOUT                                 ErrorCode = 19221
 	E_NL_REQ_FEAT_DISABLED                       ErrorCode = 19222
-	E_NL_TOO_MANY_KEYSPACES                      ErrorCode = 19223
+	_RETIRED_19223                               ErrorCode = 19223
 	E_AUS_NOT_SUPPORTED                          ErrorCode = 20000
 	E_AUS_NOT_INITIALIZED                        ErrorCode = 20001
 	E_AUS_STORAGE                                ErrorCode = 20002

errors/messages.go

@@ -8011,22 +8011,6 @@ var errData = []ErrData{
 			"Server",
 		},
 	},
-	{
-		Code:        E_NL_TOO_MANY_KEYSPACES, // 19223
-		symbol:      "E_NL_TOO_MANY_KEYSPACES",
-		Description: "Too many keyspaces specified.",
-		IsUser:      YES,
-		Reason: []string{
-			"The \"natural_context\" parameter specifies more than the maximum permitted number of keyspaces.",
-			"The \"keyspaces\" option specifies more than the maximum permitted number of keyspaces.",
-		},
-		Action: []string{
-			"Revise the \"natural_context\" parameter or \"keyspaces\" option.",
-		},
-		AppliesTo: []string{
-			"Server",
-		},
-	},
 	{
 		Code:        E_AUS_NOT_SUPPORTED, // 20000
 		symbol:      "E_AUS_NOT_SUPPORTED",

errors/natural.go

@@ -47,7 +47,6 @@ var naturalErrMap = map[ErrorCode][2]string{
 	E_NL_TOO_MANY_WAITERS:           {RATE_LIMIT, "Too many waiters, dropping the request"},
 	E_NL_TIMEOUT:                    {RATE_LIMIT, "Timed out waiting to be processed."},
 	E_NL_REQ_FEAT_DISABLED:          {SERVE_NATURAL, "Natural language request processing is disabled."},
-	E_NL_TOO_MANY_KEYSPACES:         {NLCONTEXT_IKEY, "Too many keyspaces specified."},
 }
 
 func NewNaturalLanguageRequestError(code ErrorCode, args ...interface{}) Error {

server/server.go

@@ -807,9 +807,6 @@ func (this *Server) serviceNaturalRequest(request Request) (bool, bool) {
 	}
 
 	elems, err = algebra.ParseAndValidatePathList(request.NaturalContext(), "default", request.QueryContext())
-	if err == nil && len(elems) > natural.MAX_KEYSPACES {
-		err = errors.NewNaturalLanguageRequestError(errors.E_NL_TOO_MANY_KEYSPACES)
-	}
 	if err != nil {
 		request.Fail(errors.NewNaturalLanguageRequestError(errors.E_NL_CONTEXT, err))
 		request.Failed(this)

test/gsi/test_cases/natural/testcases.json

@@ -4,11 +4,6 @@
         "statements": "USING AI WITH {\"keyspaces\":\"a.c.c.d\"} Show few documents",
         "errorCode": 19215
     },
-    {
-        "testcase":"incorrect Natural context: too many keyspaces",
-        "statements": "USING AI WITH {\"keyspaces\":[\"k1\", \"k2\", \"k3\", \"k4\", \"k5\"]} Show few documents",
-        "errorCode":19215
-    },
     {
         "testcase":"prompt requesting for a sql statement",
         "statements":"USING AI WITH {\"keyspaces\":\"orders\"} documents with mana more than 200",