fix: review comments

Author: bradjin8

api/export_api.py

@@ -222,4 +222,4 @@ def export_chats():
             type(e).__name__,
             exc_info=True,
         )
-        return jsonify({"error": f"Export failed: {str(e)}"}), 500
+        return jsonify({"error": "Export failed"}), 500

api/pdf.py

@@ -176,7 +176,7 @@ def footer(self):
             type(e).__name__,
             exc_info=True,
         )
-        return jsonify({"error": f"Failed to generate PDF: {str(e)}"}), 500
+        return jsonify({"error": "Failed to generate PDF"}), 500
 
 
 def _render_code_block(pdf, code_text: str):

static/js/app.js

@@ -97,8 +97,8 @@ function normalizeWorkspacesResponse(body) {
   }
   if (body && typeof body === 'object') {
     return {
-      projects: body.projects || [],
-      warnings: body.warnings || [],
+      projects: Array.isArray(body.projects) ? body.projects : [],
+      warnings: Array.isArray(body.warnings) ? body.warnings : [],
     };
   }
   return { projects: [], warnings: [] };
@@ -117,10 +117,11 @@ function formatParseWarnings(warnings) {
  */
 function showIncompleteResultsBanner(containerId, warnings) {
   const container = document.getElementById(containerId);
-  if (!container || !warnings || !warnings.length) return;
+  if (!container) return;
 
   const existing = container.querySelector('.incomplete-results-banner');
   if (existing) existing.remove();
+  if (!Array.isArray(warnings) || !warnings.length) return;
 
   const text = formatParseWarnings(warnings);
   const banner = document.createElement('div');

tests/test_parse_failure_logging.py

@@ -61,8 +61,10 @@ def _seed_tabs_with_drifted_bubble(parent: str) -> str:
 
     ws_dir = os.path.join(ws_root, "ws-a")
     os.makedirs(ws_dir, exist_ok=True)
+    proj_dir = os.path.join(ws_dir, "proj")
+    os.makedirs(proj_dir, exist_ok=True)
     with open(os.path.join(ws_dir, "workspace.json"), "w", encoding="utf-8") as f:
-        json.dump({"folder": "/tmp/proj"}, f)
+        json.dump({"folder": f"file://{proj_dir}"}, f)
     sqlite3.connect(os.path.join(ws_dir, "state.vscdb")).close()
 
     conn = sqlite3.connect(os.path.join(global_root, "state.vscdb"))
@@ -126,9 +128,9 @@ def test_workspace_tabs_logs_bubble_json_decode_failure(self) -> None:
                 conn.commit()
             with self.assertLogs("services.workspace_tabs", level="WARNING") as cm:
                 with app.test_request_context("/api/workspaces/global/tabs"):
-                    payload, status = assemble_workspace_tabs("global", ws_root, rules=[])
+                    _payload, _status = assemble_workspace_tabs("global", ws_root, rules=[])
 
-        self.assertEqual(status, 200)
+        self.assertEqual(_status, 200)
         messages = [r.getMessage() for r in cm.records]
         self.assertTrue(
             any("decode Bubble" in m and "b-json" in m for m in messages),
@@ -156,9 +158,9 @@ def test_workspace_tabs_logs_composer_json_decode_failure(self) -> None:
                 conn.commit()
             with self.assertLogs("services.workspace_tabs", level="WARNING") as cm:
                 with app.test_request_context("/api/workspaces/global/tabs"):
-                    payload, status = assemble_workspace_tabs("global", ws_root, rules=[])
+                    _payload, _status = assemble_workspace_tabs("global", ws_root, rules=[])
 
-        self.assertEqual(status, 200)
+        self.assertEqual(_status, 200)
         messages = [r.getMessage() for r in cm.records]
         self.assertTrue(
             any("decode Composer" in m and "cmp-json" in m for m in messages),