Skip to content

Commit 064e9cb

Browse files
committed
fix: fix tests
1 parent b54e122 commit 064e9cb

1 file changed

Lines changed: 5 additions & 21 deletions

File tree

news/tests/test_views.py

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from datetime import date, timedelta
44
from io import BytesIO
55

6-
from PIL import Image
76
import pytest
87
from django.conf import settings
98
from django.contrib.messages import get_messages
@@ -365,33 +364,18 @@ def test_news_create_multiplexer(tp, user_type, request):
365364

366365

367366
@pytest.mark.parametrize(
368-
"has_image, has_display_name, should_redirect",
367+
"has_display_name, should_redirect",
369368
[
370-
(True, True, False), # Has image, display name
371-
(False, True, True), # Missing image
372-
(True, False, True), # Missing names
373-
(False, False, True), # Missing everything
369+
(True, False), # Has display name
370+
(False, True), # Missing names
374371
],
375372
)
376-
def test_news_create_requirements(
377-
tp, user, has_image, has_display_name, should_redirect
378-
):
379-
"""Users must have a profile photo and at least one of the names: first or last."""
373+
def test_news_create_requirements(tp, user, has_display_name, should_redirect):
374+
"""Users must have at least one of the names: first or last."""
380375
url_name = "news-create"
381376
url = tp.reverse(url_name)
382377

383378
# Setup user based on parameters
384-
if has_image:
385-
file = BytesIO()
386-
filename = "test_image.jpg"
387-
file.name = filename
388-
image = Image.new("RGB", size=(100, 100), color=(155, 0, 0))
389-
image.save(file, "jpeg")
390-
file.seek(0)
391-
user.profile_image.save(filename, file)
392-
else:
393-
user.profile_image = None
394-
395379
user.display_name = "Test User" if has_display_name else ""
396380
user.save()
397381

0 commit comments

Comments
 (0)