refactor: Move avatar logic to User model

Move _get_author_avatar from demo view to
User.get_avatar_url() with walrus operator.

Author: julioest

core/views.py

@@ -1071,23 +1071,6 @@ class V3ComponentDemoView(TemplateView):
 
     template_name = "base.html"
 
-    @staticmethod
-    def _get_author_avatar(author):
-        """Return the best available avatar URL for a library author (User).
-
-        Returns empty string when no image is available so the avatar
-        template falls back to a colored initials circle.
-        """
-        if not author:
-            return ""
-        url = author.get_thumbnail_url()
-        if url:
-            return url
-        ca = getattr(author, "commitauthor", None)
-        if ca and getattr(ca, "avatar_url", None):
-            return ca.avatar_url
-        return ""
-
     def get_context_data(self, **kwargs):
         from django.urls import reverse
         from libraries.models import Library, LibraryVersion
@@ -1836,7 +1819,7 @@ def get_context_data(self, **kwargs):
                     "author": {
                         "name": author.display_name if author else "Unknown",
                         "role": "Contributor",
-                        "avatar_url": self._get_author_avatar(author),
+                        "avatar_url": author.get_avatar_url() if author else "",
                         "badge_url": f"{badge_img}/badge-first-place.png",
                     },
                     "doc_url": reverse(

users/models.py

@@ -289,6 +289,22 @@ def get_thumbnail_url(self):
             with suppress(AttributeError, MissingSource):
                 return getattr(self.image_thumbnail, "url", None)
 
+    def get_avatar_url(self):
+        """Return the best available avatar URL.
+
+        Tries the profile image thumbnail first, then falls back to
+        the linked CommitAuthor avatar. Returns empty string when no
+        image is available so the avatar template falls back to a
+        colored initials circle.
+        """
+        if url := self.get_thumbnail_url():
+            return url
+        if (ca := getattr(self, "commitauthor", None)) and getattr(
+            ca, "avatar_url", None
+        ):
+            return ca.avatar_url
+        return ""
+
     def get_hq_image_url(self):
         # convenience method for templates
         if self.hq_image and self.hq_image_render: