STL: enable inconclusive warnings with --inconclusive

Author: danmar

lib/checkstl.cpp

@@ -237,6 +237,8 @@ void CheckStl::iterators()
         bool inconclusiveType=false;
         if (!isIterator(var, inconclusiveType))
             continue;
+        if (inconclusiveType && !mSettings->inconclusive)
+            continue;
 
         const unsigned int iteratorId = var->declarationId();
 

test/teststl.cpp

@@ -1837,7 +1837,7 @@ class TestStl : public TestFixture {
               "int foo() {\n"
               "    iterator i;\n"
               "    return i.foo();;\n"
-              "}");
+              "}", true);
         ASSERT_EQUALS("", errout.str());
 
         check("class iterator {\n"
@@ -1848,7 +1848,7 @@ class TestStl : public TestFixture {
               "int foo() {\n"
               "    iterator i;\n"
               "    return i.foo();;\n"
-              "}");
+              "}", true);
         ASSERT_EQUALS("[test.cpp:8]: (error, inconclusive) Invalid iterator 'i' used.\n", errout.str());
     }
 
@@ -1859,7 +1859,7 @@ class TestStl : public TestFixture {
               "        {\n"
               "        }\n"
               "    }\n"
-              "}");
+              "}", true);
         ASSERT_EQUALS("", errout.str());
     }
 
@@ -3172,7 +3172,7 @@ class TestStl : public TestFixture {
               "    iterator it; \n"
               "    it->m_place = 0;\n"
               "    return it; \n"
-              "}\n");
+              "}\n", true);
         ASSERT_EQUALS("[test.cpp:18]: (error, inconclusive) Invalid iterator 'it' used.\n", errout.str());
     }