|
| 1 | +# Suppress some CodeQL warnings. |
1 | 2 | query-filters: |
2 | 3 |
|
3 | | - # Suppress some LGTM warnings. |
4 | | - |
| 4 | + # A few occurrences of try/except clauses without naming a specific exception type. |
| 5 | + # TODO: May be improved. |
| 6 | + # https://codeql.github.com/codeql-query-help/python/py-empty-except/ |
5 | 7 | - exclude: |
6 | 8 | id: py/empty-except |
7 | 9 |
|
8 | 10 | # A module is imported with the "import" and "import from" statements. |
9 | | - # https://lgtm.com/rules/1818040193/ |
| 11 | + # CodeQL says "Importing a module twice using the import xxx and from xxx import yyy is confusing.". |
| 12 | + # While it has a point, it is still more than acceptable. |
| 13 | + # https://codeql.github.com/codeql-query-help/python/py-import-and-import-from/ |
10 | 14 | - exclude: |
11 | 15 | id: py/import-and-import-from |
12 | 16 |
|
| 17 | + # Quite a few functions don't explicitly return values, but |
| 18 | + # instead implicitly return `None`, when falling through. |
| 19 | + # TODO: May be improved. |
| 20 | + # https://codeql.github.com/codeql-query-help/python/py-mixed-returns/ |
13 | 21 | - exclude: |
14 | 22 | id: py/mixed-returns |
15 | 23 |
|
16 | | - # Disable rule to compensate parameter naming in `CrateCompiler._get_crud_params`. |
17 | | - # Using an alternative name for the first parameter of an instance method makes code more difficult to read. |
18 | | - # https://lgtm.com/rules/910082/ |
| 24 | + # The parameter naming in `CrateCompiler._get_crud_params` is so that it triggers this admonition. |
| 25 | + # However, by using an alternative name for the first parameter of an instance method, it would |
| 26 | + # make the code harder to read. |
| 27 | + # https://codeql.github.com/codeql-query-help/python/py-not-named-self/ |
19 | 28 | - exclude: |
20 | 29 | id: py/not-named-self |
21 | 30 |
|
| 31 | + # A few occurrences of unused local variables. |
| 32 | + # TODO: May be improved. |
| 33 | + # https://codeql.github.com/codeql-query-help/python/py-unused-local-variable/ |
22 | 34 | - exclude: |
23 | 35 | id: py/unused-local-variable |
0 commit comments