CI: Use environment variables CRATEDB_VERSION and SQLALCHEMY_VERSION

Instead of using GNU getopt in the `setup_ci.sh` program, the needed
information is propagated using environment variables.

Author: amotl

.github/workflows/nightly.yml

@@ -18,8 +18,11 @@ jobs:
         os: [ubuntu-latest]
         python-version: ['3.7', '3.8', '3.9', '3.10']
         cratedb-version: ['nightly']
-        sqla-version: ['1.3.24']
+        sqla-version: ['1.4.37']
       fail-fast: false
+    env:
+      CRATEDB_VERSION: ${{ matrix.cratedb-version }}
+      SQLALCHEMY_VERSION: ${{ matrix.sqla-version }}
 
     steps:
       - uses: actions/checkout@v3
@@ -28,13 +31,15 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Propagate matrix information
-        run: |
-          source bootstrap.sh
-          ./devtools/setup_ci.sh --cratedb-version=${{ matrix.cratedb-version }} --sqlalchemy-version=${{ matrix.sqla-version }}
-
       - name: Invoke tests
         run: |
+
+          # Bootstrap environment.
           source bootstrap.sh
+
+          # Propagate build matrix information.
+          ./devtools/setup_ci.sh
+
+          # Invoke validation tasks.
           flake8 src bin
           coverage run bin/test -vv1

.github/workflows/tests.yml

@@ -21,6 +21,9 @@ jobs:
         cratedb-version: ['4.8.0']
         sqla-version: ['1.3.24', '1.4.37']
       fail-fast: true
+    env:
+      CRATEDB_VERSION: ${{ matrix.cratedb-version }}
+      SQLALCHEMY_VERSION: ${{ matrix.sqla-version }}
 
     steps:
       - uses: actions/checkout@v3
@@ -29,22 +32,20 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Adjust environment for macOS
-        if: matrix.os == 'macos-latest'
+      - name: Invoke tests
         run: |
-          brew install gnu-getopt
-          echo "/usr/local/opt/gnu-getopt/bin" >> $GITHUB_PATH
 
-      - name: Propagate matrix information
-        run: |
+          # Bootstrap environment.
           source bootstrap.sh
-          ./devtools/setup_ci.sh --cratedb-version=${{ matrix.cratedb-version }} --sqlalchemy-version=${{ matrix.sqla-version }}
 
-      - name: Invoke tests
-        run: |
-          source bootstrap.sh
+          # Propagate build matrix information.
+          ./devtools/setup_ci.sh
+
+          # Invoke validation tasks.
           flake8 src bin
           coverage run bin/test -vv1
+
+          # Set the stage for the Codecov step.
           coverage xml
 
       # https://github.com/codecov/codecov-action

bootstrap.sh

@@ -16,6 +16,11 @@
 # Trace all invocations.
 # set -x
 
+# Default variables.
+BUILDOUT_VERSION=${BUILDOUT_VERSION:-2.13.7}
+CRATEDB_VERSION=${CRATEDB_VERSION:-4.8.1}
+SQLALCHEMY_VERSION=${SQLALCHEMY_VERSION:-1.4.37}
+
 
 function print_header() {
     printf '=%.0s' {1..42}; echo
@@ -50,8 +55,8 @@ function before_setup() {
     #
     pip install wheel
 
-    BUILDOUT_VERSION=${BUILDOUT_VERSION:-2.13.7}
-    pip install "zc.buildout==${BUILDOUT_VERSION}"
+    # Install Buildout with designated version, allowing pre-releases.
+    pip install --pre "zc.buildout==${BUILDOUT_VERSION}"
 
 }
 
@@ -70,7 +75,10 @@ function finalize() {
 
     # Some steps before dropping into the activated virtualenv.
     echo
-    python -c 'import sqlalchemy; print(f"SQLAlchemy version: {sqlalchemy.__version__}")'
+    echo "Sandbox environment ready"
+    echo -n "Using SQLAlchemy version: "
+    python -c 'import sqlalchemy; print(sqlalchemy.__version__)'
+    echo
 
 }
 
@@ -84,7 +92,7 @@ function main() {
 }
 
 function lint() {
-    flake8
+    flake8 "$@" src bin
 }
 
 main

devtools/setup_ci.sh

@@ -2,59 +2,31 @@
 
 set -e
 
-function args() {
-  options=$(getopt --long cratedb-version: --long sqlalchemy-version: -- "$@")
-  [ $? -eq 0 ] || {
-    echo "Incorrect options provided"
-    exit 1
-  }
-  eval set -- "$options"
-  while true; do
-      case "$1" in
-      --cratedb-version)
-          shift;
-          cratedb_version=$1
-          ;;
-      --sqlalchemy-version)
-          shift;
-          sqlalchemy_version=$1
-          ;;
-      --)
-          shift
-          break
-          ;;
-      esac
-      shift
-  done
-}
-
 function main() {
 
-  # Read command line arguments.
-  args $0 "$@"
-
   # Sanity checks.
-  [ -z ${cratedb_version} ] && {
+  [ -z ${CRATEDB_VERSION} ] && {
     echo "--cratedb-version must be given"
+    echo "Environment variable 'CRATEDB_VERSION' needed"
     exit 1
   }
-  [ -z ${sqlalchemy_version} ] && {
-    echo "--sqlalchemy-version must be given"
+  [ -z ${SQLALCHEMY_VERSION} ] && {
+    echo "Environment variable 'SQLALCHEMY_VERSION' needed"
     exit 1
   }
 
   # Let's go.
-  echo "Invoking tests with CrateDB ${cratedb_version} and SQLAlchemy ${sqlalchemy_version}"
+  echo "Invoking tests with CrateDB ${CRATEDB_VERSION} and SQLAlchemy ${SQLALCHEMY_VERSION}"
 
   # Install designated SQLAlchemy version.
-  pip install "sqlalchemy==${sqlalchemy_version}"
+  pip install "sqlalchemy==${SQLALCHEMY_VERSION}"
 
   # Replace CrateDB version.
-  if [ ${cratedb_version} = "nightly" ]; then
+  if [ ${CRATEDB_VERSION} = "nightly" ]; then
     sed -ir "s/releases/releases\/nightly/g" buildout.cfg
     sed -ir "s/crate_server.*/crate_server = latest/g" versions.cfg
   else
-    sed -ir "s/crate_server.*/crate_server = ${cratedb_version}/g" versions.cfg
+    sed -ir "s/crate_server.*/crate_server = ${CRATEDB_VERSION}/g" versions.cfg
   fi
 
 }