dropped support for Symfony 4.4, 6.3, 7.0, 7.1

Author: craue

.github/workflows/composer-lint.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         php:
-          - '8.2'
+          - '8.4'
 
     steps:
       - name: checkout

.github/workflows/static-analysis.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         php:
-          - '8.2'
+          - '8.4'
 
     steps:
       - name: checkout

.github/workflows/tests.yml

@@ -30,27 +30,15 @@ jobs:
           -
             php: '8.4'
             dependencies: highest
-          -
-            php: '7.3'
-            symfony: '4.4.*'
-          -
-            php: '7.4'
-            symfony: '5.4.*'
-          # TODO remove as soon as Symfony >= 5.0 is required
           -
             php: '7.4'
             symfony: '5.4.*'
-            note: contao-polyfill-symfony
-            contao-polyfill-symfony: true
           -
             php: '8.0'
             symfony: '5.4.*'
           -
             php: '8.1'
             symfony: '5.4.*'
-          -
-            php: '8.1'
-            symfony: '6.3.*'
           -
             php: '8.2'
             symfony: '6.4.*'
@@ -111,11 +99,6 @@ jobs:
         env:
           fail-fast: true # interrupt on extension setup error
 
-      # TODO remove as soon as Symfony >= 5.0 is required
-      - name: require contao/polyfill-symfony
-        if: matrix.contao-polyfill-symfony == true
-        run: composer require --no-update --dev contao/polyfill-symfony
-
       - name: use dev dependencies
         if: matrix.stability == 'dev'
         run: composer config minimum-stability dev

CraueFormFlowBundle.php

@@ -2,10 +2,7 @@
 
 namespace Craue\FormFlowBundle;
 
-use Craue\FormFlowBundle\DependencyInjection\Compiler\LegacySessionCompilerPass;
 use Craue\FormFlowBundle\Util\TempFileUtil;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
 /**
@@ -28,15 +25,4 @@ public function boot() {
 		});
 	}
 
-	/**
-	 * {@inheritDoc}
-	 */
-	public function build(ContainerBuilder $container) : void {
-		parent::build($container);
-
-		if (!\method_exists(RequestStack::class, 'getSession')) {
-			$container->addCompilerPass(new LegacySessionCompilerPass());
-		}
-	}
-
 }

DependencyInjection/Compiler/LegacySessionCompilerPass.php

@@ -2,8 +2,6 @@
 
 namespace Craue\FormFlowBundle\EventListener;
 
-use Craue\FormFlowBundle\Exception\InvalidTypeException;
-use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
 /**
@@ -16,23 +14,15 @@
 trait EventListenerWithTranslatorTrait {
 
 	/**
-	 * @var TranslatorInterface|LegacyTranslatorInterface
+	 * @var TranslatorInterface
 	 */
 	protected $translator;
 
 	/**
-	 * @param TranslatorInterface|LegacyTranslatorInterface $translator
-	 * @throws InvalidTypeException
+	 * @param TranslatorInterface $translator
 	 */
-	public function setTranslator($translator) {
-		// TODO revert to type-hint with only TranslatorInterface as soon as Symfony >= 5.0 is required
-		if ($translator instanceof TranslatorInterface || $translator instanceof LegacyTranslatorInterface) {
-			$this->translator = $translator;
-
-			return;
-		}
-
-		throw new InvalidTypeException($translator, [TranslatorInterface::class, LegacyTranslatorInterface::class]);
+	public function setTranslator(TranslatorInterface $translator) {
+		$this->translator = $translator;
 	}
 
 }

EventListener/EventListenerWithTranslatorTrait.php

@@ -705,12 +705,7 @@ public function saveCurrentStepData(FormInterface $form) {
 		$request = $this->getRequest();
 		$formName = $form->getName();
 
-		if (!\class_exists('Symfony\Component\HttpFoundation\InputBag')) {
-			// TODO remove as soon as Symfony >= 5.1 is required
-			$currentStepData = $request->request->get($formName, []);
-		} else {
-			$currentStepData = $request->request->all($formName);
-		}
+		$currentStepData = $request->request->all($formName);
 
 		if ($this->handleFileUploads) {
 			$currentStepData = array_replace_recursive($currentStepData, $request->files->get($formName, []));

Form/FormFlow.php

@@ -38,11 +38,6 @@ private function setRequestStackOrSession($requestStackOrSession) : void {
 			return;
 		}
 
-		// TODO remove as soon as Symfony >= 5.3 is required
-		if (!\method_exists(RequestStack::class, 'getSession')) {
-			throw new InvalidTypeException($requestStackOrSession, SessionInterface::class);
-		}
-
 		if ($requestStackOrSession instanceof RequestStack) {
 			$this->requestStack = $requestStackOrSession;
 

Storage/SessionProviderTrait.php

@@ -51,9 +51,8 @@ public function generate($key) {
 
 		// TODO remove checks for AnonymousToken as soon as Symfony >= 6.0 is required
 		if ($token instanceof TokenInterface && (!\class_exists(AnonymousToken::class) || !$token instanceof AnonymousToken)) {
-			// TODO just call `getUserIdentifier()` as soon as Symfony >= 5.3 is required
-			$userIdentifier = \method_exists($token, 'getUserIdentifier') ? $token->getUserIdentifier() : $token->getUsername();
-			if (is_string($userIdentifier) && $userIdentifier !== '') {
+			$userIdentifier = $token->getUserIdentifier();
+			if ($userIdentifier !== '') {
 				return sprintf('user_%s_%s', $userIdentifier, $key);
 			}
 		}