WIP #54 - Fix missing quirks

craigfowler · craigfowler · commit 081c55fec29d · 2026-02-02T21:39:15.000Z
However, I've regressed something in the process.
diff --git a/CSF.Extensions.WebDriver.Tests/CSF.Extensions.WebDriver.Tests.csproj b/CSF.Extensions.WebDriver.Tests/CSF.Extensions.WebDriver.Tests.csproj
@@ -32,7 +32,7 @@
 
   <ItemGroup>
     <Content Include="appsettings.*.json">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
   </ItemGroup>
 
diff --git a/CSF.Extensions.WebDriver.Tests/Factories/WebDriverFactoryIntegrationTests.cs b/CSF.Extensions.WebDriver.Tests/Factories/WebDriverFactoryIntegrationTests.cs
@@ -83,11 +83,13 @@ Quirks.QuirksData GetCommonBrowserQuirks()
         };
     }
 
-    IServiceProvider GetServiceProvider(Action<WebDriverCreationOptionsCollection>? configureOptions = null, Action<IServiceCollection>? extraRegistrations = null)
+    IServiceProvider GetServiceProvider(Action<WebDriverCreationOptionsCollection>? configureOptions = null,
+                                        Action<IServiceCollection>? extraRegistrations = null)
     {
         var services = new ServiceCollection();
         services.AddSingleton(GetConfiguration());
         services.AddWebDriverFactory(configureOptions: configureOptions);
+        extraRegistrations?.Invoke(services);
         services.AddLogging();
         return services.BuildServiceProvider();
     }
diff --git a/CSF.Extensions.WebDriver.Tests/appsettings.WebDriverFactoryIntegrationTests.json b/CSF.Extensions.WebDriver.Tests/appsettings.WebDriverFactoryIntegrationTests.json
@@ -22,10 +22,12 @@
                 "DriverFactoryType": "CSF.Extensions.WebDriver.Factories.WebDriverFactoryIntegrationTests+FakeWebDriverFactory, CSF.Extensions.WebDriver.Tests"
             },
             "Chrome": {
-                "DriverType": "ChromeDriver"
+                "DriverType": "ChromeDriver",
+                "AddBrowserQuirks": "True"
             },
             "Firefox": {
-                "DriverType": "FirefoxDriver"
+                "DriverType": "FirefoxDriver",
+                "AddBrowserQuirks": "True"
             }
         },
         "SelectedConfiguration": "DefaultInvalid"
diff --git a/CSF.Extensions.WebDriver/Factories/WebDriverConfigurationItemParser.cs b/CSF.Extensions.WebDriver/Factories/WebDriverConfigurationItemParser.cs
@@ -24,6 +24,8 @@ public WebDriverCreationOptions GetDriverConfiguration(IConfigurationSection con
                 OptionsType = configuration.GetValue<string>(nameof(WebDriverCreationOptions.OptionsType)),
                 GridUrl = configuration.GetValue<string>(nameof(WebDriverCreationOptions.GridUrl)),
                 DriverFactoryType = configuration.GetValue<string>(nameof(WebDriverCreationOptions.DriverFactoryType)),
+                AddBrowserIdentification = configuration.GetValue<bool>(nameof(WebDriverCreationOptions.AddBrowserIdentification)),
+                AddBrowserQuirks = configuration.GetValue<bool>(nameof(WebDriverCreationOptions.AddBrowserQuirks)),
             };
 
             if(!TryGetDriverType(creationOptions, configuration, out var driverType))

Original file line number	Diff line number	Diff line change
`@@ -83,11 +83,13 @@ Quirks.QuirksData GetCommonBrowserQuirks()`
`83`	`83`	`};`
`84`	`84`	`}`
`85`	`85`
`86`		`- IServiceProvider GetServiceProvider(Action<WebDriverCreationOptionsCollection>? configureOptions = null, Action<IServiceCollection>? extraRegistrations = null)`
	`86`	`+ IServiceProvider GetServiceProvider(Action<WebDriverCreationOptionsCollection>? configureOptions = null,`
	`87`	`+ Action<IServiceCollection>? extraRegistrations = null)`
`87`	`88`	`{`
`88`	`89`	`var services = new ServiceCollection();`
`89`	`90`	`services.AddSingleton(GetConfiguration());`
`90`	`91`	`services.AddWebDriverFactory(configureOptions: configureOptions);`
	`92`	`+ extraRegistrations?.Invoke(services);`
`91`	`93`	`services.AddLogging();`
`92`	`94`	`return services.BuildServiceProvider();`
`93`	`95`	`}`