Improve error message

This related to the "cannot generate message" fallback message.

Author: craigfowler

CSF.Screenplay/Reporting/PerformanceReportBuilder.cs

@@ -274,9 +274,9 @@ static string TryGetReport(ICanReport reporter, Actor actor, IFormatsReportFragm
             {
                 return reporter.GetReportFragment(actor, formatter).FormattedFragment;
             }
-            catch
+            catch(Exception e)
             {
-                return ReportStrings.ReportErrorMessage;
+                return string.Format(ReportStrings.ReportErrorMessageFormat, e.GetType().FullName, e.Message);
             }
         }
 

CSF.Screenplay/Resources/ReportStrings.cs

@@ -23,6 +23,6 @@ internal static class ReportStrings
         internal static string FallbackReportFormat => resourceManager.GetString("FallbackReportFormat");
 
         /// <summary>Gets a report text which is recorded when a performable raises an exception from <see cref="ICanReport.GetReportFragment(Actor, IFormatsReportFragment)"/>.</summary>
-        internal static string ReportErrorMessage => resourceManager.GetString("ReportErrorMessage");
+        internal static string ReportErrorMessageFormat => resourceManager.GetString("ReportErrorMessage");
     }
 }

CSF.Screenplay/Resources/ReportStrings.restext

@@ -3,4 +3,4 @@ ActorGainedAbilityFormat = {0} is able to {1}
 ActorSpotlitFormat = {0} was put into the spotlight
 SpotlightTurnedOff = The spotlight was turned off
 FallbackReportFormat = {0} performed {1}
-ReportErrorMessage = An unexpected error occurred getting the report text for this performable
+ReportErrorMessage = An unexpected error occurred getting the report text for this performable. {0}: {1}

Tests/CSF.Screenplay.Tests/Reporting/PerformanceReportBuilderTests.cs

@@ -222,12 +222,12 @@ public void RecordFailureForCurrentPerformableShouldUseAFallbackReportIfGettingT
                                                                                                    ICanReport performable,
                                                                                                    string performancePhase)
     {
-        Mock.Get(performable).Setup(x => x.GetReportFragment(actor, It.IsAny<IFormatsReportFragment>())).Throws<InvalidOperationException>();
+        Mock.Get(performable).Setup(x => x.GetReportFragment(actor, It.IsAny<IFormatsReportFragment>())).Throws(new Exception("Report Generation error"));
         sut.BeginPerformable(performable, actor, performancePhase);
         sut.RecordFailureForCurrentPerformable(new Exception("An error occurred"), performable, actor);
         var report = sut.GetReport(outcome);
-        Assert.That(report.Reportables,
-                    Has.One.Matches<PerformableReport>(x => x.Report == "An unexpected error occurred getting the report text for this performable"));
+        Assert.That(report.Reportables.Single().Report,
+                    Is.EqualTo("An unexpected error occurred getting the report text for this performable. System.Exception: Report Generation error"));
     }
 
     [Test, AutoMoqData]