Skip to content

Commit 3f43f89

Browse files
committed
fix: replace the FluentAssertions syntax with the default xUnit
1 parent 1a71519 commit 3f43f89

3 files changed

Lines changed: 30 additions & 28 deletions

File tree

test/API.Test/User/Register/RegisterUserEndpoint.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Net.Http.Json;
33
using System.Text.Json;
44
using CommonTestUtilities.Requests;
5-
using FluentAssertions;
65
using Microsoft.AspNetCore.Mvc.Testing;
76

87
namespace API.Test.User.Register;
@@ -20,9 +19,10 @@ public async Task Test_OnSuccess()
2019
var response = await _client.PostAsJsonAsync("/Users", request);
2120
await using var body = await response.Content.ReadAsStreamAsync();
2221
var result = await JsonDocument.ParseAsync(body);
22+
var username = result.RootElement.GetProperty("name").GetString();
2323

24-
response.StatusCode.Should().Be(HttpStatusCode.Created);
25-
result.RootElement.GetProperty("name").GetString().Should()
26-
.NotBeNullOrWhiteSpace().And.Be(request.Name);
24+
Assert.Equal(HttpStatusCode.Created, response.StatusCode);
25+
Assert.False(string.IsNullOrWhiteSpace(username));
26+
Assert.Equal(request.Name, username);
2727
}
2828
}

test/UseCases.Test/User/Register/RegisterUserUCTest.cs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using CommonTestUtilities.Repositories;
22
using CommonTestUtilities.Requests;
33
using CommonTestUtilities.Services;
4-
using FluentAssertions;
54
using RecipesApp.Application.UseCases.User.Register;
65
using RecipesApp.Exception.Project;
76
using RecipesApp.Exception.Resources;
@@ -32,8 +31,8 @@ public async Task Test_OnSuccess()
3231

3332
var result = await uc.Execute(request);
3433

35-
result.Should().NotBeNull();
36-
result.Name.Should().Be(request.Name);
34+
Assert.NotNull(result);
35+
Assert.Equal(request.Name, result.Name);
3736
}
3837

3938
[Fact]
@@ -42,10 +41,12 @@ public async Task Test_OnFailure_WithEmailAlreadyRegistered()
4241
var request = RegisterUserRequestJSONMockFactory.CreateMock();
4342
var uc = CreateUseCase(request.Email);
4443

45-
Func<Task> act = async () => await uc.Execute(request);
44+
var exception = await Assert.ThrowsAsync<ErrorOnValidationException>(Act);
45+
Assert.True(exception.ErrorMessages.Count == 1);
46+
Assert.True(exception.ErrorMessages
47+
.Contains(ResourcesAccessor.EMAIL_ALREADY_REGISTERED));
48+
return;
4649

47-
(await act.Should().ThrowAsync<ErrorOnValidationException>())
48-
.Where(e => e.ErrorMessages.Count == 1
49-
&& e.ErrorMessages.Contains(ResourcesAccessor.EMAIL_ALREADY_REGISTERED));
50+
async Task Act() => await uc.Execute(request);
5051
}
5152
}

test/Validators.Test/User/Register/RegisterUserValidatorTest.cs

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using CommonTestUtilities.Requests;
2-
using FluentAssertions;
32
using RecipesApp.Application.UseCases.User.Register;
43
using RecipesApp.Exception.Resources;
54

@@ -14,7 +13,7 @@ public void Test_OnSuccess()
1413
var request = RegisterUserRequestJSONMockFactory.CreateMock();
1514
var result = v.Validate(request);
1615

17-
result.IsValid.Should().BeTrue();
16+
Assert.True(result.IsValid);
1817
}
1918

2019
[Fact]
@@ -24,9 +23,9 @@ public void Test_OnFailureWith_EmptyName()
2423
var request = RegisterUserRequestJSONMockFactory.CreateMockWithoutName();
2524
var result = v.Validate(request);
2625

27-
result.IsValid.Should().BeFalse();
28-
result.Errors.Should().ContainSingle()
29-
.And.Contain(e => e.ErrorMessage.Equals(ResourcesAccessor.NAME_REQUIRED));
26+
Assert.False(result.IsValid);
27+
Assert.Single(result.Errors,
28+
error => error.ErrorMessage.Equals(ResourcesAccessor.NAME_REQUIRED));
3029
}
3130

3231
[Fact]
@@ -36,20 +35,21 @@ public void Test_OnFailureWith_EmptyEmail()
3635
var request = RegisterUserRequestJSONMockFactory.CreateMockWithoutEmail();
3736
var result = v.Validate(request);
3837

39-
result.IsValid.Should().BeFalse();
40-
result.Errors.Should().ContainSingle()
41-
.And.Contain(e => e.ErrorMessage.Equals(ResourcesAccessor.EMAIL_REQUIRED));
38+
Assert.False(result.IsValid);
39+
Assert.Single(result.Errors,
40+
error => error.ErrorMessage.Equals(ResourcesAccessor.EMAIL_REQUIRED));
4241
}
42+
4343
[Fact]
4444
public void Test_OnFailureWith_InvalidEmail()
4545
{
4646
var v = new RegisterUserValidator();
4747
var request = RegisterUserRequestJSONMockFactory.CreateMockWithInvalidEmail("email.com");
4848
var result = v.Validate(request);
4949

50-
result.IsValid.Should().BeFalse();
51-
result.Errors.Should().ContainSingle()
52-
.And.Contain(e => e.ErrorMessage.Equals(ResourcesAccessor.EMAIL_INVALID));
50+
Assert.False(result.IsValid);
51+
Assert.Single(result.Errors,
52+
error => error.ErrorMessage.Equals(ResourcesAccessor.EMAIL_INVALID));
5353
}
5454

5555
[Fact]
@@ -59,10 +59,11 @@ public void Test_OnFailureWith_EmptyPassword()
5959
var request = RegisterUserRequestJSONMockFactory.CreateMockWithoutPassword();
6060
var result = v.Validate(request);
6161

62-
result.IsValid.Should().BeFalse();
63-
result.Errors.Should().ContainSingle()
64-
.And.Contain(e => e.ErrorMessage.Equals(ResourcesAccessor.PASSWORD_REQUIRED));
62+
Assert.False(result.IsValid);
63+
Assert.Single(result.Errors,
64+
error=> error.ErrorMessage.Equals(ResourcesAccessor.PASSWORD_REQUIRED));
6565
}
66+
6667
[Theory]
6768
[InlineData(1)]
6869
[InlineData(2)]
@@ -75,8 +76,8 @@ public void Test_OnFailureWith_InvalidPassword(int passwordLength)
7576
var request = RegisterUserRequestJSONMockFactory.CreateMock(passwordLength);
7677
var result = v.Validate(request);
7778

78-
result.IsValid.Should().BeFalse();
79-
result.Errors.Should().ContainSingle()
80-
.And.Contain(e => e.ErrorMessage.Equals(ResourcesAccessor.PASSWORD_LENGTH));
79+
Assert.False(result.IsValid);
80+
Assert.Single(result.Errors,
81+
error=> error.ErrorMessage.Equals(ResourcesAccessor.PASSWORD_LENGTH));
8182
}
8283
}

0 commit comments

Comments
 (0)