Replace chai.assert with node:assert/strict (#3252)

Also switched all existing node:assert to node:assert/strict

Author: AndreasArvidsson

.oxlintrc.json

@@ -39,6 +39,12 @@
     "eslint/no-restricted-imports": [
       "warn",
       {
+        "paths": [
+          {
+            "name": "node:assert",
+            "message": "Use node:assert/strict instead"
+          }
+        ],
         "patterns": [
           {
             "group": ["../*/src", "../*/src/*", "../../*/src", "../../*/src/*"],
@@ -77,6 +83,7 @@
     "typescript/restrict-template-expressions": "off",
     "typescript/unbound-method": "off",
     "unicorn/prefer-module": "warn",
+    "unicorn/prefer-node-protocol": "warn",
     "unicorn/throw-new-error": "warn"
   },
   "overrides": [

packages/app-vscode/src/createVscodeIde.ts

@@ -1,4 +1,4 @@
-import * as crypto from "crypto";
+import * as crypto from "node:crypto";
 import * as os from "node:os";
 import * as path from "node:path";
 import type { ExtensionContext } from "vscode";

packages/app-vscode/src/ide/vscode/textLine.vscode.test.ts

@@ -1,4 +1,4 @@
-import * as assert from "assert";
+import * as assert from "node:assert/strict";
 import { getReusableEditor } from "@cursorless/lib-vscode-common";
 import VscodeTextLine from "./VscodeTextLine";
 

packages/app-vscode/src/keyboard/buildSuffixTrie.test.ts

@@ -1,4 +1,4 @@
-import assert from "node:assert";
+import * as assert from "node:assert/strict";
 import type { KeyValuePair } from "./buildSuffixTrie";
 import { buildSuffixTrie } from "./buildSuffixTrie";
 import { isEqual, sortBy, uniq, uniqWith } from "lodash-es";
@@ -130,8 +130,8 @@ suite("buildSuffixTrie", () => {
         sortEntries(chars.flatMap((char) => trie.search(char))),
         isEqual,
       ).map(({ key, value }) => ({ key, value }));
-      assert.deepStrictEqual(actual, sortEntries(expected));
-      assert.deepStrictEqual(
+      assert.deepEqual(actual, sortEntries(expected));
+      assert.deepEqual(
         sortBy(conflicts.map(sortEntries), (conflict) =>
           JSON.stringify(conflict),
         ),

packages/app-vscode/src/keyboard/grammar/getAcceptableTokenTypes.test.ts

@@ -1,4 +1,4 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import nearley from "nearley";
 import type { KeyDescriptor } from "../TokenTypeHelpers";
 import grammar from "./generated/grammar";
@@ -153,7 +153,7 @@ suite("keyboard.getAcceptableTokenTypes", () => {
             arg: value.partialArg,
           },
         };
-        assert(
+        assert.ok(
           candidates.some((result) => isEqual(result, fullValue)),
           "Relevant candidates (note that symbols will be missing):\n" +
             JSON.stringify(candidates, null, 2),

packages/app-vscode/src/keyboard/grammar/grammar.test.ts

@@ -1,6 +1,6 @@
 import nearley from "nearley";
 import grammar from "./generated/grammar";
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import type { KeyDescriptor } from "../TokenTypeHelpers";
 import type { KeyboardCommandHandler } from "../KeyboardCommandHandler";
 import type { KeyboardCommand } from "../KeyboardCommandTypeHelpers";
@@ -189,7 +189,7 @@ suite("keyboard grammar", () => {
       parser.feed(tokens);
 
       assert.equal(parser.results.length, 1);
-      assert.deepStrictEqual(parser.results[0], expected);
+      assert.deepEqual(parser.results[0], expected);
     });
   });
 });

packages/app-vscode/src/scripts/initLaunchSandbox.ts

@@ -4,7 +4,7 @@
  * developing the Cursorless VSCode extension locally.
  */
 import { extensionDependencies } from "@cursorless/lib-common";
-import * as cp from "child_process";
+import * as cp from "node:child_process";
 
 const vsCodeToolName: string = "code";
 const validCliToolParams: Array<string> = ["--code", "--codium"];

packages/app-vscode/src/scripts/populateDist/runCommand.ts

@@ -1,5 +1,5 @@
-import { exec } from "child_process";
-import { promisify } from "util";
+import { exec } from "node:child_process";
+import { promisify } from "node:util";
 
 const execAsync = promisify(exec);
 

packages/app-web-docs/docusaurus.config.mts

@@ -2,7 +2,7 @@ import type { Config } from "@docusaurus/types";
 import type { Root } from "mdast";
 import { createRequire } from "node:module";
 import { fileURLToPath } from "node:url";
-import { dirname, extname, relative, resolve } from "path";
+import { dirname, extname, relative, resolve } from "node:path";
 import { themes } from "prism-react-renderer";
 import type { Transformer } from "unified";
 import { visit } from "unist-util-visit";

packages/app-web-docs/src/docs/components/flattenHighlights.test.ts

@@ -1,5 +1,5 @@
 import { BorderStyle, Range } from "@cursorless/lib-common";
-import * as assert from "node:assert";
+import * as assert from "node:assert/strict";
 import { flattenHighlights } from "./flattenHighlights";
 import type { Highlight, Scope } from "./types";