Throw error on file patterns without any files matched

Author: AndreasArvidsson

src/cli/cli.ts

@@ -6,12 +6,13 @@ import type { Readable } from "node:stream";
 import type { CLI, Logger, ParsedArgs } from "../types.js";
 import { EXIT_ERROR, EXIT_FAIL, EXIT_OK } from "../util/constants.js";
 import { createLogger } from "../util/createLogger.js";
+import { FilePatternError } from "../util/FilePatternError.js";
 import { getErrorMessage } from "../util/getErrorMessage.js";
 import { getOptionsFromConfig } from "../util/getOptionsFromConfig.js";
 import { isMissingFileError } from "../util/isMissingFileError.js";
+import { normalizeToPosix } from "../util/normalizeToPosix.js";
 import { parseArgs } from "../util/parseArgs.js";
 import { parseFilePatterns } from "../util/parseFilePatterns.js";
-import { normalizeToPosix } from "../util/normalizeToPosix.js";
 import { printHelp } from "../util/printHelp.js";
 import { printVersion } from "../util/printVersion.js";
 import { setExitCode } from "../util/setExitCode.js";
@@ -25,7 +26,13 @@ export async function main(cli: CLI): Promise<void> {
         const exitCode = await mainUnsafe({ cli, args, logger });
         setExitCode(exitCode);
     } catch (error) {
-        logger.error(getErrorMessage(error));
+        if (error instanceof FilePatternError) {
+            for (const message of error.messages) {
+                logger.error(message);
+            }
+        } else {
+            logger.error(getErrorMessage(error));
+        }
         setExitCode(EXIT_ERROR);
     }
 }

src/util/FilePatternError.ts

@@ -0,0 +1,9 @@
+export class FilePatternError extends Error {
+    name = "FilePatternError";
+
+    constructor(public messages: string[]) {
+        super(
+            `One or more file pattern errors occurred:\n${messages.join("\n")}`,
+        );
+    }
+}

src/util/parseFilePatterns.ts

@@ -3,6 +3,7 @@ import fastGlob from "fast-glob";
 import * as path from "node:path";
 import type { CLI } from "../types.js";
 import { GLOB_IGNORE_PATTERNS } from "./constants.js";
+import { FilePatternError } from "./FilePatternError.js";
 import { lstatSafe } from "./lstatSafe.js";
 import { normalizeToPosix } from "./normalizeToPosix.js";
 
@@ -12,6 +13,7 @@ export async function parseFilePatterns(
 ): Promise<string[]> {
     const seen: Set<string> = new Set();
     const globFileEndingPattern = getGlobFileEndingsPattern(cli.fileEndings);
+    const errorMessages: string[] = [];
 
     const globOptions: Options = {
         dot: true,
@@ -25,9 +27,10 @@ export async function parseFilePatterns(
 
         if (stat != null) {
             if (stat.isSymbolicLink()) {
-                throw new Error(
-                    `Specified pattern "${pattern}" is a symbolic link.`,
+                errorMessages.push(
+                    `Specified pattern is a symbolic link: ${pattern}`,
                 );
+                continue;
             }
 
             if (stat.isFile()) {
@@ -40,6 +43,11 @@ export async function parseFilePatterns(
                     ...globOptions,
                     cwd: absolutePath,
                 });
+                if (files.length === 0) {
+                    errorMessages.push(
+                        `No matching files were found in the directory: ${pattern}`,
+                    );
+                }
                 for (const file of files) {
                     seen.add(path.resolve(absolutePath, file));
                 }
@@ -49,11 +57,20 @@ export async function parseFilePatterns(
 
         const glob = normalizeToPosix(pattern);
         const files = await fastGlob(glob, globOptions);
+        if (files.length === 0) {
+            errorMessages.push(
+                `No files matching the pattern were found: ${pattern}`,
+            );
+        }
         for (const file of files) {
             seen.add(path.resolve(file));
         }
     }
 
+    if (errorMessages.length > 0) {
+        throw new FilePatternError(errorMessages);
+    }
+
     return Array.from(seen).sort((a, b) => a.localeCompare(b));
 }