Remove default value for check argument

Author: AndreasArvidsson

.gitignore

@@ -1,2 +1,3 @@
 node_modules
 out
+.tmp-test

src/cli/cli.ts

@@ -42,7 +42,7 @@ async function mainUnsafe(cli: CLI): Promise<number> {
     // If no file patterns are provided, check if there's input from stdin.
     // If stdin TTY it's an interactive terminal, so we shouldn't read from it.
     if (!process.stdin.isTTY) {
-        return mainFormatStdin(cli, args.check);
+        return mainFormatStdin(cli, process.stdin, args.check);
     }
 
     throw new Error(
@@ -53,7 +53,7 @@ async function mainUnsafe(cli: CLI): Promise<number> {
 async function mainFormatFiles(
     cli: CLI,
     filePatterns: string[],
-    check: boolean = false,
+    check: boolean,
 ): Promise<number> {
     if (check) {
         console.log("Checking formatting...");
@@ -85,7 +85,7 @@ async function mainFormatFiles(
 export async function formatFiles(
     cli: CLI,
     filePatterns: string[],
-    check: boolean = false,
+    check: boolean,
 ): Promise<number> {
     let changedFileCount = 0;
 
@@ -101,7 +101,7 @@ export async function formatFiles(
 export async function formatFile(
     cli: CLI,
     fileName: string,
-    check: boolean = false,
+    check: boolean,
 ): Promise<boolean> {
     try {
         const content = await fs.readFile(fileName, "utf8");
@@ -135,8 +135,8 @@ export async function formatFile(
 
 export async function mainFormatStdin(
     cli: CLI,
+    stdin: Readable,
     check: boolean,
-    stdin: Readable = process.stdin,
 ): Promise<number> {
     const input = await getStdin({ stdin });
     const formatted = await cli.format(input, "stdin");

src/test/cli.test.ts

@@ -18,7 +18,7 @@ suite("CLI", () => {
         const cli = createCLI((text) => `${text} updated`);
 
         try {
-            const didChange = await formatFile(cli, fileName);
+            const didChange = await formatFile(cli, fileName, false);
             const actual = await fs.readFile(fileName, "utf8");
 
             assert.equal(didChange, true);
@@ -59,10 +59,11 @@ suite("CLI", () => {
             await fs.writeFile(unchangedFileName, "unchanged", "utf8");
             await fs.writeFile(changedFileName, "changed", "utf8");
 
-            const changedFileCount = await formatFiles(cli, [
-                unchangedFileName,
-                changedFileName,
-            ]);
+            const changedFileCount = await formatFiles(
+                cli,
+                [unchangedFileName, changedFileName],
+                false,
+            );
             const unchangedContent = await fs.readFile(
                 unchangedFileName,
                 "utf8",
@@ -81,7 +82,7 @@ suite("CLI", () => {
         const fileName = path.join(os.tmpdir(), "talonfmt-missing.txt");
         const cli = createCLI((text) => `${text} updated`);
 
-        const didChange = await formatFile(cli, fileName);
+        const didChange = await formatFile(cli, fileName, false);
 
         assert.equal(didChange, false);
     });
@@ -98,7 +99,7 @@ suite("CLI", () => {
 
         try {
             await assert.rejects(
-                formatFile(cli, fileName),
+                formatFile(cli, fileName, false),
                 /Failed to format '.*example\.txt': boom/,
             );
         } finally {
@@ -203,7 +204,7 @@ async function readAndFormatStdin(
 ): Promise<number> {
     const stdin = new PassThrough();
     Object.defineProperty(stdin, "isTTY", { value: false });
-    const result = mainFormatStdin(cli, check, stdin);
+    const result = mainFormatStdin(cli, stdin, check);
     stdin.end(input);
     return result;
 }