Fix race condition on accessing md.Metrics and md.MetricsStandby

0xgouda · 0xgouda · commit 038a7734057f · 2026-04-09T19:55:24.000+02:00
diff --git a/internal/reaper/metric.go b/internal/reaper/metric.go
@@ -99,10 +99,14 @@ func (r *Reaper) LoadMetrics() (err error) {
 	// update the monitored sources with real metric definitions from presets
 	for _, md := range r.monitoredSources {
 		if md.PresetMetrics > "" {
+			md.Lock()
 			md.Metrics = metricDefs.GetPresetMetrics(md.PresetMetrics)
+			md.Unlock()
 		}
 		if md.PresetMetricsStandby > "" {
+			md.Lock()
 			md.MetricsStandby = metricDefs.GetPresetMetrics(md.PresetMetricsStandby)
+			md.Unlock()
 		}
 	}
 	return

Original file line number	Diff line number	Diff line change
`@@ -99,10 +99,14 @@ func (r *Reaper) LoadMetrics() (err error) {`
`99`	`99`	`// update the monitored sources with real metric definitions from presets`
`100`	`100`	`for _, md := range r.monitoredSources {`
`101`	`101`	`if md.PresetMetrics > "" {`
	`102`	`+ md.Lock()`
`102`	`103`	`md.Metrics = metricDefs.GetPresetMetrics(md.PresetMetrics)`
	`104`	`+ md.Unlock()`
`103`	`105`	`}`
`104`	`106`	`if md.PresetMetricsStandby > "" {`
	`107`	`+ md.Lock()`
`105`	`108`	`md.MetricsStandby = metricDefs.GetPresetMetrics(md.PresetMetricsStandby)`
	`109`	`+ md.Unlock()`
`106`	`110`	`}`
`107`	`111`	`}`
`108`	`112`	`return`