Skip to content

Commit 77562a0

Browse files
committed
remove case-sensitive tests entirely.
Not all databases are predictable as lexicographical order mixes up case in arbitrarily varying ways. 'A' can be less than, greater than, or equal to 'a' depending on the DB and/or its configuration.
1 parent 3402c7e commit 77562a0

1 file changed

Lines changed: 0 additions & 24 deletions

File tree

irods/test/query_test.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -213,30 +213,6 @@ def test_files_query_case_sensitive(self):
213213
)
214214
self.assertEqual(len(result12), 0)
215215

216-
# BETWEEN tests
217-
218-
# TODO(#600): Uncomment these lines and/or make a new test when database flavor can be detected.
219-
# The resultset for BETWEEN queries can differ from database to database.
220-
221-
# result13 = self.sess.query(DataObject.name).filter(
222-
# Collection.name == self.coll_path).filter(
223-
# Between(DataObject.name, [self.case_sensitive_obj_name1,
224-
# self.case_sensitive_obj_name1 + "_"])).all()
225-
# self.assertTrue(result13.has_value(self.case_sensitive_obj_name1))
226-
# self.assertEqual(len(result13), 1)
227-
228-
# result14 = self.sess.query(DataObject.name).filter(
229-
# Collection.name == self.coll_path).filter(
230-
# Between(DataObject.name, [str.lower(self.case_sensitive_obj_name1),
231-
# str.lower(self.case_sensitive_obj_name1) + "_"])).all()
232-
# self.assertEqual(len(result14), 0)
233-
234-
# result15 = self.sess.query(DataObject.name).filter(
235-
# Collection.name == self.coll_path).filter(
236-
# Between(DataObject.name, [str.upper(self.case_sensitive_obj_name1),
237-
# str.upper(self.case_sensitive_obj_name1) + "_"])).all()
238-
# self.assertEqual(len(result15), 0)
239-
240216
def test_files_query_case_insensitive(self):
241217
# This tests that GenQueries are case-insensitive when the case_sensitive
242218
# option is set to false.

0 commit comments

Comments
 (0)