Skip to content

Commit ff24da9

Browse files
committed
test cov: removed redundant jacoco download in dockerfile
1 parent 74c825b commit ff24da9

2 files changed

Lines changed: 9 additions & 12 deletions

File tree

.gitlab-ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,11 @@ container:
226226
image: ghcr.io/kaniko-build/dist/chainguard-dev-kaniko/executor:latest-debug
227227
needs:
228228
- tar
229+
- job: get_jacoco_cli
230+
optional: true
229231
dependencies:
230232
- tar
233+
- get_jacoco_cli
231234
script:
232235
- |-
233236
tag=$CI_COMMIT_SHORT_SHA
@@ -236,6 +239,7 @@ container:
236239
tag=$CI_COMMIT_TAG
237240
jacoco_enabled=false
238241
fi
242+
- mkdir -p "jacoco-${JACOCO_VERSION}/lib"
239243
- mkdir maven
240244
- tar -C maven --strip-components=1 -xzvf packages/tar/target/dcache-*.tar.gz
241245
- cp $CI_PROJECT_DIR/packages/tar/src/main/container/* .

packages/tar/src/main/container/Dockerfile

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,9 @@ FROM almalinux:10-minimal as builder
77
RUN microdnf -y install java-21-openjdk-devel java-21-openjdk-jmods binutils
88
RUN jlink --compress=zip-6 --strip-debug --no-header-files --no-man-pages --add-modules java.base,java.compiler,java.instrument,java.logging,java.management,java.naming,java.security.jgss,java.transaction.xa,java.xml,jdk.jfr,jdk.security.auth,jdk.unsupported,java.desktop,java.sql,jdk.naming.dns,java.rmi,jdk.crypto.cryptoki --output /jlink-runtime
99
ARG JACOCO_VERSION
10-
ARG JACOCO_ENABLED=false
11-
RUN if [ "$JACOCO_ENABLED" = "true" ]; then \
12-
microdnf -y install wget unzip && \
13-
wget -q "https://github.com/jacoco/jacoco/releases/download/v${JACOCO_VERSION}/jacoco-${JACOCO_VERSION}.zip" \
14-
-O /tmp/jacoco.zip && \
15-
unzip -q /tmp/jacoco.zip -d /tmp/jacoco; \
16-
else \
17-
mkdir -p /tmp/jacoco/lib && \
18-
touch /tmp/jacoco/lib/jacocoagent.jar /tmp/jacoco/lib/jacococli.jar; \
19-
fi
10+
RUN mkdir -p /tmp/jacoco/lib
11+
COPY jacoco-${JACOCO_VERSION}/lib/jacocoagent.jar* /tmp/jacoco/lib/
12+
COPY jacoco-${JACOCO_VERSION}/lib/jacococli.jar* /tmp/jacoco/lib/
2013

2114
# Minimalistic Java image
2215
FROM almalinux:10-minimal
@@ -27,8 +20,8 @@ ARG JACOCO_ENABLED=false
2720
ENV JACOCO_ENABLED=${JACOCO_ENABLED}
2821
# Copy both the agent and the cli
2922
ENV DCACHE_INSTALL_DIR=/opt/dcache
30-
COPY --from=builder /tmp/jacoco/lib/jacocoagent.jar ${DCACHE_INSTALL_DIR}/share/classes/jacocoagent.jar
31-
COPY --from=builder /tmp/jacoco/lib/jacococli.jar ${DCACHE_INSTALL_DIR}/share/classes/jacococli.jar
23+
COPY --from=builder /tmp/jacoco/lib/jacocoagent.jar* ${DCACHE_INSTALL_DIR}/share/classes/
24+
COPY --from=builder /tmp/jacoco/lib/jacococli.jar* ${DCACHE_INSTALL_DIR}/share/classes/
3225

3326
# Neede by groupadd and useradd
3427
# REVISIT: in some environments base OS kernel doesnt allow use of xattrs and the installation of

0 commit comments

Comments
 (0)