Skip to content

Commit 79ae120

Browse files
authored
Merge pull request #72 from dOrgTech/no-entity-double-fetch
No entity double fetch
2 parents 0f80982 + ce00c57 commit 79ae120

48 files changed

Lines changed: 145 additions & 96 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/components/DAO.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
} from "../";
1010
import { CreateContextFeed } from "../runtime/ContextFeed";
1111

12-
interface RequiredProps extends ComponentProps {
12+
interface RequiredProps extends ComponentProps<Entity, Data> {
1313
// Address of the DAO Avatar
1414
address: string;
1515
}

src/components/DAOs.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class InferredDAOs extends ComponentList<InferredProps, Component> {
4343
key={`${entity.id}_${index}`}
4444
address={entity.id}
4545
config={config}
46+
entity={entity}
4647
>
4748
{children}
4849
</Component>

src/components/Member.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as React from "react";
2+
import { Member as Entity, IMemberState as Data } from "@dorgtech/arc.js";
23
import {
34
Arc as Protocol,
45
ArcConfig as ProtocolConfig,
@@ -9,9 +10,8 @@ import {
910
ComponentProps,
1011
} from "../";
1112
import { CreateContextFeed } from "../runtime/ContextFeed";
12-
import { Member as Entity, IMemberState as Data } from "@dorgtech/arc.js";
1313

14-
interface RequiredProps extends ComponentProps {
14+
interface RequiredProps extends ComponentProps<Entity, Data> {
1515
// Address of the member
1616
address: string;
1717
dao?: string | DAOEntity;

src/components/Members.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as React from "react";
22
import { Observable } from "rxjs";
3+
import { IMemberQueryOptions as FilterOptions } from "@dorgtech/arc.js";
34
import {
45
Arc as Protocol,
56
ArcConfig as ProtocolConfig,
@@ -14,7 +15,6 @@ import {
1415
ComponentListProps,
1516
createFilterFromScope,
1617
} from "../";
17-
import { IMemberQueryOptions as FilterOptions } from "@dorgtech/arc.js";
1818
import { CreateContextFeed } from "../runtime/ContextFeed";
1919

2020
type Scopes = "DAO";
@@ -59,6 +59,7 @@ class InferredMembers extends ComponentList<InferredProps, Component> {
5959
address={entity.coreState!.address}
6060
dao={entity.coreState!.dao.entity}
6161
config={config}
62+
entity={entity}
6263
>
6364
{children}
6465
</Component>

src/components/Queue.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
} from "../";
1212
import { CreateContextFeed } from "../runtime/ContextFeed";
1313

14-
interface RequiredProps extends ComponentProps {
14+
interface RequiredProps extends ComponentProps<Entity, Data> {
1515
// Address of the Queue Avatar
1616
id: string;
1717
dao?: string | DAOEntity;

src/components/Queues.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as React from "react";
22
import { Observable } from "rxjs";
3+
import { IQueueQueryOptions as FilterOptions } from "@dorgtech/arc.js";
34
import {
45
Arc as Protocol,
56
ArcConfig as ProtocolConfig,
@@ -14,7 +15,6 @@ import {
1415
ComponentListProps,
1516
createFilterFromScope,
1617
} from "../";
17-
import { IQueueQueryOptions as FilterOptions } from "@dorgtech/arc.js";
1818
import { CreateContextFeed } from "../runtime/ContextFeed";
1919

2020
type Scopes = "DAO";
@@ -57,6 +57,7 @@ class InferredQueues extends ComponentList<InferredProps, Component> {
5757
dao={dao}
5858
id={entity.id}
5959
config={config}
60+
entity={entity}
6061
>
6162
{children}
6263
</Component>

src/components/Reputation.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
} from "../";
1515
import { CreateContextFeed } from "../runtime/ContextFeed";
1616

17-
interface RequiredProps extends ComponentProps {
17+
interface RequiredProps extends ComponentProps<Entity, Data> {
1818
// Address of the Reputation Token
1919
address?: string;
2020
}

src/components/Reputations.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as React from "react";
22
import { Observable } from "rxjs";
3+
import { IReputationQueryOptions as FilterOptions } from "@dorgtech/arc.js";
34
import {
45
Arc as Protocol,
56
ArcConfig as ProtocolConfig,
@@ -11,8 +12,6 @@ import {
1112
ComponentListLogs,
1213
ComponentListProps,
1314
} from "../";
14-
15-
import { IReputationQueryOptions as FilterOptions } from "@dorgtech/arc.js";
1615
import { CreateContextFeed } from "../runtime/ContextFeed";
1716

1817
type RequiredProps = ComponentListProps<Entity, FilterOptions>;
@@ -44,6 +43,7 @@ class InferredReputations extends ComponentList<InferredProps, Component> {
4443
key={`${entity.id}_${index}`}
4544
address={entity.address}
4645
config={config}
46+
entity={entity}
4747
>
4848
{children}
4949
</Component>

src/components/Reward.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
ComponentProps,
1010
} from "../";
1111

12-
interface RequiredProps extends ComponentProps {
12+
interface RequiredProps extends ComponentProps<Entity, Data> {
1313
// Reward ID
1414
id: string;
1515
}

src/components/Rewards.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as React from "react";
22
import { Observable } from "rxjs";
3+
import { IRewardQueryOptions as FilterOptions } from "@dorgtech/arc.js";
34
import {
45
Arc as Protocol,
56
ArcConfig as ProtocolConfig,
@@ -21,7 +22,6 @@ import {
2122
createFilterFromScope,
2223
} from "../";
2324
import { CreateContextFeed } from "../runtime/ContextFeed";
24-
import { IRewardQueryOptions as FilterOptions } from "@dorgtech/arc.js";
2525

2626
type Scopes = "DAO" | "Member as beneficiary" | "Proposal" | "Token";
2727

@@ -66,7 +66,12 @@ class InferredRewards extends ComponentList<InferredProps, Component> {
6666
const { config } = this.props;
6767

6868
return (
69-
<Component key={`${entity.id}_${index}`} id={entity.id} config={config}>
69+
<Component
70+
key={`${entity.id}_${index}`}
71+
id={entity.id}
72+
config={config}
73+
entity={entity}
74+
>
7075
{children}
7176
</Component>
7277
);

0 commit comments

Comments
 (0)