domain assessment fixes with claude

Author: dabblingwithcode

docs/bugs_and_todos/bugs.md

@@ -29,7 +29,10 @@ enum HubObjectType implements _i1.SerializableModel {
   schoolday,
   schoolSemester,
   schoolData,
-  user;
+  user,
+  libraryBook,
+  workbook,
+  timetableData;
 
   static HubObjectType fromJson(int index) {
     switch (index) {
@@ -69,6 +72,12 @@ enum HubObjectType implements _i1.SerializableModel {
         return HubObjectType.schoolData;
       case 17:
         return HubObjectType.user;
+      case 18:
+        return HubObjectType.libraryBook;
+      case 19:
+        return HubObjectType.workbook;
+      case 20:
+        return HubObjectType.timetableData;
       default:
         throw ArgumentError(
             'Value "$index" cannot be converted to "HubObjectType"');

docs/model_relations/school_data_hub_server.svg

@@ -25,6 +25,7 @@ import 'package:school_data_hub_flutter/features/books/domain/book_manager.dart'
 import 'package:school_data_hub_flutter/features/books/domain/filters/pupil_book_lending_filter_manager.dart';
 import 'package:school_data_hub_flutter/features/books/domain/pupil_book_lending_manager.dart';
 import 'package:school_data_hub_flutter/features/learning/_competence/domain/competence_manager.dart';
+import 'package:school_data_hub_flutter/features/learning/_competence/presentation/learning_content_selection.dart';
 import 'package:school_data_hub_flutter/features/learning/_competence/domain/filters/competence_filter_manager.dart';
 import 'package:school_data_hub_flutter/features/learning/competence_report/domain/competence_report_item_manager.dart';
 import 'package:school_data_hub_flutter/features/learning/competence_report/domain/competence_report_manager.dart';
@@ -94,8 +95,8 @@ class InitOnUserAuth {
       dispose: (m) => m.dispose(),
     );
 
-    di.registerSingletonWithDependencies<LearningSupportManager>(
-      () => LearningSupportManager(),
+    di.registerSingletonAsync<LearningSupportManager>(
+      () => LearningSupportManager().init(),
       dependsOn: [
         PupilProxyManager,
         SchoolCalendarManager,
@@ -132,6 +133,11 @@ class InitOnUserAuth {
       dispose: (m) => m.dispose(),
     );
 
+    di.registerSingleton<LearningContentSelection>(
+      LearningContentSelection(),
+      dispose: (s) => s.dispose(),
+    );
+
     di.registerSingletonAsync<CompetenceManager>(
       () => CompetenceManager().init(),
       dependsOn: [HubStreamService],

school_data_hub_client/lib/src/protocol/_features/hub/models/hub_object_type.dart

@@ -0,0 +1,9 @@
+import 'package:flutter_it/flutter_it.dart';
+import 'package:school_data_hub_client/school_data_hub_client.dart';
+import 'package:school_data_hub_flutter/features/_attendance/domain/attendance_manager.dart';
+import 'package:school_data_hub_flutter/features/_pupil/domain/models/pupil_proxy.dart';
+
+extension PupilProxyAttendance on PupilProxy {
+  List<MissedSchoolday>? get missedSchooldays =>
+      di<AttendanceManager>().getAllPupilMissedSchooldays(pupilId);
+}

school_data_hub_flutter/assets/school_data_hub_server.svg

@@ -25,9 +25,9 @@ class AuthorizationManager with ChangeNotifier {
 
   final _cacheManager = di<DefaultCacheManager>();
 
-  ValueListenable<List<Authorization>> get authorizations => _authorizations;
+  ListNotifier<Authorization> get authorizations => _authorizations;
 
-  final _authorizations = ValueNotifier<List<Authorization>>([]);
+  final _authorizations = ListNotifier<Authorization>();
 
   Map<int, Authorization> _authorizationsMap = {};
 
@@ -103,13 +103,20 @@ class AuthorizationManager with ChangeNotifier {
     if (_authorizationsMap.containsKey(id)) {
       _authorizationsMap.remove(id);
       _removePupilAuthListenablesForAuth(id);
-      _authorizations.value = _authorizationsMap.values.toList();
+      _syncAuthorizationsList();
       notifyListeners();
     }
   }
 
+  void _syncAuthorizationsList() {
+    _authorizations.startTransAction();
+    _authorizations.clear();
+    _authorizations.addAll(_authorizationsMap.values);
+    _authorizations.endTransAction();
+  }
+
   void clearData() {
-    _authorizations.value = [];
+    _authorizations.clear();
     _authorizationsMap = {};
     _pupilAuthListenables.clear();
   }
@@ -149,7 +156,7 @@ class AuthorizationManager with ChangeNotifier {
     for (var authorization in authorizations) {
       _authorizationsMap[authorization.id!] = authorization;
     }
-    _authorizations.value = _authorizationsMap.values.toList();
+    _syncAuthorizationsList();
   }
 
   void _updatePupilAuthInCollections(PupilAuthorization pupilAuth) {
@@ -169,7 +176,7 @@ class AuthorizationManager with ChangeNotifier {
     _authorizationsMap[authId] = authorization.copyWith(
       authorizedPupils: pupilAuths,
     );
-    _authorizations.value = _authorizationsMap.values.toList();
+    _syncAuthorizationsList();
   }
 
   Future<void> fetchAuthorizations() async {
@@ -194,7 +201,7 @@ class AuthorizationManager with ChangeNotifier {
       return;
     }
     _authorizationsMap[authorization.id!] = authorization;
-    _authorizations.value = _authorizationsMap.values.toList();
+    _syncAuthorizationsList();
 
     _notificationService.showSnackBar(
       NotificationType.success,
@@ -237,7 +244,7 @@ class AuthorizationManager with ChangeNotifier {
     }
     _authorizationsMap.remove(authId);
     _removePupilAuthListenablesForAuth(authId);
-    _authorizations.value = _authorizationsMap.values.toList();
+    _syncAuthorizationsList();
 
     _notificationService.showSnackBar(
       NotificationType.success,

school_data_hub_flutter/lib/core/init/init_on_user_auth.dart

@@ -3,21 +3,13 @@
 import 'package:collection/collection.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter_it/flutter_it.dart';
-import 'package:logging/logging.dart';
 import 'package:school_data_hub_client/school_data_hub_client.dart';
-import 'package:school_data_hub_flutter/features/_attendance/domain/attendance_manager.dart';
 import 'package:school_data_hub_flutter/features/_pupil/domain/models/enums.dart';
 import 'package:school_data_hub_flutter/features/_pupil/domain/models/pupil_identity_extensions.dart';
 import 'package:school_data_hub_flutter/features/_pupil/domain/pupil_proxy_manager.dart';
-import 'package:school_data_hub_flutter/features/books/domain/pupil_book_lending_manager.dart';
-import 'package:school_data_hub_flutter/features/learning/_competence/domain/competence_manager.dart';
-import 'package:school_data_hub_flutter/features/learning_support/domain/learning_support_manager.dart';
-import 'package:school_data_hub_flutter/features/workbooks/domain/pupil_workbook_manager.dart';
 
 typedef SiblingsResolver = List<PupilProxy> Function(PupilProxy pupil);
 
-final _log = Logger('PupilProxy');
-
 class PupilProxy with ChangeNotifier {
   PupilProxy({
     required PupilData pupilData,
@@ -36,20 +28,14 @@ class PupilProxy with ChangeNotifier {
   List<int>? _cachedSiblingIds;
   String? _cachedFamilyKey;
 
-  // Cached competence badge counts for performance
-  Map<int, int>? _competenceBadgeCounts;
-
-  static const _jsonEquality = DeepCollectionEquality();
+  static const _deepEquality = DeepCollectionEquality();
+  int _dataHash = 0;
 
   void updatePupil(PupilData pupilData) {
-    if (_jsonEquality.equals(_pupilData.toJson(), pupilData.toJson())) {
-      return;
-    }
+    final newHash = _deepEquality.hash(pupilData.toJson());
+    if (newHash == _dataHash) return;
+    _dataHash = newHash;
     _pupilData = pupilData;
-
-    // Invalidate cache when pupil data changes
-    _competenceBadgeCounts = null;
-
     notifyListeners();
   }
 
@@ -226,20 +212,11 @@ class PupilProxy with ChangeNotifier {
 
   List<CompetenceCheck>? get competenceChecks => _pupilData.competenceChecks;
 
-  List<CompetenceGoal> get competenceGoals =>
-      di<CompetenceManager>().getCompetenceGoals(pupilId);
-
   List<CompetenceReport>? get competenceReports => _pupilData.competenceReports;
 
   List<CompetenceReportCheck>? get competenceReportChecks =>
       _pupilData.competenceReportChecks;
 
-  List<PupilWorkbook>? get pupilWorkbooks =>
-      di<PupilWorkbookManager>().getPupilWorkbooks(pupilId);
-
-  List<PupilBookLending> get pupilBookLendings =>
-      di<PupilBookLendingManager>().getPupilBookLendings(pupilId);
-
   // learning support related
 
   SupportLevel? get latestSupportLevel {
@@ -276,61 +253,11 @@ class PupilProxy with ChangeNotifier {
         ?.score;
   }
 
-  List<SupportGoal> get supportGoals =>
-      di<LearningSupportManager>().getSupportGoals(pupilId);
-
   List<LearningSupportPlan>? get learningSupportPlans =>
       _pupilData.learningSupportPlans;
 
   // schoolday related
 
-  List<MissedSchoolday>? get missedSchooldays =>
-      di<AttendanceManager>().getAllPupilMissedSchooldays(pupilId);
   List<SchooldayEvent>? get schooldayEvents => _pupilData.schooldayEvents;
 
-  // Cached competence badge counts for performance
-  Map<int, int> get competenceBadgeCounts {
-    if (_competenceBadgeCounts != null) {
-      return _competenceBadgeCounts!;
-    }
-
-    // Calculate badge counts
-    final competenceChecks = _pupilData.competenceChecks ?? [];
-    final Map<int, int> counts = {};
-    final Set<int> countedIds = {};
-
-    try {
-      final competenceManager = di<CompetenceManager>();
-      final rootMap = competenceManager.rootCompetencesMap;
-
-      // Initialize counts for all root competences
-      for (final competenceId in rootMap.keys) {
-        if (rootMap[competenceId] == competenceId) {
-          counts[competenceId] = 0;
-        }
-      }
-
-      // Count checks per root competence
-      for (final check in competenceChecks) {
-        if (countedIds.contains(check.competenceId)) continue;
-        countedIds.add(check.competenceId);
-
-        final rootCompetence = competenceManager.findRootCompetenceById(
-          check.competenceId,
-        );
-        final int rootId = rootCompetence.publicId;
-
-        if (counts.containsKey(rootId)) {
-          counts[rootId] = counts[rootId]! + 1;
-        } else {
-          counts[rootId] = 1;
-        }
-      }
-    } catch (e) {
-      _log.warning('Error calculating competence badge counts: $e');
-    }
-
-    _competenceBadgeCounts = counts;
-    return counts;
-  }
 }

school_data_hub_flutter/lib/features/_attendance/domain/pupil_proxy_attendance_ext.dart

@@ -2,7 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_it/flutter_it.dart';
 import 'package:school_data_hub_flutter/common/widgets/orient_ui/button.dart';
 import 'package:school_data_hub_flutter/features/_pupil/domain/models/pupil_proxy.dart';
-import 'package:school_data_hub_flutter/features/learning/_competence/domain/competence_manager.dart';
+import 'package:school_data_hub_flutter/features/learning/_competence/presentation/learning_content_selection.dart';
 import 'package:school_data_hub_flutter/features/learning/_competence/presentation/pupil_list_learning_page/widgets/pupil_learning_content/pupil_learning_content_books.dart';
 import 'package:school_data_hub_flutter/features/learning/_competence/presentation/pupil_list_learning_page/widgets/pupil_learning_content/pupil_learning_content_competence_goals.dart';
 import 'package:school_data_hub_flutter/features/learning/_competence/presentation/pupil_list_learning_page/widgets/pupil_learning_content/pupil_learning_content_competence_statuses.dart';
@@ -21,7 +21,7 @@ class PupilLearningContentExpansionTileNavBar extends WatchingWidget {
   @override
   Widget build(BuildContext context) {
     final selectedContent = watchValue(
-      (CompetenceManager m) => m.selectedLearningContent,
+      (LearningContentSelection s) => s.selectedContent,
     );
 
     return Column(