fix: Update code style rules and improve SARIF logging

- Increased max line length to 200 for XML/JSON/config files in .editorconfig
- Added naming rule for static readonly fields (PascalCase, error)
- Disabled style rules for .received.*, .verified.*, and migration files
- Updated .csharpierignore to ignore NuGet config and test output files
- Renamed _newLineSeparator to NewLineSeparator in ProjectFactory.cs
- Enhanced SARIF result logging: only log on errors/warnings and when logger is enabled, with CA1873 suppression

Author: samtrion

.csharpierignore

@@ -1,3 +1,3 @@
-**/nuget.config
-**/_snapshots/
-**/_snapshot/
+**/[Nn]u[Gg]et.config
+**/*.verified.*
+**/*.received.*

.editorconfig

@@ -44,19 +44,22 @@ generated_code = true
 # XML project files
 [*.{slnx,csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj,nativeproj,locproj}]
 indent_size = 2
-max_line_length = 160
+max_line_length = 200
 
 # Xml build files
 [*.builds]
 indent_size = 2
+max_line_length = 200
 
 # Xml files
 [*.{xml,stylecop,resx,ruleset}]
 indent_size = 2
+max_line_length = 200
 
 # XML config files
 [*.{props,targets,ruleset,config,nuspec,vsixmanifest,vsct}]
 indent_size = 2
+max_line_length = 200
 
 # JSON files
 [*.json]
@@ -87,10 +90,6 @@ insert_final_newline = false
 [*.sln]
 indent_style = tab
 
-[*.{received,verified}.txt]
-insert_final_newline = false
-trim_trailing_whitespace = false
-
 [*.{cs,csx,vb,vbx}]
 # .NET Code Style Settings
 # See https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference
@@ -135,6 +134,13 @@ dotnet_naming_rule.all_const.severity                                   = error
 dotnet_naming_rule.all_const.style                                      = all_elements
 dotnet_naming_rule.all_const.symbols                                    = all_const
 
+dotnet_naming_style.all_static_readonly.capitalization                  = pascal_case
+dotnet_naming_symbols.all_static_readonly.applicable_kinds              = field
+dotnet_naming_symbols.all_static_readonly.required_modifiers            = static, readonly
+dotnet_naming_rule.all_static_readonly.severity                         = error
+dotnet_naming_rule.all_static_readonly.style                            = all_static_readonly
+dotnet_naming_rule.all_static_readonly.symbols                          = all_static_readonly
+
 dotnet_naming_style.all_fields.required_prefix                          = _
 dotnet_naming_style.all_fields.capitalization                           = camel_case
 dotnet_naming_symbols.all_fields.applicable_kinds                       = field
@@ -267,19 +273,18 @@ dotnet_diagnostic.IDE0290.severity                                      = sugges
 # [CSharpier] Incompatible rules deactivated
 # https://csharpier.com/docs/IntegratingWithLinters#code-analysis-rules
 dotnet_diagnostic.IDE0055.severity                                      = none
-dotnet_diagnostic.SA1000.severity                                       = none
-dotnet_diagnostic.SA1009.severity                                       = none
-dotnet_diagnostic.SA1111.severity                                       = none
-dotnet_diagnostic.SA1118.severity                                       = none
-dotnet_diagnostic.SA1137.severity                                       = none
-dotnet_diagnostic.SA1413.severity                                       = none
-dotnet_diagnostic.SA1500.severity                                       = none
-dotnet_diagnostic.SA1501.severity                                       = none
-dotnet_diagnostic.SA1502.severity                                       = none
-dotnet_diagnostic.SA1504.severity                                       = none
-dotnet_diagnostic.SA1515.severity                                       = none
-dotnet_diagnostic.SA1516.severity                                       = none
 
 # Support for NetEvolve.Arguments Methods
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1062#null-check-validation-methods
 dotnet_code_quality.CA1062.null_check_validation_methods                = M:NetEvolve.Arguments.Argument.ThrowIfNull(System.Object,System.String)|M:NetEvolve.Arguments.Argument.ThrowIfNull(System.Void*,System.String)|M:NetEvolve.Arguments.Argument.ThrowIfNullOrEmpty(System.String,System.String)|M:NetEvolve.Arguments.Argument.ThrowIfNullOrEmpty``1(System.Collections.Generic.IEnumerable{``0},System.String)|M:NetEvolve.Arguments.Argument.ThrowIfNullOrWhiteSpace(System.String,System.String)
+
+# Disable all style rules for generated code
+[*.{received,verified}.*]
+generated_code = true
+# Disable all style rules for migrations
+dotnet_analyzer_diagnostic.severity = none
+
+[**/Migrations/*.{cs,csx,vb,vbx}]
+generated_code = true
+# Disable all style rules for migrations
+dotnet_analyzer_diagnostic.severity = none

Directory.Packages.props

@@ -4,6 +4,7 @@
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
   </PropertyGroup>
   <ItemGroup>
+    <GlobalPackageReference Include="CSharpier.MSBuild" Version="1.2.6" />
     <GlobalPackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
     <GlobalPackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.201" />
     <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.201" />

ProjectBuilders.slnx

@@ -28,9 +28,6 @@
   <Folder Name="/tests/">
     <Project Path="tests/NetEvolve.ProjectBuilders.Tests.Unit/NetEvolve.ProjectBuilders.Tests.Unit.csproj" />
     <Project Path="tests/NetEvolve.ProjectBuilders.TUnit.Tests.Integration/NetEvolve.ProjectBuilders.TUnit.Tests.Integration.csproj" />
-    <Project
-      Path="tests/NetEvolve.ProjectBuilders.XUnit.Tests.Integration/NetEvolve.ProjectBuilders.XUnit.Tests.Integration.csproj"
-      Id="594f97b7-f15b-43c9-9067-996a157539ec"
-    />
+    <Project Path="tests/NetEvolve.ProjectBuilders.XUnit.Tests.Integration/NetEvolve.ProjectBuilders.XUnit.Tests.Integration.csproj" Id="594f97b7-f15b-43c9-9067-996a157539ec" />
   </Folder>
 </Solution>

src/NetEvolve.ProjectBuilders/ProjectFactory.cs

@@ -72,7 +72,7 @@ public sealed partial class ProjectFactory : IProjectFactory
     /// <inheritdoc cref="IProjectFactory.DirectoryBuilder" />
     public ISubdirectoryBuilder DirectoryBuilder => _tempDirectory;
 
-    private static readonly string[] _newLineSeparator = ["\r\n", "\r", "\n"];
+    private static readonly string[] NewLineSeparator = ["\r\n", "\r", "\n"];
 
     internal ProjectFactory(
         ITestPackageBuilder? testPackageBuilder,
@@ -205,9 +205,11 @@ await Parallel
 
         EnrichSarifResults(sarif);
 
-        if (!sarif.HasNoErrorsOrWarnings())
+        if (!sarif.HasNoErrorsOrWarnings() && _logger.IsEnabled(LogLevel.Information))
         {
+#pragma warning disable CA1873 // Avoid potentially expensive logging
             LogSarifResult(string.Join('\n', sarif.Results.Select(x => x.ToString())));
+#pragma warning restore CA1873 // Avoid potentially expensive logging
         }
 
         return sarif;
@@ -291,7 +293,7 @@ private void EnrichSarifResults(OutputFile? sarif)
 
         var outputLines = _output
             .SelectMany(x =>
-                x.Split(_newLineSeparator, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
+                x.Split(NewLineSeparator, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
             )
             .ToArray();
         var filteredResults = new List<OutputRunResult>();