Merge remote-tracking branch 'origin/main' into feature/read_e57

Author: dancergraham

README.md

@@ -6,9 +6,17 @@ This python library wraps the [rust e57 library](https://github.com/cry-inc/e57)
 
 - [x] Proof of concept xml reading
 - [ ] Read e57 to python dict
-- [ ] Read e57 to numpy array
+- [ ] Read e57 to numpy array - work in progress - see `read_points` method.
 - [ ] Write to e57 (format ?)
 
+## Getting Started
+
+We need a getting started guide - could you write one based on our tests?
+
+## Contributing
+
+All contributions welcome - feature requests, bug reports, documentation, sample files, tests, rust code, python code, sharing the project online / via social media, ...
+
 ## Testing
 
-`python -m pytest`
+`python -m pytest`

tests/test_e57.py

@@ -1,5 +1,7 @@
-import e57
 import numpy as np
+import pytest
+
+import e57
 
 
 def test_raw_xml():
@@ -11,3 +13,23 @@ def test_read_points():
     pointcloud = e57.read_points(r"testdata/bunnyFloat.e57")
     assert isinstance(pointcloud, np.ndarray)
     assert len(pointcloud) == 30_571
+
+
+def test_box_dimensions():
+    pointcloud: np.ndarray = e57.read_points(r"testdata/bunnyFloat.e57")
+    max_coords = pointcloud.max(0, None, False, -np.inf)
+    min_coords = pointcloud.min(0, None, False, np.inf)
+    X, Y, Z = max_coords - min_coords
+    assert X == pytest.approx(0.155698)
+    assert Y == pytest.approx(0.14731)
+    assert Z == pytest.approx(0.120672)
+
+
+def test_global_box_center():
+    pointcloud: np.ndarray = e57.read_points(r"testdata/bunnyFloat.e57")
+    max_coords = pointcloud.max(0, None, False, -np.inf)
+    min_coords = pointcloud.min(0, None, False, np.inf)
+    X, Y, Z = (max_coords + min_coords) / 2
+    assert X == pytest.approx(-0.016840)
+    assert Y == pytest.approx(0.113666)
+    assert Z == pytest.approx(-0.001537)