Skip to content

Commit e245916

Browse files
daohoangsonclaude
andcommitted
test: move computeDryBaseline tests into existing test files
Move each test next to the existing computeDryLayout tests in the corresponding file instead of a standalone test file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 003ee32 commit e245916

7 files changed

Lines changed: 174 additions & 181 deletions

packages/core/test/compute_dry_baseline_test.dart

Lines changed: 0 additions & 181 deletions
This file was deleted.

packages/core/test/style_margin_test.dart

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,33 @@ void main() {
799799
expect(drySize, equals(const Size(50, 10)));
800800
});
801801

802+
testWidgets('computeDryBaseline', (tester) async {
803+
final key = GlobalKey();
804+
await tester.pumpWidget(
805+
MaterialApp(
806+
home: Scaffold(
807+
body: SizedBox(
808+
width: 100,
809+
child: HorizontalMargin(
810+
key: key,
811+
left: 10,
812+
right: 10,
813+
child: const Text('Hello'),
814+
),
815+
),
816+
),
817+
),
818+
);
819+
await tester.pumpAndSettle();
820+
821+
final renderBox = key.renderBox;
822+
final baseline = renderBox.getDryBaseline(
823+
renderBox.constraints,
824+
TextBaseline.alphabetic,
825+
);
826+
expect(baseline, isNotNull);
827+
});
828+
802829
group('computeMaxIntrinsicWidth', () {
803830
testWidgets('computes with child', (tester) async {
804831
await tester.pumpSizedBox(left: 1, right: 2);

packages/core/test/style_sizing_test.dart

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,28 @@ Future<void> main() async {
591591
);
592592
});
593593

594+
testWidgets('computeDryBaseline', (tester) async {
595+
final key = GlobalKey();
596+
await tester.pumpWidget(
597+
MaterialApp(
598+
home: Scaffold(
599+
body: CssSizing(
600+
key: key,
601+
child: const Text('Hello'),
602+
),
603+
),
604+
),
605+
);
606+
await tester.pumpAndSettle();
607+
608+
final renderBox = key.renderBox;
609+
final baseline = renderBox.getDryBaseline(
610+
renderBox.constraints,
611+
TextBaseline.alphabetic,
612+
);
613+
expect(baseline, isNotNull);
614+
});
615+
594616
group('_guessChildSize with 2 dimensions', () {
595617
testWidgets('respect wide child', (tester) async {
596618
final key = GlobalKey();

packages/core/test/style_vertical_align_test.dart

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
import 'package:flutter/material.dart';
12
import 'package:flutter_test/flutter_test.dart';
3+
import 'package:flutter_widget_from_html_core/flutter_widget_from_html_core.dart';
24
import 'package:mocktail_image_network/mocktail_image_network.dart';
35

46
import '_.dart';
@@ -278,4 +280,29 @@ void main() {
278280
expect(explained, contains('Foo'));
279281
});
280282
});
283+
284+
testWidgets('ValignBaseline computeDryBaseline', (tester) async {
285+
final key = GlobalKey();
286+
await tester.pumpWidget(
287+
MaterialApp(
288+
home: Scaffold(
289+
body: ValignBaselineContainer(
290+
child: ValignBaseline(
291+
key: key,
292+
index: 0,
293+
child: const Text('Hello'),
294+
),
295+
),
296+
),
297+
),
298+
);
299+
await tester.pumpAndSettle();
300+
301+
final renderBox = key.renderBox;
302+
final baseline = renderBox.getDryBaseline(
303+
renderBox.constraints,
304+
TextBaseline.alphabetic,
305+
);
306+
expect(baseline, isNotNull);
307+
});
281308
}

packages/core/test/tag_li_test.dart

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -977,6 +977,30 @@ Future<void> main() async {
977977
);
978978
});
979979

980+
testWidgets('computeDryBaseline', (tester) async {
981+
final key = GlobalKey();
982+
await tester.pumpWidget(
983+
MaterialApp(
984+
home: Scaffold(
985+
body: HtmlListItem(
986+
key: key,
987+
marker: const Text('1.'),
988+
textDirection: TextDirection.ltr,
989+
child: const Text('Hello'),
990+
),
991+
),
992+
),
993+
);
994+
await tester.pumpAndSettle();
995+
996+
final renderBox = key.renderBox;
997+
final baseline = renderBox.getDryBaseline(
998+
renderBox.constraints,
999+
TextBaseline.alphabetic,
1000+
);
1001+
expect(baseline, isNotNull);
1002+
});
1003+
9801004
testWidgets('computeIntrinsic', (tester) async {
9811005
final key = GlobalKey();
9821006
await tester.pumpWidget(
@@ -1129,6 +1153,33 @@ Future<void> main() async {
11291153
expect(circle,
11301154
contains('alpha: 1.0000, red: 0.0000, green: 1.0000, blue: 0.0000'));
11311155
});
1156+
1157+
testWidgets('computeDryBaseline', (tester) async {
1158+
final key = GlobalKey();
1159+
await tester.pumpWidget(
1160+
MaterialApp(
1161+
home: Scaffold(
1162+
body: HtmlListItem(
1163+
marker: HtmlListMarker(
1164+
key: key,
1165+
markerType: HtmlListMarkerType.disc,
1166+
textStyle: const TextStyle(fontSize: 14),
1167+
),
1168+
textDirection: TextDirection.ltr,
1169+
child: const Text('Hello'),
1170+
),
1171+
),
1172+
),
1173+
);
1174+
await tester.pumpAndSettle();
1175+
1176+
final renderBox = key.renderBox;
1177+
final baseline = renderBox.getDryBaseline(
1178+
renderBox.constraints,
1179+
TextBaseline.alphabetic,
1180+
);
1181+
expect(baseline, isNotNull);
1182+
});
11321183
});
11331184
}
11341185

packages/core/test/tag_ruby_test.dart

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,29 @@ void main() {
247247
);
248248
});
249249

250+
testWidgets('computeDryBaseline', (tester) async {
251+
final key = GlobalKey();
252+
await tester.pumpWidget(
253+
MaterialApp(
254+
home: Scaffold(
255+
body: HtmlRuby(
256+
key: key,
257+
ruby: const Text('漢'),
258+
rt: const Text('かん'),
259+
),
260+
),
261+
),
262+
);
263+
await tester.pumpAndSettle();
264+
265+
final renderBox = key.renderBox;
266+
final baseline = renderBox.getDryBaseline(
267+
renderBox.constraints,
268+
TextBaseline.alphabetic,
269+
);
270+
expect(baseline, isNotNull);
271+
});
272+
250273
testWidgets('computeIntrinsic', (tester) async {
251274
final rt = GlobalKey();
252275
final ruby = GlobalKey();

0 commit comments

Comments
 (0)