Fix ORT not found in AppImage

Author: andriiryzhkov

src/ai/CMakeLists.txt

@@ -40,9 +40,13 @@ if(UNIX AND NOT APPLE)
   # before darktable has a chance to check the AI-enabled preference.
   # Also suppresses harmless "already registered" ONNX schema warnings
   # from system packages that link against libonnx.
+  # Use just the filename (not the full build-tree path) so g_module_open
+  # resolves it via LD_LIBRARY_PATH / system linker search. This is required
+  # for AppImage where the build-tree path does not exist at runtime.
+  get_filename_component(_ORT_LIB_NAME "${ONNXRuntime_LIBRARIES}" NAME)
   target_compile_definitions(darktable_ai PRIVATE
     ORT_LAZY_LOAD=1
-    ORT_LIBRARY_PATH="${ONNXRuntime_LIBRARIES}")
+    ORT_LIBRARY_PATH="${_ORT_LIB_NAME}")
   target_include_directories(darktable_ai PRIVATE ${ONNXRuntime_INCLUDE_DIRS})
 else()
   target_link_libraries(darktable_ai PUBLIC onnxruntime::onnxruntime)

tools/appimage-build-script.sh

@@ -70,6 +70,14 @@ cp -a /usr/lib/$ARCH-linux-gnu/libgphoto2_port/* ../AppDir/usr/lib/libgphoto2_po
 mkdir -p ../AppDir/usr/lib/gio
 cp -a /usr/lib/$ARCH-linux-gnu/gio/* ../AppDir/usr/lib/gio
 
+# Include ONNX Runtime library. ORT is loaded via dlopen (ORT_LAZY_LOAD) so
+# linuxdeploy can't detect it automatically. Copy from the build tree.
+ORT_LIB_DIR=$(cmake -LA -N ../build 2>/dev/null | grep ONNXRuntime_LIB_DIR:PATH | cut -d= -f2)
+if [ -d "$ORT_LIB_DIR" ]; then
+  cp -a "$ORT_LIB_DIR"/libonnxruntime*.so* ../AppDir/usr/lib/
+  echo "Bundled ONNX Runtime from $ORT_LIB_DIR"
+fi
+
 # Since linuxdeploy is itself an AppImage, we don't rely on it being installed
 # on the build system, but download it every time we run this script. If that
 # doesn't suit you (for example, you want to build an AppImage without an