Fix pg_dump error with invalid search_path. pg_dump set search_path to

empty string, appending the pgtt schema in this case make it fail.

Author: darold

pgtt.c

@@ -1983,7 +1983,7 @@ force_pgtt_namespace(void)
 		appendStringInfo(&search_path, "%s", pgtt_schema);
 		override = true;
 	}
-	else if (strstr(old_search_path, pgtt_schema) == NULL)
+	else if (strlen(old_search_path) > 0 && strstr(old_search_path, pgtt_schema) == NULL)
 	{
 		/*
 		 * first look if pg_catalog is at end of the search path to keep

test/expected/13_searchpath.out

@@ -5,79 +5,36 @@
 --
 ----
 DROP EXTENSION pgtt;
-SHOW search_path ;
-         search_path          
-------------------------------
- "$user", public, pgtt_schema
-(1 row)
 
+SHOW search_path ;
 create schema first_schema;
 create schema second_schema;
 SET search_path TO "$user",public,pg_catalog,fisrt_schema,second_schema;
 SHOW search_path ;
-                              search_path                              
------------------------------------------------------------------------
- "$user", public, pg_catalog, fisrt_schema, second_schema, pgtt_schema
-(1 row)
-
 CREATE EXTENSION pgtt;
 SHOW search_path ;
-                              search_path                              
------------------------------------------------------------------------
- "$user", public, pg_catalog, fisrt_schema, second_schema, pgtt_schema
-(1 row)
-
 SET search_path TO pg_catalog;
 SHOW search_path ;
-       search_path       
--------------------------
- pg_catalog, pgtt_schema
-(1 row)
-
 SET search_path TO public;
 SHOW search_path ;
-     search_path     
----------------------
- public, pgtt_schema
-(1 row)
 
 -- Test only pg_catalog in search_path.
 DROP EXTENSION pgtt;
 \c - -
 SHOW search_path;
-   search_path   
------------------
- "$user", public
-(1 row)
-
 SET search_path TO pg_catalog;
 SHOW search_path;
- search_path 
--------------
- pg_catalog
-(1 row)
-
 CREATE EXTENSION pgtt;
 SHOW search_path;
-       search_path        
---------------------------
-  pgtt_schema, pg_catalog
-(1 row)
 
 -- Test the pg_catalog at end of search_path.
 DROP EXTENSION pgtt;
 \c - -
 SET search_path TO "$user", public, pg_catalog;
 SHOW search_path;
-         search_path         
------------------------------
- "$user", public, pg_catalog
-(1 row)
-
 CREATE EXTENSION pgtt;
 SHOW search_path;
-               search_path                
-------------------------------------------
- "$user", public, pgtt_schema, pg_catalog
-(1 row)
 
+-- Test empty search path like set by pg_dump
+SELECT pg_catalog.set_config('search_path', '', false);
+SHOW search_path;

test/sql/13_searchpath.sql

@@ -34,3 +34,7 @@ SET search_path TO "$user", public, pg_catalog;
 SHOW search_path;
 CREATE EXTENSION pgtt;
 SHOW search_path;
+
+-- Test empty search path like set by pg_dump
+SELECT pg_catalog.set_config('search_path', '', false);
+SHOW search_path;