toBoolean NPE when called with [null] #66

Author: aeberhart

src/main/java/com/dashjoin/jsonata/Functions.java

@@ -1477,7 +1477,7 @@ public static Boolean toBoolean(Object arg) {
         if (arg instanceof List) {
             List l = (List)arg;
             if (l.size() == 1) {
-                result = toBoolean(l.get(0));
+                result = Boolean.TRUE.equals(toBoolean(l.get(0)));
             } else if (l.size() > 1) {
                 long truesLength = l.stream().filter(e -> Jsonata.boolize(e)).count();
                 result = truesLength > 0;

src/test/java/com/dashjoin/jsonata/NullSafetyTest.java

@@ -1,7 +1,9 @@
 package com.dashjoin.jsonata;
 
 import static com.dashjoin.jsonata.Jsonata.jsonata;
+import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
 import java.util.Map;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
@@ -49,6 +51,15 @@ public void testNotNull() {
         Assertions.assertNull(Jsonata.jsonata("$not($)").evaluate(null));
     }
 
+    @Test
+    public void testArrayContainingNull() {
+        List<String> list = new ArrayList<>();
+        list.add(null);
+        Assertions.assertFalse((boolean)jsonata("$ ? true : false").evaluate(list));
+        list.add("test");
+        Assertions.assertTrue((boolean)jsonata("$ ? true : false").evaluate(list));
+    }
+    
     @Test
     public void testSingleNull() {
         var x = Jsonata.jsonata("$single($, function($v, $i, $a){ $v })").evaluate(Arrays.asList(null, 1));