dependencies must be separated by ; instead of , (#15)

Author: francesco086

CHANGELOG.md

@@ -9,6 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 Anything MAY change at any time. The public API SHOULD NOT be considered stable.").
 While in this phase, we will denote breaking changes with a minor increase.
 
+
+## 0.3.0
+### Changed
+* Dependencies passed in CLI `--pkg-dependencies` or `PyProjectConfig` must be separated by `;` or newline (previously was `,` or newline)
+
 ## 0.2.0
 ### Added
 * First release of `dac`

pyproject.toml

@@ -53,3 +53,6 @@ build-backend = "setuptools.build_meta"
 
 [tool.black]
 line-length = 120
+
+[tool.ruff]
+line-length = 120

src/dac/_input/pyproject.py

@@ -28,5 +28,5 @@ def generate_pyproject_toml(self) -> str:
 
     def _get_list_of_project_dependencies(self) -> List[str]:
         splitted_by_newline = self.project_dependencies.splitlines()
-        splitted_by_newline_or_comma = [s for ss in splitted_by_newline for s in ss.split(",")]
+        splitted_by_newline_or_comma = [s for ss in splitted_by_newline for s in ss.split(";")]
         return sorted(map(lambda x: x.strip(), splitted_by_newline_or_comma))

test/unit_test/_input/pyproject_test.py

@@ -2,7 +2,6 @@
 
 import pytest
 import toml  # type: ignore
-
 from dac._input.pyproject import PyProjectConfig
 
 
@@ -11,7 +10,9 @@ def test_if_dependencies_are_passed_as_comma_separated_then_valid_pyproject_is_p
     project_name: str, project_version: str
 ):
     pm = PyProjectConfig(
-        project_name=project_name, project_version=project_version, project_dependencies="pandas,adlfs, pyarrow"
+        project_name=project_name,
+        project_version=project_version,
+        project_dependencies="pandas;adlfs; pyarrow",
     )
     toml_content = pm.generate_pyproject_toml()
     parsed_toml = toml.loads(toml_content)
@@ -46,7 +47,11 @@ def test_if_dependencies_are_passed_from_cat_requirements_then_valid_pyproject_i
 )
 def test_if_invalid_project_name_then_raise_error(name: str):
     with pytest.raises(ValueError) as e:
-        PyProjectConfig(project_name=name, project_version="0.1.2", project_dependencies="pandas,adlfs,pyarrow")
+        PyProjectConfig(
+            project_name=name,
+            project_version="0.1.2",
+            project_dependencies="pandas,adlfs,pyarrow",
+        )
     assert "Invalid project name" in str(e.value)
 
 
@@ -55,4 +60,8 @@ def test_if_invalid_project_name_then_raise_error(name: str):
     ["valid", "va_lid"],
 )
 def test_if_valid_project_name_then_dont_raise_error(name: str):
-    PyProjectConfig(project_name=name, project_version="0.1.2", project_dependencies="pandas,adlfs,pyarrow")
+    PyProjectConfig(
+        project_name=name,
+        project_version="0.1.2",
+        project_dependencies="pandas,adlfs,pyarrow",
+    )