Skip to content

Commit 2f1a4ef

Browse files
committed
Fix benchmark script folder references, use data caterer version in docker file for example
1 parent 81d19fc commit 2f1a4ef

3 files changed

Lines changed: 12 additions & 11 deletions

File tree

example/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
FROM datacatering/data-caterer:0.16.4
1+
ARG DATA_CATERER_VERSION=0.16.5
2+
FROM datacatering/data-caterer:${DATA_CATERER_VERSION}
23

34
COPY --chown=app:app build/libs/data-caterer-example-0.1.0.jar /opt/app/job.jar

example/benchmark/compare_benchmark_results.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
#!/usr/bin/env bash
22

3-
SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &>/dev/null && pwd)
3+
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
4+
RESULTS_DIR="$(cd "$SCRIPT_DIR/results" && pwd)"
45
LATEST_VERSION=${1:-0.11.5}
56
RESULT_FILE_REGEX="benchmark_results_([0-9\.]+)\.txt"
67

78
if [[ -z $2 ]]; then
89
echo "No second version to compare against passed into arguments, defaulting to previous version in results"
9-
PREVIOUS_VERSION_RESULT_FILE_NAME=$(ls -1 "$SCRIPT_DIR/results" | sort --version-sort | tail -2 | head -1)
10+
PREVIOUS_VERSION_RESULT_FILE_NAME=$(ls -1 "$RESULTS_DIR" | sort --version-sort | tail -2 | head -1)
1011
if [[ $PREVIOUS_VERSION_RESULT_FILE_NAME =~ $RESULT_FILE_REGEX ]]; then
1112
PREVIOUS_VERSION="${BASH_REMATCH[1]}"
1213
else
@@ -33,8 +34,8 @@ for plan in "${plans[@]}"; do
3334
plan_name=$(echo "$plan" | sed 's/io.github.datacatering.plan.benchmark.//')
3435
echo "Comparing performance for plan: $plan_name"
3536

36-
latest_version_results=$(cat "$SCRIPT_DIR/results/benchmark_results_${LATEST_VERSION}.txt" | grep "${plan}")
37-
previous_version_results=$(cat "$SCRIPT_DIR/results/benchmark_results_${PREVIOUS_VERSION}.txt" | grep "${plan}")
37+
latest_version_results=$(cat "$RESULTS_DIR/benchmark_results_${LATEST_VERSION}.txt" | grep "${plan}")
38+
previous_version_results=$(cat "$RESULTS_DIR/benchmark_results_${PREVIOUS_VERSION}.txt" | grep "${plan}")
3839

3940
latest_version_average_time=$(echo "$latest_version_results" | awk -F "," '{s+=$4} END {print s/3}')
4041
previous_version_average_time=$(echo "$previous_version_results" | awk -F "," '{s+=$4} END {print s/3}')

example/benchmark/run_benchmark.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ fi
1717
enable_query_engine_run=${ENABLE_QUERY_ENGINE_RUN:-true}
1818
enable_data_size_run=${ENABLE_DATA_SIZE_RUN:-true}
1919
enable_data_sink_run=${ENABLE_DATA_SINK_RUN:-true}
20-
data_caterer_track=${DATA_CATERER_MANAGEMENT_TRACK:-}
2120

2221
data_caterer_version=$(grep -E "^dataCatererVersion=" "$PROP_FILE" | cut -d= -f2)
2322
default_job="io.github.datacatering.plan.benchmark.BenchmarkParquetPlanRun"
@@ -64,17 +63,17 @@ run_docker() {
6463

6564
time_taken=$({
6665
time -p docker run -p 4040:4040 \
67-
-v "$(pwd)/build/libs/data-caterer-example-0.1.0.jar:/opt/app/job.jar" \
68-
-v "$(pwd)/benchmark/jars/blaze.jar:/opt/app/jars/blaze.jar" \
69-
-v "$(pwd)/benchmark/jars/comet.jar:/opt/app/jars/comet.jar" \
70-
-v "$(pwd)/benchmark/jars/gluten.jar:/opt/app/jars/gluten.jar" \
66+
-v "${EXAMPLE_DIR}/build/libs/data-caterer-example-0.1.0.jar:/opt/app/job.jar" \
67+
-v "${EXAMPLE_DIR}/benchmark/jars/blaze.jar:/opt/app/jars/blaze.jar" \
68+
-v "${EXAMPLE_DIR}/benchmark/jars/comet.jar:/opt/app/jars/comet.jar" \
69+
-v "${EXAMPLE_DIR}/benchmark/jars/gluten.jar:/opt/app/jars/gluten.jar" \
7170
-v "/tmp:/opt/app/data" \
7271
-e "PLAN_CLASS=$1" \
7372
-e "RECORD_COUNT=$2" \
7473
-e "DEPLOY_MODE=client" \
7574
-e "$driver_memory" \
7675
-e "$executor_memory" \
77-
-e "DATA_CATERER_MANAGEMENT_TRACK=$data_caterer_track" \
76+
-e "DATA_CATERER_VERSION=$data_caterer_version" \
7877
-e "ADDITIONAL_OPTS=$additional_conf" \
7978
datacatering/data-caterer:"$data_caterer_version";
8079
} 2>&1 | grep "real " | sed "$sed_option" "s/^.*real ([0-9\.]+)$/\1/")

0 commit comments

Comments
 (0)