Skip to content

Commit 7b6cefc

Browse files
authored
Merge pull request #97 from data-catering/bugfix/benchmark-scripts
Fix finding example jar and correct version
2 parents 8e3d3ff + fe237c7 commit 7b6cefc

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fetch-depth: 2
1919
- name: Check if benchmark has already run
2020
run: |
21-
version=$(grep dataCatererVersion gradle.properties | cut -d= -f2)
21+
version=$(grep dataCatererVersion ../gradle.properties | cut -d= -f2)
2222
if [ ! -f benchmark/results/benchmark_results_${version}.txt ]; then
2323
echo "No benchmark results for version: $version, starting to run benchmarks"
2424
else
@@ -34,10 +34,8 @@ jobs:
3434
- name: Get Spark query engine jars
3535
run: bash benchmark/setup_query_engine_jars.sh
3636
- name: Run benchmark script
37-
env:
38-
DATA_CATERER_MANAGEMENT_TRACK: ${{ secrets.DATA_CATERER_MANAGEMENT_TRACK }}
3937
run: |
40-
version=$(grep dataCatererVersion gradle.properties | cut -d= -f2)
38+
version=$(grep dataCatererVersion ../gradle.properties | cut -d= -f2)
4139
bash benchmark/run_benchmark.sh
4240
bash benchmark/compare_benchmark_results.sh "$version"
4341
- name: Create pull request

example/benchmark/run_benchmark.sh

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ run_docker() {
6363

6464
time_taken=$({
6565
time -p docker run -p 4040:4040 \
66-
-v "${EXAMPLE_DIR}/build/libs/data-caterer-example-0.1.0.jar:/opt/app/job.jar" \
66+
-v "${JOB_JAR}:/opt/app/job.jar" \
6767
-v "${EXAMPLE_DIR}/benchmark/jars/blaze.jar:/opt/app/jars/blaze.jar" \
6868
-v "${EXAMPLE_DIR}/benchmark/jars/comet.jar:/opt/app/jars/comet.jar" \
6969
-v "${EXAMPLE_DIR}/benchmark/jars/gluten.jar:/opt/app/jars/gluten.jar" \
@@ -94,6 +94,15 @@ if [[ $? -ne 0 ]]; then
9494
exit 1
9595
fi
9696

97+
# Resolve the latest non-sources/non-javadoc jar produced by the example project
98+
JOB_JAR=$(ls -t "${EXAMPLE_DIR}/build/libs"/*.jar 2>/dev/null | grep -v -E "(sources|javadoc)" | head -1)
99+
if [[ -z "$JOB_JAR" || ! -f "$JOB_JAR" ]]; then
100+
echo "Could not locate built job jar under ${EXAMPLE_DIR}/build/libs. Ensure the build produced a jar."
101+
ls -al "${EXAMPLE_DIR}/build/libs" || true
102+
exit 1
103+
fi
104+
echo "Using job jar: $JOB_JAR"
105+
97106
echo "Pulling image before starting benchmarks"
98107
docker pull datacatering/data-caterer:"$data_caterer_version"
99108

0 commit comments

Comments
 (0)