Skip to content

Commit eda1d1d

Browse files
authored
Feature/api improve (#112)
* Update benchmark action to get branch name correctly --------- Signed-off-by: Peter Flook <pflooky@hotmail.com>
1 parent d15a73c commit eda1d1d

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@ jobs:
2626
# 2. Build workflow completed successfully after a tag push
2727
if: |
2828
github.event_name == 'workflow_dispatch' ||
29-
(github.event.workflow_run.conclusion == 'success' &&
29+
(github.event.workflow_run.conclusion == 'success' &&
3030
github.event.workflow_run.event == 'push')
31-
defaults:
32-
run:
33-
working-directory: example
3431
steps:
3532
- name: Get branch name
3633
id: branch
@@ -48,6 +45,7 @@ jobs:
4845
fetch-depth: 2
4946
- name: Determine version to benchmark
5047
id: benchmark_version
48+
working-directory: example
5149
run: |
5250
if [ "${{ github.event_name }}" == "workflow_dispatch" ] && [ -n "${{ inputs.version }}" ]; then
5351
echo "value=${{ inputs.version }}" >> $GITHUB_OUTPUT
@@ -58,6 +56,7 @@ jobs:
5856
echo "Using version from gradle.properties: ${version}"
5957
fi
6058
- name: Check if benchmark has already run
59+
working-directory: example
6160
run: |
6261
skip_check="${{ inputs.skip_existence_check }}"
6362
version="${{ steps.benchmark_version.outputs.value }}"
@@ -75,6 +74,7 @@ jobs:
7574
exit 1
7675
fi
7776
- name: Wait for Docker image to be available
77+
working-directory: example
7878
run: |
7979
version="${{ steps.benchmark_version.outputs.value }}"
8080
echo "Waiting for Docker image datacatering/data-caterer:${version} to be available..."
@@ -102,8 +102,10 @@ jobs:
102102
repository: apache/datafusion-comet
103103
path: example/benchmark/build/datafusion-comet
104104
- name: Get Spark query engine jars
105+
working-directory: example
105106
run: bash benchmark/setup_query_engine_jars.sh
106107
- name: Run benchmark script
108+
working-directory: example
107109
env:
108110
BENCHMARK_VERSION: ${{ steps.benchmark_version.outputs.value }}
109111
run: |

0 commit comments

Comments
 (0)