Skip to content

Commit a574280

Browse files
andrewli81pietern
andauthored
Add optional region arg to "unity-catalog metastores create" (#547)
* Added region field * Line too long * Update databricks_cli/unity_catalog/metastore_cli.py Co-authored-by: Pieter Noordhuis <pcnoordhuis@gmail.com>
1 parent 8bf8310 commit a574280

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

databricks_cli/unity_catalog/api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ def __init__(self, api_client):
3131

3232
# Metastore APIs
3333

34-
def create_metastore(self, name, storage_root):
35-
return self.client.create_metastore(name, storage_root)
34+
def create_metastore(self, name, storage_root, region):
35+
return self.client.create_metastore(name, storage_root, region)
3636

3737
def list_metastores(self):
3838
return self.client.list_metastores()

databricks_cli/unity_catalog/metastore_cli.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,18 @@
3939
@click.option('--name', required=True, help='Name of the new metastore.')
4040
@click.option('--storage-root', required=True,
4141
help='Storage root URL for the new metastore.')
42+
@click.option('--region', required=False,
43+
help='Region for the new metastore. ' +
44+
'Only workspaces located in the same region can be assigned to this metastore.')
4245
@debug_option
4346
@profile_option
4447
@eat_exceptions
4548
@provide_api_client
46-
def create_metastore_cli(api_client, name, storage_root):
49+
def create_metastore_cli(api_client, name, storage_root, region):
4750
"""
4851
Create new metastore.
4952
"""
50-
metastore_json = UnityCatalogApi(api_client).create_metastore(name, storage_root)
53+
metastore_json = UnityCatalogApi(api_client).create_metastore(name, storage_root, region)
5154
click.echo(mc_pretty_format(metastore_json))
5255

5356

databricks_cli/unity_catalog/uc_service.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,13 @@ def __init__(self, client):
3131

3232
# Metastore Operations
3333

34-
def create_metastore(self, name, storage_root, headers=None):
34+
def create_metastore(self, name, storage_root, region, headers=None):
3535
_data = {
3636
'name': name,
3737
'storage_root': storage_root,
3838
}
39+
if region is not None:
40+
_data['region'] = region
3941
return self.client.perform_query('POST', '/unity-catalog/metastores', data=_data,
4042
headers=headers)
4143

0 commit comments

Comments
 (0)