Skip to content

Commit f1492dc

Browse files
authored
revert making python_named_parameters required in jobs.api.run_now (#429)
1 parent f191338 commit f1492dc

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

databricks_cli/jobs/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ def reset_job(self, json, headers=None, version=None):
4949
return self.client.client.perform_query('POST', '/jobs/reset', data=json, headers=headers,
5050
version=version)
5151

52-
def run_now(self, job_id, jar_params, notebook_params, python_params, python_named_params,
53-
spark_submit_params, headers=None, version=None):
52+
def run_now(self, job_id, jar_params, notebook_params, python_params, spark_submit_params,
53+
python_named_params=None, headers=None, version=None):
5454
return self.client.run_now(job_id, jar_params, notebook_params, python_params,
55-
python_named_params, spark_submit_params, headers=headers,
55+
spark_submit_params, python_named_params, headers=headers,
5656
version=version)
5757

5858
def _list_jobs_by_name(self, name, headers=None):

databricks_cli/jobs/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def run_now_cli(api_client, job_id, jar_params, notebook_params, python_params,
235235
spark_submit_params = json_loads(spark_submit_params) if spark_submit_params else None
236236
res = JobsApi(api_client).run_now(
237237
job_id, jar_params_json, notebook_params_json, python_params,
238-
python_named_params, spark_submit_params, version=version)
238+
spark_submit_params, python_named_params, version=version)
239239
click.echo(pretty_format(res))
240240

241241

databricks_cli/sdk/service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ def list_jobs(self, job_type=None, expand_tasks=None, limit=None, offset=None, h
156156

157157
return self.client.perform_query('GET', '/jobs/list', data=_data, headers=headers, version=version)
158158

159-
def run_now(self, job_id=None, jar_params=None, notebook_params=None, python_params=None, python_named_params=None,
160-
spark_submit_params=None, headers=None, version=None):
159+
def run_now(self, job_id=None, jar_params=None, notebook_params=None, python_params=None, spark_submit_params=None,
160+
python_named_params=None, headers=None, version=None):
161161
_data = {}
162162
if job_id is not None:
163163
_data['job_id'] = job_id

tests/jobs/test_cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,9 @@ def test_run_now_with_params(jobs_api_mock):
227227
assert jobs_api_mock.run_now.call_args[0][3] == json.loads(
228228
PYTHON_PARAMS)
229229
assert jobs_api_mock.run_now.call_args[0][4] == json.loads(
230-
PYTHON_NAMED_PARAMS)
231-
assert jobs_api_mock.run_now.call_args[0][5] == json.loads(
232230
SPARK_SUBMIT_PARAMS)
231+
assert jobs_api_mock.run_now.call_args[0][5] == json.loads(
232+
PYTHON_NAMED_PARAMS)
233233
assert echo_mock.call_args[0][0] == pretty_format(RUN_NOW_RETURN)
234234

235235

0 commit comments

Comments
 (0)